From: "Paul E. McKenney" <paulmck@kernel.org>
To: Joe Perches <joe@perches.com>
Cc: rcu@vger.kernel.org, Joel Fernandes <joelagnelf@nvidia.com>,
linux-kernel@vger.kernel.org, kernel-team@meta.com,
rostedt@goodmis.org
Subject: Re: [PATCH v2 10/12] checkpatch: Deprecate srcu_read_lock_lite() and srcu_read_unlock_lite()
Date: Wed, 2 Apr 2025 07:12:08 -0700 [thread overview]
Message-ID: <611ea05f-e7e7-4983-93cc-ee2995250e91@paulmck-laptop> (raw)
In-Reply-To: <18c590c303e23b90efaa698b2e21017153c1945f.camel@perches.com>
On Tue, Apr 01, 2025 at 09:49:11PM -0700, Joe Perches wrote:
> On Tue, 2025-04-01 at 21:23 -0700, Paul E. McKenney wrote:
> > On Tue, Apr 01, 2025 at 08:48:44PM -0700, Joe Perches wrote:
> > > On Tue, 2025-04-01 at 07:05 -0700, Paul E. McKenney wrote:
> > > > On Mon, Mar 31, 2025 at 11:53:25PM -0700, Joe Perches wrote:
> > > > > On Mon, 2025-03-31 at 14:03 -0700, Paul E. McKenney wrote:
> > > > > > Uses of srcu_read_lock_lite() and srcu_read_unlock_lite() are better
> > > > > > served by the new srcu_read_lock_fast() and srcu_read_unlock_fast() APIs.
> > > > > > As in srcu_read_lock_lite() and srcu_read_unlock_lite() would never have
> > > > > > happened had I thought a bit harder a few months ago. Therefore, mark
> > > > > > them deprecated.
> > > > >
> > > > > Would it be better to convert the 3 existing instances?
> > > >
> > > > Both are needed. The point of these checkpatch.pl changes is to prevent
> > > > other instances from being added.
> > >
> > > If those are changed, why not remove the prototypes & functions too?
> > > That would stop more instances being added no?
> >
> > Deprecating it for a cycle then removing the prototypes and functions
> > seems a bit more friendly to me.
>
> OK, please remember to push a checkpatch revert or equivalent
> when it's done. Thanks.
Agreed, and at the same time as I remove the prototypes and functions.
I expect that to be during the 6.17 merge window.
Thanx, Paul
next prev parent reply other threads:[~2025-04-02 14:12 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-31 21:02 [PATCH v2 0/12] Paul E. McKenney
2025-03-31 21:03 ` [PATCH v2 01/12] rcutorture: Make srcu_lockdep.sh check kernel Kconfig Paul E. McKenney
2025-03-31 21:03 ` [PATCH v2 02/12] rcutorture: Make srcu_lockdep.sh check reader-conflict handling Paul E. McKenney
2025-03-31 21:03 ` [PATCH v2 03/12] rcutorture: Split out beginning and end from rcu_torture_one_read() Paul E. McKenney
2025-03-31 21:03 ` [PATCH v2 04/12] rcutorture: Make torture.sh --do-rt use CONFIG_PREEMPT_RT Paul E. McKenney
2025-04-02 7:42 ` Sebastian Andrzej Siewior
2025-04-02 18:51 ` Paul E. McKenney
2025-04-07 19:12 ` [PATCH v3 4/12] " Paul E. McKenney
2025-04-08 14:29 ` [v3,4/12] " Joel Fernandes
2025-04-08 16:20 ` Paul E. McKenney
2025-03-31 21:03 ` [PATCH v2 05/12] rcutorture: Add tests for SRCU up/down reader primitives Paul E. McKenney
2025-04-08 20:18 ` [v2,05/12] " Joel Fernandes
2025-04-08 20:58 ` Paul E. McKenney
2025-04-08 22:05 ` Joel Fernandes
2025-04-08 22:21 ` Paul E. McKenney
2025-04-15 17:16 ` [PATCH v2 05/12] " Joel Fernandes
2025-04-15 17:59 ` Paul E. McKenney
2025-04-15 21:15 ` Paul E. McKenney
2025-04-16 1:14 ` Joel Fernandes
2025-04-16 3:55 ` Paul E. McKenney
2025-03-31 21:03 ` [PATCH v2 06/12] rcutorture: Pull rcu_torture_updown() loop body into new function Paul E. McKenney
2025-03-31 21:03 ` [PATCH v2 07/12] rcutorture: Comment invocations of tick_dep_set_task() Paul E. McKenney
2025-03-31 21:03 ` [PATCH v2 08/12] rcutorture: Complain if an ->up_read() is delayed more than 10 seconds Paul E. McKenney
2025-03-31 21:03 ` [PATCH v2 09/12] rcutorture: Check for ->up_read() without matching ->down_read() Paul E. McKenney
2025-03-31 21:03 ` [PATCH v2 10/12] checkpatch: Deprecate srcu_read_lock_lite() and srcu_read_unlock_lite() Paul E. McKenney
2025-04-01 6:53 ` Joe Perches
2025-04-01 14:05 ` Paul E. McKenney
2025-04-02 3:48 ` Joe Perches
2025-04-02 4:23 ` Paul E. McKenney
2025-04-02 4:49 ` Joe Perches
2025-04-02 14:12 ` Paul E. McKenney [this message]
2025-03-31 21:03 ` [PATCH v2 11/12] torture: Add --do-{,no-}normal to torture.sh Paul E. McKenney
2025-03-31 21:03 ` [PATCH v2 12/12] torture: Add testing of RCU's Rust bindings " Paul E. McKenney
2025-04-02 14:45 ` [PATCH v2 0/12] Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=611ea05f-e7e7-4983-93cc-ee2995250e91@paulmck-laptop \
--to=paulmck@kernel.org \
--cc=joe@perches.com \
--cc=joelagnelf@nvidia.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®