From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753319AbdBJQTC (ORCPT ); Fri, 10 Feb 2017 11:19:02 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:42903 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751519AbdBJQS7 (ORCPT ); Fri, 10 Feb 2017 11:18:59 -0500 To: Solarflare linux maintainers , Edward Cree , netdev@vger.kernel.org Cc: "linux-kernel@vger.kernel.org" From: Colin Ian King Subject: re: sfc: process RX event inner checksum flags Message-ID: <61213e24-db1d-8a56-e1a9-e68ae689b73f@canonical.com> Date: Fri, 10 Feb 2017 16:14:49 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi there, not sure if this is a bug, or intentional, but CoverityScan picked up a mismatch in arguments when calling efx_ef10_handle_rx_event_error() with commit "sfc: process RX event inner checksum flags" that landed in linux-next: CID 1402067 (#1 of 1): Arguments in wrong order (SWAPPED_ARGUMENTS)swapped_arguments: The positions of arguments in the call to efx_ef10_handle_rx_event_errors do not match the ordering of the parameters: rx_l3_class is passed to rx_encap_hdr rx_l4_class is passed to rx_l3_class rx_encap_hdr is passed to rx_l4_class The function in question has the prototype: static u16 efx_ef10_handle_rx_event_errors(struct efx_channel *channel, unsigned int n_packets, unsigned int rx_encap_hdr, unsigned int rx_l3_class, unsigned int rx_l4_class, const efx_qword_t *event) ...where as it it being called using: flags |= efx_ef10_handle_rx_event_errors(channel, n_packets, rx_l3_class, rx_l4_class, rx_encap_hdr, event); Is this a bug or intentional? Colin