From: Oliver Neukum <oneukum@suse.com>
To: Junlin Yang <angkery@163.com>,
gregkh@linuxfoundation.org, penguin-kernel@i-love.sakura.ne.jp,
loic.poulain@linaro.org, davem@davemloft.net,
lee.jones@linaro.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Junlin Yang <yangjunlin@yulong.com>
Subject: Re: [PATCH] usb: class: cdc-wdm: return the correct errno code
Date: Mon, 21 Jun 2021 15:34:51 +0200 [thread overview]
Message-ID: <6122b97bb4a30a917b16837e8f98b6aac69f897a.camel@suse.com> (raw)
In-Reply-To: <20210621132415.2341-1-angkery@163.com>
Am Montag, den 21.06.2021, 21:24 +0800 schrieb Junlin Yang:
> From: Junlin Yang <yangjunlin@yulong.com>
>
> The "rv" is initialized to "-ENOMEM", because "rv" is re-assigned to
> "-EINVAL", when kmalloc & usb_alloc_urb failed, the return value
> should
> return "-ENOMEM" rather than "-EINVAL",so the "rv" assignment is
> placed
> in the position where usb_endpoint_is_int_in is false.
>
> Signed-off-by: Junlin Yang <yangjunlin@yulong.com>
Acked-by: Oliver Neukum <oneukum@suse.com>
prev parent reply other threads:[~2021-06-21 13:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 13:24 Junlin Yang
2021-06-21 13:34 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6122b97bb4a30a917b16837e8f98b6aac69f897a.camel@suse.com \
--to=oneukum@suse.com \
--cc=angkery@163.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=yangjunlin@yulong.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®