From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A55612EB856; Fri, 20 Feb 2026 17:24:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771608250; cv=pass; b=KKof72vuyBejGNumiTeG2/NVhetL7zA/f0EgvwjRKJSbuTfg4devNqt6F8vgk9Y5otlW4/BIFDL/hjgPdtWj3z8dGcfdLfsj4SLfNkA9ejyPFtZ1PYqhc8rig7yBufSxwB1oDtZBxAVFDdWpCwopn7KW619oweZEdaq5/Cg64wc= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771608250; c=relaxed/simple; bh=Uu+s2Lyrmybwd7YznoHd3Q4l77Y4F6w9xREnUkwzcWE=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=aAF8DaOkiDUCsT4DH4s2/l/TPuVuSYssDjSGVkf1BaWsW0GQuWEZa+ryORQxT7nc08zClA8oSyKDrHtfOV1n86AgKcChQJafOlxFGYul1fp6d7qAm7OlG6JKXzGGPkadwG9LUSFdpAayra2n7rAdRchIXYz8vYcwfvpLhSr9Cfc= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=louisalexis.eyraud@collabora.com header.b=ODn65+XA; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=louisalexis.eyraud@collabora.com header.b="ODn65+XA" ARC-Seal: i=1; a=rsa-sha256; t=1771608235; cv=none; d=zohomail.com; s=zohoarc; b=YBCcT81WeOfR/jYm0ED2xKnwL1X6Nflt1qxXhPg6Nt/XV/5NEb0ibRJr4TzshY7mvg1Lve15oDVy6eDl+y912fQUDay4WLqVch+AF75puBK30G3EMwFNxav2mCfgWZQc5ADoU/vR3EeOBMrASyLICK6yXgnie1yl3MDJNCs9vT0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771608235; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=VMtBjDynAUrdGXb65pAy82w5yT36ShqPLb+7ARA+3p4=; b=fBgFi56qATptdpO05qbjDb5ZSnvvwkpOMun0WwiV5r0ErLAKyEBwsqHdcBxIJ14o9C0m+rA7olNxSCgCjHw++s8pFAdbrWMy7TrVT7d9OM4JGCDRp6XaFFlj02pWU3jFmUKX4VhtkuM6MS/P2+EbJaTK1hAP4sO4y+I1DPY6bgI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=louisalexis.eyraud@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1771608235; s=zohomail; d=collabora.com; i=louisalexis.eyraud@collabora.com; h=Message-ID:Subject:Subject:From:From:To:To:Cc:Cc:Date:Date:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:MIME-Version:Message-Id:Reply-To; bh=VMtBjDynAUrdGXb65pAy82w5yT36ShqPLb+7ARA+3p4=; b=ODn65+XAYumAU3ekou2ZiBT0MogrLVMNvz3Xz+x88kywWuT8wiRY/1WcFOrfxMoA Quw6vTLy522rnvZf+Xkx36kGge9dQrvBktkz0F6Hy3LBT30IQdpeBg6Klsi27T4t9oR tl5rtHMWll0Q/kBnoT/gd0iHYVAQzuCknui1K5mk= Received: by mx.zohomail.com with SMTPS id 177160823270486.7919574958737; Fri, 20 Feb 2026 09:23:52 -0800 (PST) Message-ID: <6122f085216c03469bc93f49f3d76b2072c24e71.camel@collabora.com> Subject: Re: [PATCH] mmc: mtk-sd: disable new_tx/rx and modify related settings for mt8189 From: Louis-Alexis Eyraud To: Cathy Xu , Chaotian Jing , Ulf Hansson , Matthias Brugger , AngeloGioacchino Del Regno Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Mengqi Zhang , Wenbin Mei , Andy-ld Lu , Yong Mao Date: Fri, 20 Feb 2026 18:23:47 +0100 In-Reply-To: <20260204020709.24604-1-ot_cathy.xu@mediatek.com> References: <20260204020709.24604-1-ot_cathy.xu@mediatek.com> Organization: Collabora Ltd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ZohoMailClient: External Hi, On Wed, 2026-02-04 at 10:06 +0800, Cathy Xu wrote: > Disable new_tx/rx and modify related settings helps avoid data > transmission instability, and better compatibility for mt8189. >=20 > Signed-off-by: Cathy Xu > --- > =C2=A0drivers/mmc/host/mtk-sd.c | 10 +++++----- > =C2=A01 file changed, 5 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c > index 302ac8529c4f..b2680cc054bd 100644 > --- a/drivers/mmc/host/mtk-sd.c > +++ b/drivers/mmc/host/mtk-sd.c > @@ -682,15 +682,15 @@ static const struct mtk_mmc_compatible > mt8189_compat =3D { > =C2=A0 .needs_top_base =3D true, > =C2=A0 .pad_tune_reg =3D MSDC_PAD_TUNE0, > =C2=A0 .async_fifo =3D true, > - .data_tune =3D true, > + .data_tune =3D false, > =C2=A0 .busy_check =3D true, > =C2=A0 .stop_clk_fix =3D true, > - .stop_dly_sel =3D 1, > - .pop_en_cnt =3D 2, > + .stop_dly_sel =3D 3, > + .pop_en_cnt =3D 8, > =C2=A0 .enhance_rx =3D true, > =C2=A0 .support_64g =3D true, > - .support_new_tx =3D true, > - .support_new_rx =3D true, > + .support_new_tx =3D false, > + .support_new_rx =3D false, > =C2=A0 .support_spm_res_release =3D true, > =C2=A0}; > =C2=A0 I've tested this patch on Genio 720-EVK board that uses MT8391 SoC, a MT8189 variant. I did not get issue with these new settings when using this board eMMC (MSDC0) or microsd (MSDC1). I did not observe issues with previous settings but as it does not seem to cause regressions, Tested-by: Louis-Alexis Eyraud Regards, Louis-Alexis