From: Joe Perches <joe@perches.com>
To: pheragu@codeaurora.org, Apw <apw@canonical.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Bryanh <bryanh@codeaurora.org>, Ckadabi <ckadabi@codeaurora.org>,
Tsoni <tsoni@codeaurora.org>
Subject: Re: Reminder to review a few patches sent two weeks ago
Date: Tue, 24 Jul 2018 17:33:07 -0700 [thread overview]
Message-ID: <612de3c34f4986ac3ee6040af200a0e179acdcbd.camel@perches.com> (raw)
In-Reply-To: <e531d3a7a9db2e8d06da01cab2ad090d@codeaurora.org>
On Tue, 2018-07-24 at 14:56 -0700, pheragu@codeaurora.org wrote:
> A reminder to review a few patches I had sent last week. Below are the
> links for the patches.
>
> https://lkml.org/lkml/2018/7/5/798
I have no fundamental object to this one, but
the 80 column use is unnecessary and should be
coalesced before it can be applied.
Perhaps:
# warn about #if 1
if ($line =~ /^.\s*\#\s*if\s+1\b/) {
WARN("IF_1",
"Consider removing the #if 1 and its #endif\n" . $herecurr);
}
> http://lists-archives.com/linux-kernel/29168320-checkpatch-check-for-invalid-return-codes.html
This one has I think too many existing uses of
things like "return -1;"
$ git grep -P "return\s*\-\d+\s*;" | wc -l
9929
How many of these are actually appropriate?
Also, no space is required between return and -1
by c90 and this should use $Int so it should be:
if ($line =~ /\breturn\s*\-\$Int\s*;/) {
etc...
next prev parent reply other threads:[~2018-07-25 0:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 21:56 pheragu
2018-07-25 0:33 ` Joe Perches [this message]
2018-07-26 0:40 ` pheragu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=612de3c34f4986ac3ee6040af200a0e179acdcbd.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=bryanh@codeaurora.org \
--cc=ckadabi@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pheragu@codeaurora.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®