From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-00364e01.pphosted.com (mx0a-00364e01.pphosted.com [148.163.135.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C2133914E8 for ; Fri, 7 Aug 2026 19:30:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786131029; cv=none; b=XckN+/pe1VJykKchFFKBu0/t4bCLTjVPVsDAQpH9uHVuCIRjsohm+M+kVMN6irwd27coNbCHDASjNefBDMF0DdeI69J3Z2NnsWg5OXtQYDKHswYcYy728NCvJmDGUHqPewgXxC6CXwn48Kp4hSUb73dvkW7hGS5y+vgNld/ibEY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786131029; c=relaxed/simple; bh=+abiA0C9BWSGaJu4nppPt2ptLYbQwu+ajUNOACmrLXw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JmdEUJ73nnSOpKFua/tPA0Q3005DR9srpAlJqLOCnoNAYZzZt1+WlpGJmoPU8ra06fXrgQ340hWZ0f6sIPCvDOwhEkL0bAWX0lj7dDHcRis/M+scYd8FlWPAMlfXMJ9p7Dw3zkezZ7IQ6gtsMewe/ytqe9QNAtUmqSXjrYt0sww= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=columbia.edu; spf=pass smtp.mailfrom=columbia.edu; dkim=pass (2048-bit key) header.d=columbia.edu header.i=@columbia.edu header.b=eYpBsPo4; arc=none smtp.client-ip=148.163.135.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=columbia.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=columbia.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=columbia.edu header.i=@columbia.edu header.b="eYpBsPo4" Received: from pps.filterd (m0167072.ppops.net [127.0.0.1]) by mx0a-00364e01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 677JMeMN3178899 for ; Fri, 7 Aug 2026 15:30:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=columbia.edu; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pps01; bh=ZpKR PnIV4oqYTKJqE+EJ6z2rQqJUSwLGbqnj2YwhhoU=; b=eYpBsPo4DNchJAVl//xL SIIhPWAbH+nX3mmGeKiVpmRTKDl38qaFmsI46+aLpEzKD7mI9gWCZIqA58jGcVCB FLDz5LloHgp0+3BsXmmBAQQQNeUjNph/cxadntGO6zdmwXi8OTsOCRvtvfEXHd8D N0hz3upW9KgdkMFAEMEKgVgzSAVziujsG6BnJHRuhGALmEAIUyvyy41XoHRv+hjm FQZFHkrgY69AKt0XDg42u1F0rr+KsR5eKcHiuKMEn2ZkL6/rJufXcOcvsm2L16Dx 4o7delZbyGuk9Ezh9j5TNdqAuKi6Pp/s7MqEf3LUlxx/W1sOGGor8z+v2RI5K3XL 8Q== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-00364e01.pphosted.com (PPS) with ESMTPS id 4fwhp8hvqe-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 07 Aug 2026 15:30:27 -0400 (EDT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-52cd0374265so61848071cf.1 for ; Fri, 07 Aug 2026 12:30:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786131026; x=1786735826; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ZpKRPnIV4oqYTKJqE+EJ6z2rQqJUSwLGbqnj2YwhhoU=; b=BudoiQhnhRJEBZy1i59z+JE6xxRDrZZ6GfjnzOS1JIJOqiaYZiCqiDL5Alun6WPjxq Fdcwqz+kg44jDDxpHvispXo2FqUxg5vN8dIFZ6pPRoFuq2LyCWoJuKKXcl1d+o9elHfy oePw+R4YBD9lgaFFb/L1vPObPqWvHUDz4mI8V9OXfKQD75QrO0hKdDQbYV0ALlWHs7ab lEOM4E0Ucp/rpigcuS/axpkXe2R/7TWUaIQJ8qL+XE902XJ5Z6vue3YdhFoNbdR83Kvq lsTqKnM3qFvpfYh/HXVTufgOQ1AFSK92E9hqfk/K4/NFRAVPvMDjuAEL0R7Fym2KW8SV GqUA== X-Forwarded-Encrypted: i=1; AHgh+RqtjDCfugQ2FcOg4LrtauNGDBt25vpC4snUfZb19TCzLQaZU1oiFjvmRHMTvbiRKy9F4NqGcb45bbnA3/8=@vger.kernel.org X-Gm-Message-State: AOJu0YzNT2D6kDKEH27gb1FxUKBncs0Myh3zKQxuR4ZXm/neKOQny+Sr St0+8uALr3N0+psMky3Ukxun8tW3brKdwWxsxr27FYMwWCxDrCgSQma4o8Tom4abXEEkHm2PGZ8 19a7JLFD6srfTgOcL1v/OP8CURaM3uJT4X2FbY40TMOGBFMAl5vm+vKj4tILKuw== X-Gm-Gg: AR+sD11honMb4MJHlwwmq/ayL8RFuzguW3XmOM0yRBQHsSsWp5R4sJdSzKHZwlp84Ec ngke2XTnXwxZeqo1VkdDjrTOUOdATYMYOAE3e0vk/CoCX5Welcl69mdKurhNXhY41gceenib9IW deEES4/hFPPQXwBgbzZJ/eqKQQonfnsklkfHO4SD1kTgYIiJ9EstTvhGHt1Xl02Fy9ILBe1h8QL 55DSpOiz9v5ZfcvwMQ+GNjifrSgEHCtYIhA519A5ATbrxiEblRFo1BunFAEpxqsxjiXLJ0y0nRx 9WvblpbtuIXDVrhQQUa1wUXCP/q17cZv34livN6fMRqXWMhzu0YjYgLH47HvZqGiREMygABX0q5 g9/O+n/26z896PLTq6QOVhiCwn5eC362hVJdmuL8MCYADqT/GZWH+Lge8qNME6UFH X-Received: by 2002:a05:622a:109:b0:516:e10f:7140 with SMTP id d75a77b69052e-52d20a5023dmr38290911cf.35.1786131026491; Fri, 07 Aug 2026 12:30:26 -0700 (PDT) X-Received: by 2002:a05:622a:109:b0:516:e10f:7140 with SMTP id d75a77b69052e-52d20a5023dmr38289631cf.35.1786131025892; Fri, 07 Aug 2026 12:30:25 -0700 (PDT) Received: from ?IPV6:2a00:a040:199:782e:ad40:551f:594a:fcd1? ([2a00:a040:199:782e:ad40:551f:594a:fcd1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4995dee21dcsm73783835e9.0.2026.08.07.12.30.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Aug 2026 12:30:24 -0700 (PDT) Message-ID: <612ed1ce-e7a7-410e-9ad7-256e77bc867c@columbia.edu> Date: Fri, 7 Aug 2026 22:30:22 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/6] mm/page_io: rename bio_associate_blkg_from_page() To: Matthew Wilcox Cc: Andrew Morton , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , Barry Song , Youngjun Park , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Christoph Hellwig , Johannes Weiner , Yosry Ahmed , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20260806-b4-page_io-folios-v1-0-0899bac3b826@columbia.edu> <20260806-b4-page_io-folios-v1-4-0899bac3b826@columbia.edu> Content-Language: en-US From: Tal Zussman In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwODA3MDE1MSBTYWx0ZWRfX4+DsOeyz93D1 vuzp3uGKK4VuQ8XCAoSFCeqBaP2QnqBHJQE+CNH7vR9kY1lh/EoB0MIzXzDDWH8/uDh9kr7oPLu B74WIudoXW+7/1KQ3i3G5f2J53yDEvmlQeoSnn7IkEvlys15CdkX X-Proofpoint-GUID: GgQiKooHOXHdPAZIbqbpPZBcRlaE4Zdf X-Authority-Analysis: v=2.4 cv=POw/P/qC c=1 sm=1 tr=0 ts=6a763253 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=x7bEGLp0ZPQA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Da8U98TiO7q1upZEImrf:22 a=SsB-OO3BMngHh3ZO9fOt:22 a=JfrnYn6hAAAA:8 a=UXSnSC6aE9JLshMh4N0A:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=1CNFftbPRP8L7MoqJWF3:22 X-Proofpoint-ORIG-GUID: GgQiKooHOXHdPAZIbqbpPZBcRlaE4Zdf X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA3MDE1MSBTYWx0ZWRfXzugP+q5SxRFZ ckds9vU//IxvxvRbmUBAOVv+NL5EyykklYJzLlstlvHLMorS3uHZ0TQvBZguaaaEcp+t49KipbS jEaZ8GTyV/vCmbHWulafk2dNUP1c7zJiFdLyMtP+bIGGS9pZFkqyLCBh5o63h4ctCDbul3WYcg4 hswYnYWbmzbIci7leSTP6IXUt8BoXbkwKOobhkWuFAF50zlJ7vmo7lHuQFdftLj+23r/Smmz5Bw /vLb2Ae8UKNzuG6kprhaubcRsw2hbd3CzMimhdVsZyELsnMEm9mQRkVmorBsWP4Q7hUdlYieou0 jujvnuwdmHvXkOxE/ghtTDyu9Zfue3KQUdeX+djyn8vav/hcxwSFLp2qXcPKY/U66j/EWug3gSU YzLmiLLAu7qKCscYmow4dqy3VlnhW6IQcrVnGne5wvkSbZRtdpq2j5L5sotlWhWwN7Y164n495R 528XD9RP8ss+IT1mB5Q== X-Proofpoint-Virus-Version: vendor=nai engine=6900 definitions=11868 signatures=596817 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=10 clxscore=1015 impostorscore=10 adultscore=0 priorityscore=1501 bulkscore=10 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608070151 On 8/7/26 2:56 PM, Matthew Wilcox wrote: > On Thu, Aug 06, 2026 at 06:55:36PM -0400, Tal Zussman wrote: >> This function takes a folio. Rename it to >> bio_associate_blkg_from_folio() accordingly. While at it, convert the >> macro in the !CONFIG_MEMCG || !CONFIG_BLK_CGROUP case to a function. >> >> Signed-off-by: Tal Zussman > > Reviewed-by: Matthew Wilcox (Oracle) > >> -static void bio_associate_blkg_from_page(struct bio *bio, struct folio *folio) >> +static void bio_associate_blkg_from_folio(struct bio *bio, struct folio *folio) > > It's s shame this isn't const-qualified (after all, we don't modify the folio). > That needs folio_memcg_charged() to take a const folio pointer, which it > could. And folio_memcg_blkg_css() and folio_memcg(). That's a followup > patch though. > I had the same thought when looking at this and went all the way down the callchain to dump_page(). I didn't want to flood the list with patches, but happy to send a couple follow-up patches once this is in mm-new.