From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3984C433EF for ; Thu, 3 Mar 2022 18:19:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235718AbiCCSUY (ORCPT ); Thu, 3 Mar 2022 13:20:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235336AbiCCSUX (ORCPT ); Thu, 3 Mar 2022 13:20:23 -0500 Received: from mail-il1-x12f.google.com (mail-il1-x12f.google.com [IPv6:2607:f8b0:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEE501A39DA for ; Thu, 3 Mar 2022 10:19:36 -0800 (PST) Received: by mail-il1-x12f.google.com with SMTP id w4so4701333ilj.5 for ; Thu, 03 Mar 2022 10:19:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=RsfBPvPjQbWkfsCIFYKkOFEX828krrg1hMvPgj+lvz8=; b=PyMMU7qd3oxhlTEd4LwgKVZiAwtJU9yGeJOO8HaL9O6vrQ9heD8W9dpOccJJd0UZBT dGoSWYAUHus0lHdGEC20BH8OhFs8nmbDRa5Eql/UnOR537ZiOfx1rFltWrpKJaD+IJy2 J0dmpBD1r440ShZFzYCIMttBv1kQxMvBrvtZA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RsfBPvPjQbWkfsCIFYKkOFEX828krrg1hMvPgj+lvz8=; b=JcrSZepJdUELC1eFdkLJq2Fcp8bKu1RfuE0afDuQ1NcGmoZ2uqe0cRu9Hz3yNAqaXu j5PMAvtF0ZnRnAXbjRnghRJOS5cjdS5ORckkTZV0ggG3pArqnPJIRk6j+L3/+LA6cRJ2 h+s5fBO6/OUzoQ8I7paTbrmxq8v6MVq+01KEmDrUXQpHMoyjy3Fwu/kmgYJRT2zQaayh cWU3mbBFlWXRAPFYPpBGhDXpku3SKgqakfK7acf615Eay/hZ7wrwfyj89QAzGux8nSDv tQoPyxB5IIS72MlJIPgbCMwCPylPVtzYvcpjJRCckutvNL98tz31q+lVDpQTZ6IljRib VkTg== X-Gm-Message-State: AOAM533EypIuEBW8moRbQvj0xbP0DJd87/7eAr9tF3SgnSvgKmUrRpB6 gHBPNfLSbvvxZoGfdLAG8AKalg== X-Google-Smtp-Source: ABdhPJzGtaHtk93Fcgl7CY6dZAId/kJM/jiFz5lw+/DNdeg20AQ9EenL+JMfZK/b/qGR4YvOpOIGug== X-Received: by 2002:a92:3314:0:b0:2bc:8054:9780 with SMTP id a20-20020a923314000000b002bc80549780mr29857850ilf.12.1646331576267; Thu, 03 Mar 2022 10:19:36 -0800 (PST) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id v3-20020a5d9483000000b00640d3d4acabsm2488331ioj.44.2022.03.03.10.19.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Mar 2022 10:19:35 -0800 (PST) Subject: Re: [PATCH V3] selftests: vm: Add test for Soft-Dirty PTE bit To: David Hildenbrand , Muhammad Usama Anjum , Andrew Morton , Shuah Khan Cc: kernel@collabora.com, kernelci@groups.io, Will Deacon , Gabriel Krisman Bertazi , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Shuah Khan References: <20220224212335.3045905-1-usama.anjum@collabora.com> <3b7c068b-ac7e-62fc-f0cd-a8dbf8642876@redhat.com> From: Shuah Khan Message-ID: <6133317f-4da0-3aae-f352-b75f0f94dbd4@linuxfoundation.org> Date: Thu, 3 Mar 2022 11:19:35 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <3b7c068b-ac7e-62fc-f0cd-a8dbf8642876@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/28/22 2:37 AM, David Hildenbrand wrote: > On 24.02.22 22:23, Muhammad Usama Anjum wrote: >> This introduces three tests: >> 1) Sanity check soft dirty basic semantics: allocate area, clean, dirty, >> check if the SD bit flipped. >> 2) Check VMA reuse: validate the VM_SOFTDIRTY usage >> 3) Check soft-dirty on huge pages >> >> This was motivated by Will Deacon's fix commit 912efa17e512 ("mm: proc: >> Invalidate TLB after clearing soft-dirty page state"). I was tracking the >> same issue that he fixed, and this test would have caught it. >> > > A note that madv_populate.c already contains some SOFTDIRTY tests > regarding MADV_POPULATE. Eventually we want to factor out > softdirty/pagemap handling+checks for easier reuse. > > Is this patch unnecessary then? thanks, -- Shuah