Re: [PATCH] mfd: Remove node variables that are unused with CONFIG_OF=n

[Jiri Slaby <jirislaby@kernel.org>]

On 08. 05. 25, 17:57, Nathan Chancellor wrote:
> A recent cleanup introduced a few instances of -Wunused-variable in
> configurations without CONFIG_OF because of_fwnode_handle() does not
> reference its argument in that case:
> 
>    drivers/mfd/twl4030-irq.c: In function 'twl4030_init_irq':
>    drivers/mfd/twl4030-irq.c:679:46: warning: unused variable 'node' [-Wunused-variable]
>      679 |         struct                  device_node *node = dev->of_node;
>          |                                              ^~~~
>    drivers/mfd/max8925-core.c: In function 'max8925_irq_init':
>    drivers/mfd/max8925-core.c:659:29: warning: unused variable 'node' [-Wunused-variable]
>      659 |         struct device_node *node = chip->dev->of_node;
>          |                             ^~~~
>    drivers/mfd/88pm860x-core.c: In function 'device_irq_init':
>    drivers/mfd/88pm860x-core.c:576:29: warning: unused variable 'node' [-Wunused-variable]
>      576 |         struct device_node *node = i2c->dev.of_node;
>          |                             ^~~~
> 
> Use the value of these variables as the argument to of_fwnode_handle()
> directly, clearing up the warnings.

It's good on its own.

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>

Though, I have a series to convert to dev_fwnode() in (I think) all the 
cases.

thanks,
-- 
js
suse labs