From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18820200C2 for ; Thu, 5 Feb 2026 11:44:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770291879; cv=none; b=DNnOO3uLd0ZSn9ZpWOy5X2qTRCPA04UgMLk84Kxd/LDALXTYp/jSFUxbn29ksb5A26oe7knxKjIVoLiV/B9/eojMGfN2ZITaI/LVzCh5vaVfDGjjIpfRyof1jZOB4EHWPMlFeaoOiW9ezVrpGrcCoGxpiC1l3+2wQIl8SaWqcTE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770291879; c=relaxed/simple; bh=3B3r8ZFmlMmPEXMtcMW+cvfD6+8gvI+M8EXaZz18KoA=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=QjctIk3Oqt6XsutKcfrZU2/6qjHSi+oQS2hjgfm0HDsJLiDFP0OJbyZxqnU4hGghmOObOSIupo7Eak/DXY7yAzoIoRP1Wp46TlZ7KGvYg6+W6iOGTPKXJa/Zt3IAdo5cqddCqa3gSR3qTVs17u3Aha4/cR9bKNIjmGcU5HefB7I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=b8rR3hey; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=I7ZLWU99; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="b8rR3hey"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="I7ZLWU99" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770291878; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3B3r8ZFmlMmPEXMtcMW+cvfD6+8gvI+M8EXaZz18KoA=; b=b8rR3heyFpXUMQXoxB42oJFOQs3rHTC9S9sJEmIfJFgUd8I2p9Ph8SKXMylXCDJmF2zUoS xZj157iuqKpA6g1rumVL97j+8EDN39JmqR3ihQyseYy1SFEDdEYtrNYF+5yXHAm6CpSApE 2HCGmf+vhQQoYwZsuldp3faKq9TfOZ0= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-627-z8FVjfIQN5qQWTLtafvX9g-1; Thu, 05 Feb 2026 06:44:37 -0500 X-MC-Unique: z8FVjfIQN5qQWTLtafvX9g-1 X-Mimecast-MFC-AGG-ID: z8FVjfIQN5qQWTLtafvX9g_1770291876 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-47edf8ba319so14714245e9.2 for ; Thu, 05 Feb 2026 03:44:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1770291875; x=1770896675; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=3B3r8ZFmlMmPEXMtcMW+cvfD6+8gvI+M8EXaZz18KoA=; b=I7ZLWU99mGGL8FSYE/knD2vPR92zCgCNnsoSBpUgP7YTAraY2syrRiD+WqNSX+jTX9 xyF1S8JNNoQLllRrr1WXNJsOoilUPDnFIOCyTLLQhYpF9fEm2iN6fgivvD6s50rSQV4n 7VNcUwowdoGIYF5LlTLRzMJPNE3+py7mJAGF3UxubusbqoixifIalcV0eaXR4CY8jcLB 0FZG+8Ho58YEWJuCcsQWQRwOe/D6GijvFEFu0hy/JFlKm+mProCj5BNbkydsLbigFFkM b66ItGq0v7JIWEFNG2a43M9tqhpgYhTfo/EW8qtL1C7rkGB8UlWCY+80EzebC2XzQFaZ CZ4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770291875; x=1770896675; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3B3r8ZFmlMmPEXMtcMW+cvfD6+8gvI+M8EXaZz18KoA=; b=g7lqB1w3myOU8bbYczmj0wcF5hY0Pjf7kGib503kkHwjmRJqOeecDSMuCOrXTJ3tJu 1DDiJPDwM1EIqdPxCwfGFeh3CsD/4lcJ3Sb0XgNapJRT2kzGoZJNoy+qUo9iLuFofpMx JHYeWXMh6/inGIdvA2Ek4xStigd9WNQ7aHFjmyK+LKWjbyNnzGaoli96bUCzEyA6uFb7 SQTE3wpII9hCC3TsWtqVOcZvH/73VxI9LF+bWbm/Sf+8Or2I+xhqEjolF1mmshKy7UhZ aQx0o9dP0ascxSkXfA5PdlnoXhlwE0Oab+O87K9uX4pDMhhbIsZHrVrFL+kNdhdt89Tj OtFg== X-Forwarded-Encrypted: i=1; AJvYcCXfAH7SGFjvVE2kpemfx6/Qs7FKbGlhFufNpQCJibbct0+IXoEWAGmnrEKvIQUOB+OtYFtijhcxJqlht14=@vger.kernel.org X-Gm-Message-State: AOJu0YzzwJv1B2D7H/depuhon3rs6fb0Bu1AywOmpLSMekWX2KDn/bd2 b18+9IBLxktPznOVytSmAVYxbuRAlkjAH9uVOxjQJZwHc5SAAyF3w4zlN7Ago+YUkXnsyAKqhE9 3Lw4PbUGlpKacA9TU6x6b7I/SF1qsGYHdi4hj2fkldgGCF1WX6UeZ7gN+fwq0tAArp2B0StPPmI l3 X-Gm-Gg: AZuq6aK7EljtTuU300xPTKWITqmEwN9vN8hYqPfyKeH9LSUy7fY2Vxa5iMzGX9UKVsM jsG0BB2sD08rTleJQplCt9IzOXxfawfPoKRFuevxO3uIraDU03if4XQ4xhOSAzxIIMxTr7geP+Z w1YEKdAVtDKwngZc1p9665B+qs8YOaQVg0GdRApJXsl1pxfHq9HQ1JsN1/84wDY4uOXktTevXid mj1by44SJ9EEqDqWDynM8ndVuoWNFFDrIYBPwq6cruseOFSHvMJZbe/9o0PNkhC9ktURCtwW9mf QRsftmsWD84c9k0w9s700Q3jddbe0kJOxYnSr5NyvOolJx97XSSXtVinngJ9E0BvXpE0gFmxBXt jjoVGf/9S5Ig97eubh15wzONU4MzI1+qqDADIkvOPptKKqw0e1OykbhV8m+0wl+1D08UjayClVX L0VVK4+H1d X-Received: by 2002:a05:600c:3488:b0:480:f27c:6335 with SMTP id 5b1f17b1804b1-4830e970950mr81053365e9.25.1770291875400; Thu, 05 Feb 2026 03:44:35 -0800 (PST) X-Received: by 2002:a05:600c:3488:b0:480:f27c:6335 with SMTP id 5b1f17b1804b1-4830e970950mr81053085e9.25.1770291874957; Thu, 05 Feb 2026 03:44:34 -0800 (PST) Received: from gmonaco-thinkpadt14gen3.rmtit.csb (185-132-178-103.hosted-by-worldstream.net. [185.132.178.103]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48317d35684sm52376245e9.7.2026.02.05.03.44.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Feb 2026 03:44:34 -0800 (PST) Message-ID: <613427efef5c10cf04920ae16f0380b64e580241.camel@redhat.com> Subject: Re: [PATCH v2 17/20] rv/rvgen: enforce presence of initial state From: Gabriele Monaco To: Wander Lairson Costa Cc: Steven Rostedt , Nam Cao , "open list:RUNTIME VERIFICATION (RV)" , open list Date: Thu, 05 Feb 2026 12:44:33 +0100 In-Reply-To: <20260204144914.104028-18-wander@redhat.com> References: <20260204144914.104028-1-wander@redhat.com> <20260204144914.104028-18-wander@redhat.com> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 (3.58.2-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2026-02-04 at 11:42 -0300, Wander Lairson Costa wrote: > The __get_state_variables() method parses DOT files to identify the > automaton's initial state. If the input file lacks a node with the > required initialization prefix, the initial_state variable is referenced > before assignment, causing an UnboundLocalError or a generic error > during the state removal step. >=20 > Initialize the variable explicitly and validate that a start node was > found after parsing. Raise a descriptive AutomataError if the definition > is missing to improve debugging and ensure the automaton is valid. >=20 > Signed-off-by: Wander Lairson Costa Reviewed-by: Gabriele Monaco > --- > =C2=A0tools/verification/rvgen/rvgen/automata.py | 4 ++++ > =C2=A01 file changed, 4 insertions(+) >=20 > diff --git a/tools/verification/rvgen/rvgen/automata.py > b/tools/verification/rvgen/rvgen/automata.py > index 270a3d0bf4ce7..cf82f04dbc661 100644 > --- a/tools/verification/rvgen/rvgen/automata.py > +++ b/tools/verification/rvgen/rvgen/automata.py > @@ -105,6 +105,7 @@ class Automata: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # wait for node declarat= ion > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 states =3D [] > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 final_states =3D [] > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 initial_state =3D "" > =C2=A0 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 has_final_states =3D Fal= se > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 cursor =3D self.__get_cu= rsor_begin_states() > @@ -131,6 +132,9 @@ class Automata: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 final_states.append(state) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 has_final_states =3D True > =C2=A0 > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if not initial_state: > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 raise= AutomataError("The automaton doesn't have an initial > state") > + > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 states =3D sorted(set(st= ates)) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 states.remove(initial_st= ate) > =C2=A0