From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946720AbcBRPIf (ORCPT ); Thu, 18 Feb 2016 10:08:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33798 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946255AbcBRPIc (ORCPT ); Thu, 18 Feb 2016 10:08:32 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1449700636-17195-2-git-send-email-paul.gortmaker@windriver.com> References: <1449700636-17195-2-git-send-email-paul.gortmaker@windriver.com> <1449700636-17195-1-git-send-email-paul.gortmaker@windriver.com> To: Paul Gortmaker Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, James Morris , "Serge E. Hallyn" , keyrings@linux-nfs.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH 1/2] security/keys: make big_key.c explicitly non-modular MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <612.1455808109.1@warthog.procyon.org.uk> Date: Thu, 18 Feb 2016 15:08:29 +0000 Message-ID: <614.1455808109@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > config BIG_KEYS > bool "Large payload keys" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > Since module_init translates to device_initcall in the non-modular > case, the init ordering remains unchanged with this commit. > > We also delete the MODULE_LICENSE tag since all that information > is already contained at the top of the file in the comments. > > Cc: David Howells > Cc: James Morris > Cc: "Serge E. Hallyn" > Cc: keyrings@linux-nfs.org > Cc: linux-security-module@vger.kernel.org > Signed-off-by: Paul Gortmaker I've applied this patch to my next tree. David