From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752665AbbKYWI7 (ORCPT ); Wed, 25 Nov 2015 17:08:59 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:56642 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752223AbbKYWI5 (ORCPT ); Wed, 25 Nov 2015 17:08:57 -0500 From: Arnd Bergmann To: Stephen Boyd Cc: Andy Gross , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Daniel Lezcano Subject: Re: [PATCH v2 1/3] ARM: qcom: Make an option for qcom clocksource platforms Date: Wed, 25 Nov 2015 23:08:28 +0100 Message-ID: <6140735.DAZiajTbh1@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1448485478-21699-2-git-send-email-sboyd@codeaurora.org> References: <1448485478-21699-1-git-send-email-sboyd@codeaurora.org> <1448485478-21699-2-git-send-email-sboyd@codeaurora.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:ko7m9gYdWObTK6+CFh0h8IO/eCj64NfhPdJZ3wcrZYhjw4GsiV+ bJTu4hbHiVjAGG2Gu70hPwxLcBvIu9UCx/J//muvkSL65Tay/h216nm8sVdUI8MZ0bWrNm1 WPbUg7EHuDJy0eB/w/vWDb0mW2EaGRfQTsRTybXfaJUMojtmDC4qWEyClUHW8onrxfhLg/t MFSNNbi5Jd8jWnP8rF/sw== X-UI-Out-Filterresults: notjunk:1;V01:K0:Igi+LLdTJT4=:jmMOTlLQU8i8TAYeaVq73E Xqu+m5KeqAu/8Axd3ZTGbggrZUxZuuf/6Iz9/o6Awn1HfHAwC7plzwAF4TPVNVfEhHu+QcNyr e2MBIlXKh8YkluVvVKrrEH1wblBuPg35HRuDXLxtRj/3h16Bt7z2V/hq+OF1EUVUHmii6e35K /bAdKfvq6k9dxyvA3SPNyDmb0Rncw6+ojDS3ELZpPLHVxaO0zu80iy1NsF6/32m646kbNqpn0 wHllqj+gWagGMgB2Y6/DB1ysV8KBuUwr7AtDCGNdrmBCtVjmz7DGxnpDtTDJ0vChRwraOZgvw MkjaNhWb1xCC7uDpilYs9qOxDOrJbGgLBFmzGFDKib2guZpYskoznqIWYx3lHsZ40do4ZG+zz EfvUjRvMdUYT3zeNQ0jIP2FVGQ5F51Lmpo/7dvg4w1qcx0cunYpsvLniWPK8K1S+anAohetzH rheqmRvenTiSHe50wdXFXLFFtM9Mx04IqYPphAEXxHlEun9KOjwvvXrh2upHp0L8cjYR6xgbL wvZQHblX/LVx5gftqoNtCXB7hEMbjmD8pkoDySxLfRVzx4LXvIJKRxZ2+o9q8oxFLUP0aKq2Y +IQ7JV8lHgtQdGIssu0NIkgRjjkQBPVR7iI0U/jHygD3nCtbq+Q4iZFJpqP8mEPbv2e/ym23t 1+qGmn3HkQRXnmwyyKad+dBqPuNb4P7Lyt3BZjVCIL1lssfPxIfLMKaNMvjBi4meYnGs6Kt79 fQW2B9y7sfKRW1xD Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 25 November 2015 13:04:36 Stephen Boyd wrote: > diff --git a/arch/arm/Makefile b/arch/arm/Makefile > index 2c2b28ee4811..999d523ac09f 100644 > --- a/arch/arm/Makefile > +++ b/arch/arm/Makefile > @@ -148,8 +148,7 @@ textofs-$(CONFIG_PM_H1940) := 0x00108000 > ifeq ($(CONFIG_ARCH_SA1100),y) > textofs-$(CONFIG_SA1111) := 0x00208000 > endif > -textofs-$(CONFIG_ARCH_MSM8X60) := 0x00208000 > -textofs-$(CONFIG_ARCH_MSM8960) := 0x00208000 > +textofs-$(CONFIG_HAVE_CLKSRC_QCOM) := 0x00208000 > textofs-$(CONFIG_ARCH_AXXIA) := 0x00308000 > > # Machine directory name. This list is sorted alphanumerically > diff --git a/arch/arm/mach-qcom/Kconfig b/arch/arm/mach-qcom/Kconfig > index 2256cd1e25d1..35a03967d9c2 100644 > --- a/arch/arm/mach-qcom/Kconfig > +++ b/arch/arm/mach-qcom/Kconfig > @@ -10,6 +10,14 @@ menuconfig ARCH_QCOM > > if ARCH_QCOM > > +config HAVE_CLKSRC_QCOM > + bool "Support platforms with qcom clocksource" > + default y > + select CLKSRC_QCOM > + help > + Select this option if you want to support platforms > + with the qcom clocksource such as MSM8660 and MSM8960. Hmm, if we use the option for two things, I think it could use a different identifier and title, as it seems counterintuitive to make the text offset based on the clocksource driver. Is there any common way to classify these, e.g. calling them 'pre-2013 models' or 'Snapdragon S4' as a way to identify them? The way it appears in Kconfig also still needs to reflect how this is a subset of the supported platforms (as your current patch does correctly). Arnd