From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 873D83148C6 for ; Tue, 2 Dec 2025 13:50:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764683437; cv=none; b=Bl68lU+SFXhVJ1+VDnxgjsLCvjUgCazZOQl247xJPdJUQx7WHl19BwWR8Aw6GG6CWSgYuGXK5Yhgwl0hXY1Vd3wZBmK5zUPyAl+/UmeYUdmbW7WJVDQoDJhwbCnL33nSm5jvCxSocsw1H0MGtP4wE7w9Fk6CiTnyahpJUP8frV4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764683437; c=relaxed/simple; bh=LhaFwAdu/Fz6q5nxDw8k/AUqHqbHJARKQ2qgwoUK78o=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=FL8RrjH/EnFc2SZCsin8HR26OAjJ4Jn1b9qS9H0zAHnVNLivGttJh7Zk9Ra02g28qk743ac4L4Sqlf2b0S+WAalNYs+Nq/wCODSGmPeOB/fyDl2pAaunI8Wk/W0PR+97sXxQsleYBI1BkQQ0OKVJwkoyjo2iSgQ3kolbefDoz5A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gIh8HXe6; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gIh8HXe6" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-47118259fd8so53769755e9.3 for ; Tue, 02 Dec 2025 05:50:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764683433; x=1765288233; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=8gqmfPqUGJNnpZYL2jaQaSraxMW5RhwWoqjqG64qTZU=; b=gIh8HXe6XUGI5pLRDPYPiY2EPuwp3VIdC3D4XSIb1oC/wf9RmeQB/Gdk11m/rkjfk2 rupijm/SNtmZct6rlm5tBdlIGaq+CnmIwx6TnziwvaEqosTDLtRb9QlKjlFwrlPDZhvQ 7VrFq4B3oAGg1Boqhpfu5NDmNyz53G6gqtcWvIiiztmz4wst1MEGCXfZy/kthQrSHUNh KfcRSXYSrjc4qgfloza7QZEC1fPjqQoP+KqjsI+45QziNLQ6VKEi4KzjImRdcUXlZ+X9 3cv32QPRQky27k5/ip4keN6l0HRTQO7z2dac+78RBy/dRfZM6kReSwbhMWDSq6W1QdQk EPhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764683433; x=1765288233; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8gqmfPqUGJNnpZYL2jaQaSraxMW5RhwWoqjqG64qTZU=; b=h4q1ZW0Gy3EY5vDA4a1FOnaxL8xlE3ljtZKaKVZRY1mdquVjMNXkGBadoddbjKpL/H FJySNhcmHSM5MVgxlki79fJIPQkwLgXcaoKtL+j0z+b9slWm9/XEujv7kJ8MQmi8piZH sYGwsc6LfX9WwTUDppAoycND68nnXQ+uge6c4vkp8TNBLZd3onp7+2LfaevjY3oeGsv3 +UKh8KnPZFeSfnNTYO47h6yE4qCITy835shbaZKFo07AwvW6uNSZ3CL1RNUQK/ee3sV8 b1P/pwwHYdhS0+D1H5Z7nB4jlPC1+8Uv01P6GI+f06ffKW/KmW/x7yKl1IuBZBx/YzrY EWoA== X-Forwarded-Encrypted: i=1; AJvYcCWTl+yi4TPvQDRWCVJxJipGdaj0o0G8tHDMjpaX6QTyXx1dRQXF9o533VPVGk+6P2fdBIH2sUDDK9FtLww=@vger.kernel.org X-Gm-Message-State: AOJu0YxH3kAqg67TukpWmZK5aL+BEWPc27FEnqbk7gsv0YOc+ebnkn0p OlcPmvON6AuV5RZbYnqp/i+hAtsmpVH9EYBX8fTtJuO45ymza2xLw0tw X-Gm-Gg: ASbGnctDxDzGwmfZQtr2vlgty6DW9odSGpLCN2uGHWnJ0OCs2xyL2Ver9N7JoFDYvRR XHYdvjdrVS7uQ+9ZqTnywM4q4+zKJCYUR5z5uYxqxPvqXt0/kC2GhoGICkHxUGaN9EhDAv3+rpl N7LPqJ6bGzxZgeQwI42XdNyaZQnN0XKL46kdQC4OY2fCdL1VD+C3dWnJz385DgyJableLTuLI7i 5IyTRt+bezjm/4xiBNdAunse50qNyO+3NkPNsqete7jGpy7Hld/RDiBtHs5qL17LvxJHCEqq9Kd 5MoXckXoeOYfBOZ3kk0M8PC0YoZGx1aR3Nwf0t33AM/SGH8zVGuJr4X7Bokq305IHmutlf1JX1o hPczlUW86jF0j1Gjlx2lgakrZYCDVf0UtoSGw2lWemdo3DUU+Qy2xJEHWIMsJBJkREPOc/cr+b/ G5eNlpKJvXNbdSV6RMJjk= X-Google-Smtp-Source: AGHT+IEV6IUEQ4zmnpCvt9yp7MvRVVkLGg7uNh0UVfL2Eu28c00bREziwfDzSdssdx2H79r09ZOyfA== X-Received: by 2002:a05:600c:4694:b0:46e:4246:c90d with SMTP id 5b1f17b1804b1-47904ad06f3mr293663915e9.11.1764683432791; Tue, 02 Dec 2025 05:50:32 -0800 (PST) Received: from [192.168.1.187] ([161.230.67.253]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-479111438b9sm341578365e9.2.2025.12.02.05.50.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Dec 2025 05:50:32 -0800 (PST) Message-ID: <6143064d409b8325bbbb2ddb1d468d5303b4303a.camel@gmail.com> Subject: Re: [PATCH v2 1/2] iio: adc: ad9467: fix ad9434 vref mask From: Nuno =?ISO-8859-1?Q?S=E1?= To: Tomas Melin , Lars-Peter Clausen , Michael Hennerich , Nuno Sa , Jonathan Cameron , David Lechner , Andy Shevchenko , Alexandru Ardelean Cc: Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 02 Dec 2025 13:51:12 +0000 In-Reply-To: <20251202-ad9434-fixes-v2-1-fa73d4eabbea@vaisala.com> References: <20251202-ad9434-fixes-v2-0-fa73d4eabbea@vaisala.com> <20251202-ad9434-fixes-v2-1-fa73d4eabbea@vaisala.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2025-12-02 at 12:53 +0000, Tomas Melin wrote: > The mask setting is 5 bits wide for the ad9434 > (ref. data sheet register 0x18 FLEX_VREF). Apparently the settings > from ad9265 were copied by mistake when support for the device was added > to the driver. >=20 > Fixes: 4606d0f4b05f ("iio: adc: ad9467: add support for AD9434 high-speed= ADC") > Signed-off-by: Tomas Melin > --- > =C2=A0drivers/iio/adc/ad9467.c | 2 +- > =C2=A01 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/iio/adc/ad9467.c b/drivers/iio/adc/ad9467.c > index f7a9f46ea0dc405e25f312197df4b2131871b4bc..2d8f8da3671dac61994a1864a= 82cdbef7f54c1af 100644 > --- a/drivers/iio/adc/ad9467.c > +++ b/drivers/iio/adc/ad9467.c > @@ -95,7 +95,7 @@ > =C2=A0 > =C2=A0#define CHIPID_AD9434 0x6A > =C2=A0#define AD9434_DEF_OUTPUT_MODE 0x00 > -#define AD9434_REG_VREF_MASK 0xC0 > +#define AD9434_REG_VREF_MASK GENMASK(4, 0) In theory we should fix it using the same mask style as the other variants = and then moving all to GENMASK(). However, I do not feel strong about it and I can send a follow u= p. Hence: Reviewed-by: Nuno S=C3=A1 > =C2=A0 > =C2=A0/* > =C2=A0 * Analog Devices AD9467 16-Bit, 200/250 MSPS ADC