From: Reinette Chatre <reinette.chatre@intel.com>
To: zhouchuangao <chuangaozhou@gmail.com>,
fenghua.yu@intel.com, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, x86@kernel.org
Cc: hpa@zytor.com, linux-kernel@vger.kernel.org,
zhouchuangao <zhouchuangao@xiaomi.com>
Subject: Re: [PATCH] x86/kernel/cpu/resctrl: replace 'of->kn->priv' with of_rft()
Date: Thu, 7 Jan 2021 14:29:14 -0800 [thread overview]
Message-ID: <614d7092-6234-a8e1-456a-752dcbf23f4f@intel.com> (raw)
In-Reply-To: <1609758533-14337-1-git-send-email-zhouchuangao@xiaomi.com>
Hi,
On 1/4/2021 3:08 AM, zhouchuangao wrote:
> The use of 'of->kn->priv' to get rftype can be found in several
> places in arch/x86/kernel/cpu/resctrl/rdtgroup.c, which may reduce
> readability.
>
> So replace the direct use 'of->kn->priv' with inline function
> of_rft(), which is more readable.
Readability can be subjective. The current assignment appears succinct
and in my opinion the additional layer of indirection does not improve
the readability.
Reinette
prev parent reply other threads:[~2021-01-07 22:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 11:08 zhouchuangao
2021-01-07 22:29 ` Reinette Chatre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=614d7092-6234-a8e1-456a-752dcbf23f4f@intel.com \
--to=reinette.chatre@intel.com \
--cc=bp@alien8.de \
--cc=chuangaozhou@gmail.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=zhouchuangao@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®