From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBF7DC04AA5 for ; Mon, 15 Oct 2018 18:49:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 82B48208B3 for ; Mon, 15 Oct 2018 18:49:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=cisco.com header.i=@cisco.com header.b="QK3gjbxX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 82B48208B3 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=cisco.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726954AbeJPCfq (ORCPT ); Mon, 15 Oct 2018 22:35:46 -0400 Received: from alln-iport-1.cisco.com ([173.37.142.88]:4250 "EHLO alln-iport-1.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726707AbeJPCfq (ORCPT ); Mon, 15 Oct 2018 22:35:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1145; q=dns/txt; s=iport; t=1539629357; x=1540838957; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=XbgV8xjLdW7wMJ/qjo6To1z3qhlXgU2lNaHxmlKVLtA=; b=QK3gjbxXZz+18uOWnnZInYicHov4dHO5DbZe9N3SWg1Bbce1GOkqXRHl I/NBhYJ4mUCbqm5klEtTjO8dVU+v9m8P8oj3blDy058zNMqjekxERNQ8N nUoB9e/e9I7kXO4XWwNubalP54Z/lvBpLTFgbanYB7WdxG39zrcT/1xcx A=; X-IronPort-AV: E=Sophos;i="5.54,385,1534809600"; d="scan'208";a="186319960" Received: from alln-core-2.cisco.com ([173.36.13.135]) by alln-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Oct 2018 18:49:16 +0000 Received: from [10.154.208.167] ([10.154.208.167]) by alln-core-2.cisco.com (8.15.2/8.15.2) with ESMTP id w9FInCod026848; Mon, 15 Oct 2018 18:49:12 GMT Subject: Re: [PATCH] kernel/signal: Signal-based pre-coredump notification To: Greg Kroah-Hartman Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , x86@kernel.org, Peter Zijlstra , Arnd Bergmann , "Eric W. Biederman" , Khalid Aziz , Kate Stewart , Helge Deller , Al Viro , Andrew Morton , Christian Brauner , Catalin Marinas , Will Deacon , Dave Martin , Mauro Carvalho Chehab , Michal Hocko , Rik van Riel , "Kirill A. Shutemov" , Roman Gushchin , Marcos Paulo de Souza , Oleg Nesterov , Dominik Brodowski , Cyrill Gorcunov , Yang Shi , Jann Horn , Kees Cook , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, "Victor Kamensky (kamensky)" , xe-linux-external@cisco.com, Stefan Strogin , Enke Chen References: <20181013064023.GA28177@kroah.com> <37401cea-5a37-2cd9-8595-8b07dfc4de7d@cisco.com> <20181015184358.GA12153@kroah.com> From: Enke Chen Message-ID: <614dad0f-97e3-91b4-0c29-c052d01922eb@cisco.com> Date: Mon, 15 Oct 2018 11:49:11 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181015184358.GA12153@kroah.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Auto-Response-Suppress: DR, OOF, AutoReply X-Outbound-SMTP-Client: 10.154.208.167, [10.154.208.167] X-Outbound-Node: alln-core-2.cisco.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Greg: On 10/15/18 11:43 AM, Greg Kroah-Hartman wrote: > On Mon, Oct 15, 2018 at 11:16:36AM -0700, Enke Chen wrote: >> Hi, Greg: >> >>> Shouldn't there also be a manpage update, and a kselftest added for this >>> new user/kernel api that is being created? >>> >> >> I will submit a patch for manpage update once the code is accepted. > > Writing a manpage update is key to see if what you are describing > actually matches the code you have submitted. You should do both at the > same time so that they can be reviewed together. Ok, will do at the same time. But should I submit it as a separate patch? > >> Regarding the kselftest, I am not sure. Once the prctl() is limited to >> self (which I will do), the logic would be pretty straightforward. Not >> sure if the selftest would add much value. > > If you do not have a test for this feature, how do you know it even > works at all? How will you know if it breaks in a future kernel > release? Have you tested this? If so, how? I have the test code. I am just not sure whether I should submit and check it in to the kselftest? Thanks. -- Enke