From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755622AbcFHUfa (ORCPT ); Wed, 8 Jun 2016 16:35:30 -0400 Received: from us-smtp-delivery-194.mimecast.com ([216.205.24.194]:48664 "EHLO us-smtp-delivery-194.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753945AbcFHUf2 (ORCPT ); Wed, 8 Jun 2016 16:35:28 -0400 From: Trond Myklebust To: Rob Landley , "linux-kernel@vger.kernel.org" , Anna Schumaker , "linux-nfs@vger.kernel.org" Subject: Re: [PATCH] Fix NFS option parsing bit-rot. Thread-Topic: [PATCH] Fix NFS option parsing bit-rot. Thread-Index: AQHRwEb9wwsfZtzYeUKM/uT0UkQv9Z/c2G2AgAMigID//8wDAA== Date: Wed, 8 Jun 2016 20:35:21 +0000 Message-ID: <615FD41F-9C7D-4BAA-8BC5-D1F3CA115A8E@primarydata.com> References: <57560021.5030708@landley.net> <575874E5.3070809@landley.net> In-Reply-To: <575874E5.3070809@landley.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [68.49.162.121] x-ms-office365-filtering-correlation-id: bdb92578-35f3-4861-cf74-08d38fdc6a05 x-microsoft-exchange-diagnostics: 1;BN3PR11MB0306;5:3eQgcVi7C0Ms1S+MOA198QubZsOlXtoOg2wmVYozCiw9ftYS80J7RlLReGgsw5SK7MBzFIS2IxRoCCYnJPtdDL7VBXXmS9PC/x8klmKcRof7Nr4uqssW4tWsuvEl0chyglGaDkB6sRZlRhtroyLilQ==;24:0k9NcOG7pZeAIE2M5GidpXClIN4x5upyYYMsNj/pn3PV+5SWWY3iC0aEf9H5SFuTQWn+oGtZZczj4n4OdytE7FIckradDNVLGZTE06di7U8=;7:Axida7CmggscTDWP1V9rGk95ON3j7REARjZJdDeTecw/Eb15fnz2AiptQh8M+CvF2G3EoO1eCZha4+8TufGWD2SSMBlAeu8JWimXbpoRwhukUpHig2RmgOaY2RT15yF/nMyjlhb62DnHtlSrAEUZXVmYl68SGBmcyAaGBdC++ZLub6tAcSI5Ymauhk3cIlP9hJOWsEtDAgJoPVyY7hn42w==;20:rPkpjwa3xCxcHBDS3xko73AaiP49aTcR1oS0WaFrJrnA5C3bzZMtz0VjqXoipRRSOIw0yfZqFL+gSfwXYUjOC0j54Ab5v9cMOKgT/sc5cleAcyr68DFlxR1pSHpjiGx5KDPai+YnTrjKlHsUDatc1lzHdoyg2T8uBfHgV9TyE9w= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR11MB0306; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(150554046322364); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040130)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041072)(6043046);SRVR:BN3PR11MB0306;BCL:0;PCL:0;RULEID:;SRVR:BN3PR11MB0306; x-forefront-prvs: 0967749BC1 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(189002)(199003)(24454002)(54356999)(50986999)(82746002)(76176999)(101416001)(106116001)(3660700001)(106356001)(3846002)(19580395003)(5008740100001)(3280700002)(2906002)(19580405001)(105586002)(83716003)(122556002)(66066001)(99286002)(87936001)(8936002)(8676002)(33656002)(68736007)(86362001)(10400500002)(2900100001)(6116002)(107886002)(81156014)(586003)(5002640100001)(102836003)(2950100001)(92566002)(36756003)(5001770100001)(97736004)(81166006)(2501003)(77096005)(5004730100002)(189998001)(104396002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN3PR11MB0306;H:BN3PR11MB0305.namprd11.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-ID: <9894CFE49BA64F4887D9415F24E46A79@namprd11.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: primarydata.com X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jun 2016 20:35:21.8870 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 03193ed6-8726-4bb3-a832-18ab0d28adb7 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR11MB0306 X-MC-Unique: kT7zP6JqTseHl6IlglCnWQ-1 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u58KZb7G012994 On 6/8/16, 15:41, "Rob Landley" wrote: >So addr= is at _best_ redundant. You MUST supply host:/ always, >the current code just wasn't using it. That’s because you just happen to be supplying an IP address instead of a hostname. The kernel has no DNS resolving functionality. It cannot resolve hostnames into IP addresses without help either by the caller or by means of an upcall. That is why ‘addr=’ has been a mandatory parameter ever since we introduced the text based parser. Now we could, theoretically, have the client call nfs_dns_resolve_name() on the hostname to resolve it. However that breaks when you have net namespaces and such, since the kernel’s dns_query() call is not container aware. Trond