From: "Jürgen Groß" <jgross@suse.com>
To: Paul Durrant <pdurrant@amazon.com>,
xen-devel@lists.xenproject.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH v3 2/4] xenbus: limit when state is forced to closed
Date: Thu, 12 Dec 2019 07:02:15 +0100 [thread overview]
Message-ID: <61622e02-9cdc-03bc-b107-f3d1e6ff0fb9@suse.com> (raw)
In-Reply-To: <20191211152956.5168-3-pdurrant@amazon.com>
On 11.12.19 16:29, Paul Durrant wrote:
> If a driver probe() fails then leave the xenstore state alone. There is no
> reason to modify it as the failure may be due to transient resource
> allocation issues and hence a subsequent probe() may succeed.
>
> If the driver supports re-binding then only force state to closed during
> remove() only in the case when the toolstack may need to clean up. This can
> be detected by checking whether the state in xenstore has been set to
> closing prior to device removal.
>
> NOTE: Re-bind support is indicated by new boolean in struct xenbus_driver,
> which defaults to false. Subsequent patches will add support to
> some backend drivers.
>
> Signed-off-by: Paul Durrant <pdurrant@amazon.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
next prev parent reply other threads:[~2019-12-12 6:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 15:29 [PATCH v3 0/4] xen-blkback: support live update Paul Durrant
2019-12-11 15:29 ` [PATCH v3 1/4] xenbus: move xenbus_dev_shutdown() into frontend code Paul Durrant
2019-12-11 15:29 ` [PATCH v3 2/4] xenbus: limit when state is forced to closed Paul Durrant
2019-12-12 6:02 ` Jürgen Groß [this message]
2019-12-11 15:29 ` [PATCH v3 3/4] xen/interface: re-define FRONT/BACK_RING_ATTACH() Paul Durrant
2019-12-12 6:04 ` Jürgen Groß
2019-12-13 8:59 ` Jürgen Groß
2019-12-13 9:02 ` Durrant, Paul
2019-12-11 15:29 ` [PATCH v3 4/4] xen-blkback: support dynamic unbind/bind Paul Durrant
2019-12-12 6:07 ` Jürgen Groß
2019-12-12 11:46 ` Roger Pau Monné
2019-12-12 12:04 ` Jürgen Groß
2019-12-20 12:45 ` [PATCH v3 0/4] xen-blkback: support live update Jürgen Groß
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61622e02-9cdc-03bc-b107-f3d1e6ff0fb9@suse.com \
--to=jgross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pdurrant@amazon.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®