From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84195129E9C for ; Fri, 9 Aug 2024 08:58:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723193907; cv=none; b=fF0aK2d0zv9lMXzrfjbyKUWRqBPgiSDLocKoI3wLYvsJRzR71yYqCOs4Grd7FshgJQw1AoXHi1pJciU3J14RMBxyfBrFKGNxxHB4Y5bO2JaBB1WJLj/IslA4DyvxTmqxG69IPkT78/0Zys+QAK1GhK5q9A5aLuOAUfYZFIQAKgc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723193907; c=relaxed/simple; bh=KiziGocZfQ011vxpKRCUv8yNOAjTy2RHqfbevq4z2UM=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=WI50Ocfo1L7/k/smusXt9nA5tWvIgmjbav5Yl/XySGwv8ho3oxPU7hBHsXcC7Fh6l1c7gFeTUsOCDc1HVSDVy0giFC80s1Sk7TFvvZnQEV1r2v8SBbtaGyBcOIagTbauWrC4n9CH5luSAkHHU1BCzvFaI3rUDF/FhjCftxL9X/M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Su1iE9ot; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Su1iE9ot" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723193903; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=sML3YzZIz+yskWIrnpgB+yUBCfurqFCNy3lpq/CSMx0=; b=Su1iE9otf5NAixzyEaeIR6AsAPDvbNYZYO+prd0SXzzWC9cJTja2C5qT9mp2L+7kmtafUs Ioh7j/g+NuOtcsw9UWBcCDI9x2Td6Spt445layxfQmdj7mcq2SagvuJNY7aAIzFPsE+q05 FtP+BhGzVpRXsQY+mGVzbLc4zjWs7v0= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-xud8zw8WO7O-_HuRvyk-sw-1; Fri, 09 Aug 2024 04:58:21 -0400 X-MC-Unique: xud8zw8WO7O-_HuRvyk-sw-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-368665a3fdfso963255f8f.1 for ; Fri, 09 Aug 2024 01:58:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723193901; x=1723798701; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=sML3YzZIz+yskWIrnpgB+yUBCfurqFCNy3lpq/CSMx0=; b=EhGGFK49W+2wSILv5pKlAZyfOb7HHfGbm/M+GIW02HcM0t+VZtoTdqv5V6xESCnAxS VOsdNJNHIEQOBdAjwrvLc0wSvmnqLHEtcIa/oi7bc+XXdTGOsZxspyrJ2VusAyzBjxq8 uQUPhq17qoGSh/hZIJPMbPMFc+44iclDTo3JQ84uceDvGHbnLfOZe1CcRdKOWDYgOkoU jHO6bmQyGu6CWIamvfy3aHQ3m0z/OEH3KVASPvdE+KE44Hz1yL7lgQTtCKu95EO6Anh0 pJJ7drYuTupaz59sRyUb7FZmf8MHKQfNiSU5fjBt1fjHd99K7UqcP2ODQvwz6C+y7uk1 lRyw== X-Forwarded-Encrypted: i=1; AJvYcCWOxXXBSE0FX+ApqC/ykqQ+7/FBDfzsmBub5tA9VFVJSTMHunlKeMSZRp9q+z8x9kQ4b0o9g/2G/P+my4ua+N9B8iNekb9fRofKHlll X-Gm-Message-State: AOJu0Yxx1Zr25HulTt608yR7CiZRVm0esQqDiN471GSNfBXEbmeOuYM/ /uG/TcTrafj7eK+niVvXcGGel8rCDcIZbwNLpN5/bPt14VJYgulq43OWL3N0NP5ultjcPcLFgdu EuZee8QYYidAWwWhTS36bPEWHYTL7YLBLJ0SaZnXbq5rYani/jghXurjC+YToUQ== X-Received: by 2002:a5d:6341:0:b0:368:57dd:3822 with SMTP id ffacd0b85a97d-36d5eeddcffmr721706f8f.37.1723193900700; Fri, 09 Aug 2024 01:58:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFZq+4P4t4Ib46KVqzvqIXF5ENpZsB1z0y4AYNTNT1VkfdkzrrflyF1N0gKmu92npRa3XV/pg== X-Received: by 2002:a5d:6341:0:b0:368:57dd:3822 with SMTP id ffacd0b85a97d-36d5eeddcffmr721688f8f.37.1723193900196; Fri, 09 Aug 2024 01:58:20 -0700 (PDT) Received: from ?IPV6:2003:cb:c71c:4e00:b097:7075:f6ba:300a? (p200300cbc71c4e00b0977075f6ba300a.dip0.t-ipconnect.de. [2003:cb:c71c:4e00:b097:7075:f6ba:300a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36d340acfdasm1485050f8f.13.2024.08.09.01.58.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Aug 2024 01:58:19 -0700 (PDT) Message-ID: <616401ea-289d-4ae2-acde-6704b0fa9c46@redhat.com> Date: Fri, 9 Aug 2024 10:58:18 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 1/2] mm: collect the number of anon large folios From: David Hildenbrand To: Ryan Roberts , Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org Cc: chrisl@kernel.org, kaleshsingh@google.com, kasong@tencent.com, linux-kernel@vger.kernel.org, ioworker0@gmail.com, baolin.wang@linux.alibaba.com, ziy@nvidia.com, hanchuanhua@oppo.com, Barry Song References: <20240808010457.228753-1-21cnbao@gmail.com> <20240808010457.228753-2-21cnbao@gmail.com> <1222cd76-e732-4238-9413-61843249c1e8@arm.com> <4465afdc-23e9-4844-a0a0-519f49b1229c@redhat.com> Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <4465afdc-23e9-4844-a0a0-519f49b1229c@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 09.08.24 10:42, David Hildenbrand wrote: >>> Not sure I fully understand why David prefers to do the unaccounting at >>> free-time though? It feels unbalanced to me to increment when first mapped but >>> decrement when freed. Surely its safer to either use alloc/free or use first >>> map/last map? >>> >>> If using alloc/free isn't there a THP constructor/destructor that prepares the >>> deferred list? (My memory may be failing me). Could we use that? >> >> Additionally, if we wanted to extend (eventually) to track the number of shmem >> and file mthps in additional counters, could we also account using similar folio >> free-time hooks? If not, it might be an argument to account in rmap_unmap to be >> consistent for all? > > Again, see NR_FILE_THPS handling. No rmap over-complication please. ... not to mention that it is non-sensical to only count pageache folios that are mapped to user space ;) -- Cheers, David / dhildenb