From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.168.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794235422; b=tnGwAbyntWgvgXzLDOOMBtBhag1Ju7z3GACY/VuTeMEiFAaxqnMxiq9HnwhHjUVbaOJp e+aIg494oXfJYNry0trebSe3DrWnSavVOKcoMkwW597uaq6H1hk8fj7Rj88iIPeULuOod dftLYfz2AYkDmQBEII9hPho9mBFd4FTXN13wm9QnznI8f3hKnDoAj6LoSNkI5LEInJW/X o+WTH6QjxXxffEHzS1zD2vWQQqlorIOCZaCGDn9oonwq8jB9pquefnnRjPi079Ap9x49S 5UyFaNkWBPVUO15MSeTzschvgzACJCr05MGxkolsSy8D9QC6Ok0EkwlcsaCo+JHSKzQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794235422; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Proofpoint-GUID:X-Proofpoint-ORIG-GUID: X-Authority-Analysis:X-Proofpoint-Spam-Info: X-Proofpoint-Spam-Details-Enc:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=js3PUCSX9RGe+iWVpuwLPjnKS299ziJYM/TNs2sZ3KQ=; b=f/SwO1Iz1LIhuaeugGXOpZ53kfzxxxqyljc8g1awE4Zf8s6DnDj2AuAmLnDOByhmmLMN QDWPNfQB6YOicb1G6OoO0T2/6blwKURprrnCXJPJzThv0elp48GnWfGKlyco5R5WaXjCx 7hqdtkjI9oB3pbzNHfscKpF4JEcz2KoPcvw1k6HnEyISvXHN/sSjUeVfXS611GbF2MBPj 3dd64qRbStHo9WKgTI9oB0uO2bumNvoD8lATtyrv2ZaMjwmIA4dk1+T9TLogSx4rVNSuY Yf1CXE+gU8kyKHmv1XUAzet8CsceOsar7ronyBYi2idDbHzmadrgP5LIcS4AESuNgSg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=RA3bYcBw; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b="kF1vO/0c"; arc=none smtp.remote-ip=205.220.168.131 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 300D8606A32A for ; Mon, 9 Nov 2026 14:43:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 300D8606A32A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=RA3bYcBw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=kF1vO/0c Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6A9DFMXL3589048 for ; Mon, 9 Nov 2026 14:43:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= js3PUCSX9RGe+iWVpuwLPjnKS299ziJYM/TNs2sZ3KQ=; b=RA3bYcBwND/tNCjZ cLdRZZiLcq9T4Tklbl+Dt6rOJWygToA2gxZOesvz87r8YJ5purBXw4hmnECJLmV8 JNno1dtpA/shkpgHDlc0nPGYa2QnJ3eMkSd3uPTk6NA55ELLs2fu8GK9g6gZLpIX mia91lxuavmbHx3G+WBQXIpPXFOizggz8ZEqmvj1/2dB/xcO5gdF8tzSs8dp7i0E Otwdmouv2odcrSLJErRe5e901TkYItRjVrEH9Xo8/67C9qKwprXM8suGai1rEOwH xuW7/FbPLLoiln6bhPuywPK80bb5LRlwVaYzY9ljbx6O7ux/5/YvlTD2kAqxAILJ DtxdyQ== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hudcj8mxt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 09 Nov 2026 14:43:40 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-3b0afbf532eso824745a91.0 for ; Mon, 09 Nov 2026 06:43:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1794235420; x=1794840220; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=js3PUCSX9RGe+iWVpuwLPjnKS299ziJYM/TNs2sZ3KQ=; b=kF1vO/0c41w+oEce95lRzdSo/125zmTTbMBK/gEKuWnJ3AUUap2TrdhtvZzIwnWJNq +Bh0UI6BjZTqL1aINIuusS1WG9ScQb1bAgOt78eCox2a7Ee5tfgwAJ0r0GVoUxEQU8V9 SdiS6pFKiu2oxxeDMwMed028B39dS3KbijljM3TSmCpvoY8XwzeTqZ6njpsM9zRuAF3P jbvDIlqm2RqEzy3igVzl6OyJkkEq9Upj6BjSEfA/0++X3BRUlnjPNDGMWhf7y03Gw/c1 GR5DhKRrI+GrLT1N/+RlcAyPuDoQTsgjWJud3hm9c1bnmXID1T0hTXuCPDJYuXzlqSo6 1A1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794235420; x=1794840220; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=js3PUCSX9RGe+iWVpuwLPjnKS299ziJYM/TNs2sZ3KQ=; b=rLOytGIu0n0XX1UMAZKcOoXRHhIN0wGjXHxAQ9NbLZ5/wM31ugVaUDAnsC/K53XPLm ZR0CDsAnuICeh6a53nv7JK/6cpZXYsjPhMEGxyfjxd8u2OrzkIPxnyVe9QIQTSodvw9j g8ddzRhvZOMPsIDEyywqxdVMXIXCL3HF3lI8n3iyET2CAHAM8fJKYFkfln+2wUROrAjf Twy0i0Id04K5768C9YBiCmQS62S18XGvgLCAy456DjDLPpLpHUbe9wTRbhUDfXkSBXWw K8nhDEzTRWb06MjQiUKcjbERHTe05s4IMx7xuH5VBaprqzEKzt3YViQ0m6LfPOP35+yV XxbA== X-Forwarded-Encrypted: i=1; AL+hErFFPo+8pkCGzU0MTlc4CaC1nG4AlTG/sta7+b6s/FOZJ/DJIi/ColU728ouULfLuPBFji266kQnysmqlYI=@vger.kernel.org X-Gm-Message-State: APuU4Z+yI9vciqsuexhDPcLe/ZJ2K/wSq+63UENbsu4nUxM9HgItDdIy TLxNKU0ISR3yCps/8k6aJ94wOTkLXaOPhMfFNqEI3NiIHzhByftm1Jbm61GCQVFeu1SFehceL+k 90W+4hG2KmK5Or5sL/HONFTQXwI/8T3AiibgNWG+9dDZehJGSoJ98RUM7058qKFZPW8w= X-Gm-Gg: AYBFou1jA3GNxogcgTQvNFesfKxzUDt8d7syfG2UW6zmZfaHDqoKWEMQcuIXycmH+e2 6PM3eGHYHZPBqZsiL38d/IKMIy9mq+Xv5QueaiFoPBSIczp4VsrPiBTptvlB2lZD1TrVPjbEqtD 62li4Ghjco3altqDNNaHvoWQXH/FWltr4i05yBF7vXwJ7WoETv6M/nLqfgzOJx36w3xBguRObFG QKZoj8XgHn7yFPlP/G9E0DP7eLsYJjH8FywLUvW/Nd3zqsezlxTRN6GWGgUU1FLOhDU8dNZXW/r caCuqBd3BZhA6toDXe+HpaedNWFZk7aZz6Br5iy4T/v5T/lSyTm6XvylAvjsYPBJonsHu2yx4MV EDs2VeQ7J1jhtKoONPP/LbKzqyWoIwYo91hCFsthsN01BG6d+3Xqzt0xYMxI2iVLl4hhxd0CRBm I9Jg== X-Received: by 2002:a17:90b:5807:b0:3ac:c98e:345e with SMTP id 98e67ed59e1d1-3b12d3d2aa5mr3285281a91.45.1794235419738; Mon, 09 Nov 2026 06:43:39 -0800 (PST) X-Received: by 2002:a17:90b:5807:b0:3ac:c98e:345e with SMTP id 98e67ed59e1d1-3b12d3d2aa5mr3285256a91.45.1794235419245; Mon, 09 Nov 2026 06:43:39 -0800 (PST) Received: from [10.218.50.86] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3b12790befasm7129841a91.13.2026.11.09.06.43.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Nov 2026 06:43:38 -0800 (PST) Message-ID: <61646f06-87f1-48da-9b88-8898bb488af7@oss.qualcomm.com> Date: Mon, 9 Nov 2026 20:13:33 +0530 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/6] soc: qcom: geni-se: Define the QSPI firmware protocol To: Krzysztof Kozlowski Cc: Mark Brown , Vinod Koul , Frank Li , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org References: <20261106-qspi_upstream_series-v1-0-21f43042dd60@oss.qualcomm.com> <20261106-qspi_upstream_series-v1-4-21f43042dd60@oss.qualcomm.com> <20261109-stimulating-oyster-of-respect-620b7b@quoll> Content-Language: en-US From: Jyothi Kumar Seerapu In-Reply-To: <20261109-stimulating-oyster-of-respect-620b7b@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: bVjH2etc0gV37cYzArDjKm62sUaulwoZ X-Proofpoint-ORIG-GUID: bVjH2etc0gV37cYzArDjKm62sUaulwoZ X-Authority-Analysis: v=2.4 cv=au0nmiZV c=1 sm=1 tr=0 ts=6af1dc1c cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=zJRp6_cAMcgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=rLV7qYPEkEEFJh5gh6kA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Spam-Info: AW1haW4tMjYxMTA5MDA1OCBTYWx0ZWRfXxUFcB6cIonez bK9qNbfZz4/nuoVKgJqa4XQqoTxtxVPT06+wJDITLHQGPzbR8Hr7QG71/26WBXu9u2E0DVLTn0v GkAO2HaRRKzrD268sqh0fUxaEFOtV+Y= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMTA5MDA1OCBTYWx0ZWRfXzKCFwfsDE5d3 8lKgftj97e+WZ4a7VLzZ2/7aarRz8kFTrLkCjC7XtE6r8+uNtHhr9pObLQ26LF+2nNLGnArP9VQ CeN9ZKvkmAGZ/ng6yUzx3OkYPKrPIAKhFI8bODKZSSyeA2gPF6D4bGIc1k/Qv0/YfeCYqVY2I6R 1mB1KORtiNWWIyCIpW229JBWQqe6PSL//OBpkEq7CwpDoUG227NZsBPngwUNUtsGH5FAtlWpnAQ G+j60fYoj3CT93y5RFHL/uhaGZShfPKa0d3MmqoBehJyUWtd4MwSBPQ7OhiACYAMEjMgk3+Nw9K rzx+jtIg4+jwdxDDzMbxf52jDXGRDpN9IBooJmZ9kEi40WPycxS27lbAGclWI6Jeqf2iMHC6I0z pyle+zAqX3MR9+N08A9KT1etZxE5vaLMFsNSFrIBzIVbDvh2Ujx48IfELYPxCeaLWpxv6thPGi1 SU44hB1aQpj3PvlHLuw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-11-09_05,2026-11-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 suspectscore=0 bulkscore=0 impostorscore=0 phishscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2611040001 definitions=main-2611090058 On 11/9/2026 7:14 PM, Krzysztof Kozlowski wrote: > On Fri, Nov 06, 2026 at 08:31:22PM +0530, Jyothi Kumar Seerapu wrote: >> Add GENI_SE_QSPI with firmware protocol ID 9. The GENI SPI driver uses >> this value to request QSPI firmware and validate the protocol running >> on a serial engine. >> >> Extend the firmware loader's protocol-name table to accept QSPI. >> Reject unused protocol IDs in the sparse table before looking up >> firmware. >> >> Signed-off-by: Jyothi Kumar Seerapu >> --- >> drivers/soc/qcom/qcom-geni-se.c | 7 +++++-- >> include/linux/soc/qcom/geni-se.h | 1 + >> 2 files changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c >> index 873bfbd6b2b7..396f3d81d292 100644 >> --- a/drivers/soc/qcom/qcom-geni-se.c >> +++ b/drivers/soc/qcom/qcom-geni-se.c >> @@ -122,7 +122,10 @@ struct geni_se_desc { >> static const char * const icc_path_names[] = {"qup-core", "qup-config", >> "qup-memory"}; >> >> -static const char * const protocol_name[] = { "None", "SPI", "UART", "I2C", "I3C", "SPI SLAVE" }; >> +static const char * const protocol_name[] = { >> + "None", "SPI", "UART", "I2C", "I3C", "SPI SLAVE", >> + [GENI_SE_QSPI] = "QSPI", > > Why are you creating holes in this array? Hi Krzysztof, The array is indexed by the GENI protocol ID. QSPI uses ID 9, while the existing entries cover IDs 0–5, so the designated initializer leaves entries 6–8 empty. The added NULL check rejects these unused entries before accessing the protocol name. Appending "QSPI" directly would incorrectly associate it with ID 6. > > Best regards, > Krzysztof