From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933057AbbDJWTS (ORCPT ); Fri, 10 Apr 2015 18:19:18 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:62688 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932193AbbDJWTO (ORCPT ); Fri, 10 Apr 2015 18:19:14 -0400 From: Arnd Bergmann To: broonie@kernel.org Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com, Kuninori Morimoto , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] ASoC: rnsd: fix build regression without CONFIG_OF Date: Sat, 11 Apr 2015 00:18:37 +0200 Message-ID: <6164726.dCMByIoYOc@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:c1q6i3SjxtXmtcRHli63VaGCyQrN+wPWm+mWo0i0B13D2rkwkdk YjuzefqInBvNuBPHSrPwjwA7xd/OyLpU7VqsZcAcQqDUKAjjN8PU4AAx99DRZ0Mr5aaiSgD CPmzNaUCzBc8oQVEUXhbV7Z+LDeOclQ1UdJMQ+MA5R386dcrAee2gpMn4kERTrZmTZwdEUA p2P4kQ20oR9YiaZBr5Qag== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The r-car sound driver only works when CONFIG_OF is set, and after a recent change has a compile-time dependency as well: sound/built-in.o: In function `rsnd_dma_request_channel': :(.text+0x9fb84): undefined reference to `of_dma_request_slave_channel' This could be fixed either by adding a static inline wrapper for the function, or by adding a Kconfig dependency. This implements the second approach, which seems appropriate because the driver in fact has a hard dependency. Signed-off-by: Arnd Bergmann Fixes: 72adc61f4637aa3 ("ASoC: rsnd: 1st DMAC dma-names cares subnode") diff --git a/sound/soc/sh/Kconfig b/sound/soc/sh/Kconfig index 2b3030415573..07114b0b0dc1 100644 --- a/sound/soc/sh/Kconfig +++ b/sound/soc/sh/Kconfig @@ -36,6 +36,7 @@ config SND_SOC_SH4_SIU config SND_SOC_RCAR tristate "R-Car series SRU/SCU/SSIU/SSI support" + depends on DMA_OF select SND_SIMPLE_CARD select REGMAP_MMIO help