From: David Brownell <david-b@pacbell.net>
To: "Jean-Christophe PLAGNIOL-VILLARD" <plagnioj@jcrosoft.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
Patrice Vilchez <patrice.vilchez@atmel.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
spi-devel-general@lists.sourceforge.net
Subject: Re: [PATCH 6/6] atmel_spi: fix warning In function 'atmel_spi_dma_map_xfer'
Date: Sat, 20 Nov 2010 14:59:28 -0800 (PST) [thread overview]
Message-ID: <616676.83025.qm@web180301.mail.gq1.yahoo.com> (raw)
In-Reply-To: <20101120214820.GG8942@pengutronix.de>
--- On Sat, 11/20/10, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> > + void
> *nonconst_tx = (void *)xfer->tx_buf; /* shut up gcc */
Reads like a bad patch to me. Fix the bug,
don't just silence GCC. Or at least use
a better comment mentioning a constness
cast problems).
- Dave
next prev parent reply other threads:[~2010-11-20 22:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20101120095906.GD4216@game.jcrosoft.org>
[not found] ` <1290247733-17834-6-git-send-email-plagnioj@jcrosoft.com>
2010-11-20 21:48 ` Uwe Kleine-König
2010-11-20 22:59 ` David Brownell [this message]
2010-11-21 2:19 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=616676.83025.qm@web180301.mail.gq1.yahoo.com \
--to=david-b@pacbell.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=patrice.vilchez@atmel.com \
--cc=plagnioj@jcrosoft.com \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®