From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EE683F6C58 for ; Wed, 8 Jul 2026 07:35:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783496163; cv=none; b=DvstoDmueniwmGebz8DNPa8Fw1HycDFEkin671yoS1D4K2iu83bR3jPDz9cVDqpKBZPbBWOpl4TrZjPHPSUho76CaSuiffLYql7dXM/zUcfCJSMi0LdAhnA/AyDgFeTLeQSM9toBmG4cfjRpw5TmQHWxOX8rMTnA7fSsvkako+U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783496163; c=relaxed/simple; bh=y0Cz+SxrOco+zFU9iy4Vm0qFLXihJyME9v+cI8jh0hk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pt3k73Z+KEPvQCUqTtzXsUvNaZpfn0Ogovl0BKBu6vfXPW83EggjkaGI0qQEDTNGarIOPWpoF4rR25C7Q4l7kh/W3SKAyVFyvUzcR4uABogkclpFmqlYXQloWtqRmQoYbIHrIu958MlgpX7gRadeCaEP4E3vW2bEnLRUWdDbrGw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kRY6/ELA; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hAL58MNT; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kRY6/ELA"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hAL58MNT" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6685DkV71817858 for ; Wed, 8 Jul 2026 07:35:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Qwiky552pR9eMSaRRVwfUr/gVpyg1XLXJ6fZAH0mOHM=; b=kRY6/ELA1dLyHeYa UrdOVrMPpKwcl7qbnrpjad0f0ZYnlS6l2lR3VL9G6c9pd5g8RF2yrTTUdX4551v6 bT9rXGBas6vB8mFnjO07ROegRrOrVxhYalFZPEq2BbSCHMgIvvIuRRO8NBLPTAEH TODzreIcCXJupZo+DdOMpXy2+MKgUUpK8kcWevQN6CpXuZ6ZQxxHzg85x9BynmKz 4SlAyQAHZUdldheC4StgJbjPcaICZdRXhOH/2eGo4rHYFxOrdTXyt2Nie+JgwCL6 Rml++x1khp5CAKWL9XzUH4sezLrIupvn3KNqX+y/UuRRabk21pCjBaaGtVK5QYsn JufrPA== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f9g7hggyt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 08 Jul 2026 07:35:46 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-8478e9c4bd2so566691b3a.1 for ; Wed, 08 Jul 2026 00:35:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783496146; x=1784100946; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Qwiky552pR9eMSaRRVwfUr/gVpyg1XLXJ6fZAH0mOHM=; b=hAL58MNT8vJSb+kwgmDmh/QrJNPbYxr0sKSQQlB7ZS6GpUOl7ERQxCoWQVwTepNor7 0+epfpS/VJoiCoTpS2VhVlNoAcGrwvciciN/oHpm7oV/loSLhVNBIjuz9XjfbgSA3lW3 VgvaeQD/ZJmVUG4SW+DER59KIPZa3u4XWNPXzchSc4BjrvnTKoyGx7eTPthap4shC0Np Vx5oEthqJw/ePPjnaiP4xAdsVsk48KspUC5mVTpXuQ7nyeI2U5RfnfnPGaaZgfrUeGHD SRcWr5ceENB2o8Kt4/CeDulkMahc10zAECTT2FMex4Kw7BJyIoj6gltbRVT4i8sJjxsE TGQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783496146; x=1784100946; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Qwiky552pR9eMSaRRVwfUr/gVpyg1XLXJ6fZAH0mOHM=; b=gtQL4qA+gfO2Z/H83QCVofkhlAJ3LDNtyJQJ2a6+LEKubX6iEtJ9autoAAJaze0v/i Nd+7WRr0PrKrOHGxAxm69CnwkPa0FSn/y+U6l81Or018neu3lytqUPnMX0ugxwNjYoy/ vvOT358kHOs2vdTNNmgl2W8cNAG8ztuY0lx8GMbCKwzp2BCcurD043jDQdcYimhSQXU0 liN43Q0/NjNDU/EvN+06JhR0+JsiECoCOOJqpp3TXB5nSZ3eCIEB4jm9CCnzwftXHQ8M D5iaz7NOkQmMb2M+IxF1B/3SEbpEfF25Lz218Go2u2BjGIuSTDlYsLhwbbhMAk5iiKA1 RwMQ== X-Forwarded-Encrypted: i=1; AHgh+Rpb3MROxnBYDCnhzYhwgObYSaGONiFAEPbKny5P6sRONKIl4exB1wYb/9HGiTKmzgfk4g5XqdU8xTtyxcE=@vger.kernel.org X-Gm-Message-State: AOJu0YyZxi+RclpGitnmz8xmiAIDMeaKxK69JDZW/c3hskaq5vPTdcpT niIHdrw9nlowSa4ebk4psY729+svRra7qL0fhJa3sTxIcs7CttCFPau295Drw5OlvDO1gdkphm3 ZBynQEtiyg1I0lheesyyLbLaO/pMNQNH3DaAvsM4/JAmIsmRIAxw8LK1+HOLgDIXwPV0= X-Gm-Gg: AfdE7cmzyGj+Po4jGtXMdr+Rew6BvZvrbakPUDD5Yd8xJR26nGyaF79tWZ1HoliEtuR oaHAAG8uknBu3w8tyWpOmI75z2EhGgp+2A8j5Mr26bvyWdnf3Ngun/RBcwGlBkiV6XVfv+DhcIb 8pxQzfIeDwzPegJ+15x9gucT4gS4FMyKKYlSiIcETdM4F8bajBdl5wAZXqDT3G9neY0efnCxq6Y Pz1Q9qUcMOr1BC/4Yjsqx/h0tUbbnr+4I7KVHNba5KfYNk+f5sPDbVDAcNZIi7D/FZRiCINagFC 8n5zxLD7bBRL8gD9RerhWCTI6jiZP9QTODymRejplS1HvYRT2YqSdA2nwDmwu7Y3jtQPDHVepzU FFjgVG/KSDFXJ1iqIKhZnU39VrlOcV6hmKEc83MYWi2wK X-Received: by 2002:a05:6a00:4405:b0:847:7f7a:dd18 with SMTP id d2e1a72fcca58-84842fe8cf0mr1626492b3a.3.1783496145881; Wed, 08 Jul 2026 00:35:45 -0700 (PDT) X-Received: by 2002:a05:6a00:4405:b0:847:7f7a:dd18 with SMTP id d2e1a72fcca58-84842fe8cf0mr1626467b3a.3.1783496145378; Wed, 08 Jul 2026 00:35:45 -0700 (PDT) Received: from [10.217.219.87] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847f6bcf03bsm6588179b3a.26.2026.07.08.00.35.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jul 2026 00:35:44 -0700 (PDT) Message-ID: <6167cdea-50d0-4319-9f4d-1f1b349600df@oss.qualcomm.com> Date: Wed, 8 Jul 2026 13:05:41 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] i2c: qcom-geni: use dedicated completions for abort and reset events To: Praveen Talari , Viken Dadhaniya , Andi Shyti Cc: linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Naresh Maramaina References: <20260708-fix_cancel_sequence_on_failure_for_i2c-v1-0-dd8f841f36a2@oss.qualcomm.com> <20260708-fix_cancel_sequence_on_failure_for_i2c-v1-2-dd8f841f36a2@oss.qualcomm.com> Content-Language: en-US From: Mukesh Savaliya In-Reply-To: <20260708-fix_cancel_sequence_on_failure_for_i2c-v1-2-dd8f841f36a2@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA4MDA3MSBTYWx0ZWRfX2JShtb8Dqbgi KnCFDs4XVzc0+Y+jd/QoYyZsCR09VE9+hvTUZx4qqNLj8wXT6Wfud5j+N/o4aoAcoYNDejzfI0s mI5LpxKts+FIVPy5gnwyWKMjLN1pcsQqVDFJz/XX2PoOSWSexjmrPM0jVE0ZfVyoOliRQ2FdiS5 bm5U5NtuMZgxS9HMU/DhQ/1g7xjnmg0dU8BBt0jYTTlBbnrNY/inmgfw8AFj+PCn+sUdZYxS1fA f/lbBTQVgPuYlRBGP8XFmom4Ov36KTDxYWH1xbGiv01uoB50PnIplaQ5ttO6q+bcN5zM/1dx4oE adg58YFv3Esq9KUrvx4wx8jzqDTQoHp59DGYedKsgbHPZU2pFtHGj5pp8qbwUR3CAubHajAM46D 3xzl0TfO55ua3rHHX4lfj6fJ6q9j+4bbFcQq3EwNznUO7SXKafmhEo5+ct3YJuqgqzDjXAmlIld Oxf9OxS2oyVkB3R9JNg== X-Proofpoint-GUID: 7ZNq22jcTC0Drev-kjH3vMY_BINMw7Ab X-Authority-Analysis: v=2.4 cv=TMp1jVla c=1 sm=1 tr=0 ts=6a4dfdd2 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=f0852AcSgLQ1KUP9AosA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA4MDA3MSBTYWx0ZWRfX8sLuDuLsPDgK WlIrL80uYkmqfsyMl8tpmkKAhm2EpnO2wwKFSS1JWpPrWWwn/YR8vsr5RpXg6RGmpFbLCzM4wUc dSs/KHiz1ggT7bCHC1i/8nShJ9HXpz4= X-Proofpoint-ORIG-GUID: 7ZNq22jcTC0Drev-kjH3vMY_BINMw7Ab X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-07_06,2026-07-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 suspectscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 phishscore=0 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607080071 On 7/8/2026 11:45 AM, Praveen Talari wrote: > The driver uses the shared gi2c->done completion for transfer, abort, shared => common completion event for transfer, abort and DMA reset > and DMA reset operations. This allows unrelated completion events to > prematurely wake abort and reset waiters, leading to incorrect > synchronization. Aren't they in sequence i.e. one after another ? > > Introduce dedicated completions for abort, TX reset, and RX reset > operations, and signal them only from their respective interrupt > events. This removes the dependency on shared completion state and > eliminates the abort_done flag-based synchronization. > > Co-developed-by: Naresh Maramaina > Signed-off-by: Naresh Maramaina > Signed-off-by: Praveen Talari > --- > drivers/i2c/busses/i2c-qcom-geni.c | 54 +++++++++++++++++++------------------- > 1 file changed, 27 insertions(+), 27 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c > index 15403edb355a..9490aee4928c 100644 > --- a/drivers/i2c/busses/i2c-qcom-geni.c > +++ b/drivers/i2c/busses/i2c-qcom-geni.c > @@ -113,7 +113,10 @@ struct geni_i2c_dev { > int err; > struct i2c_adapter adap; > struct completion done; > + struct completion abort_done; > struct completion cancel_done; > + struct completion tx_reset_done; > + struct completion rx_reset_done; tx or rx, any one would be running. Not both right ? if so, i suggest to keep common dma_reset_done. > struct i2c_msg *cur; > int cur_wr; > int cur_rd; > @@ -127,7 +130,6 @@ struct geni_i2c_dev { [..]