Re: [PATCH 1/2] mm/mmu_gather: remove unused __tlb_remove_page()

[Qi Zheng <zhengqi.arch@bytedance.com>]

On 2025/2/11 11:43, Baoquan He wrote:
> Nobody is using __tlb_remove_page() now, clean it up.
> 
> Signed-off-by: Baoquan He <bhe@redhat.com>
> ---
>   include/asm-generic/tlb.h | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/include/asm-generic/tlb.h b/include/asm-generic/tlb.h
> index e402aef79c93..9ae4ca02f29f 100644
> --- a/include/asm-generic/tlb.h
> +++ b/include/asm-generic/tlb.h
> @@ -489,12 +489,6 @@ static inline void tlb_remove_page_size(struct mmu_gather *tlb,
>   		tlb_flush_mmu(tlb);
>   }
>   
> -static __always_inline bool __tlb_remove_page(struct mmu_gather *tlb,
> -		struct page *page, bool delay_rmap)
> -{
> -	return __tlb_remove_page_size(tlb, page, delay_rmap, PAGE_SIZE);
> -}
> -
>   /* tlb_remove_page
>    *	Similar to __tlb_remove_page but will call tlb_flush_mmu() itself when

                    ^
                    please update this too

Otherwise:

Reviewed-by: Qi Zheng <zhengqi.arch@bytedance.com>

>    *	required.