From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D65C47CC69 for ; Thu, 30 Apr 2026 18:39:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777574366; cv=none; b=Y+MfSBJskpd7oM3B8RMvSxKF4aEj4RRh+qzmTMUKqeZDjAvWRrIR/DggVVI+muNqFFNnRTNBPHcM4z1M0PHOhkFFaRVUuKzAdhNSk8mtN/IKrm+25jWrs9Fn2vCxsBESBrD+EIfhxCHSZJKEfTf3aQchV8HfpxuA1S8cOcJMLM4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777574366; c=relaxed/simple; bh=EWfvzWwAMZdH+fxLemP5TH3UFb27rGk0/WQil+vdRok=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UzhTMrB6D+Sbb552Jkxy1JUXaerlRr7IFpKozlPdsJaa63znl6b7/6GwDrM6X60lforw1XHTp2V9HgCR1qkoqMroLfieJcZcndyvhcCayIlepReiglmpg2SpXuOuHrbVRPFIBoM0AXahhVc5/yRgT9x1F9UxTI7TDvBGyQAJLJI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=HFTLA2bX; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HFTLA2bX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777574364; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3TgwCb3E3Be4Ts3/mA76mTKUDmZh1Bg2ryTIzSZytL8=; b=HFTLA2bXq3uh7/70FSVdJdBdQ/owPrjQI5TRqV6eB7SJ3Dq71RZd7RZwLgP0n/LFcYtiwQ dm+98fms0XvgBATW2INRsYPcUCINAx0uS10zEghtTzN04VYcFttESisvlVRKcBa9RXT3S6 VVlhb9BxDBkRYrDhGBDLc5ZgwNN/De0= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-609-UVkcb29YMXKH8izzAEgqyA-1; Thu, 30 Apr 2026 14:39:23 -0400 X-MC-Unique: UVkcb29YMXKH8izzAEgqyA-1 X-Mimecast-MFC-AGG-ID: UVkcb29YMXKH8izzAEgqyA_1777574362 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-8a16036c90eso36259586d6.2 for ; Thu, 30 Apr 2026 11:39:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777574362; x=1778179162; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3TgwCb3E3Be4Ts3/mA76mTKUDmZh1Bg2ryTIzSZytL8=; b=AqOgdl2XLSHO9XB+mcNp2yMMcoa4rck4uwvR4alJ5P4Qm+TsQdKnV5N+GSEW/M5mry nr8zSliO1t2NZBVf44u0BclwM98ytfueerJM5CsepIrGYxxboWh7GjCS9pibNExo97io qgKO6ubCiy3jIO15bG36V/rpfGUrqeaZam5PJYzvA9nAfr8gMdqwOv4QjRFGPv4DhEWK BPvQX8WHDwPkEJGqhIq4jaghGJDFoKnEm1Y/NDx5Ry+Sr9GQnxNhCxjrSVsmULrPXgk9 nAbO2lV/LdRXmkP/ZE4W6usAkhmAQz6zZmEFEKPxb3XqvuV/i+qM/AwKQvDf6RPRfVRN /4Ng== X-Forwarded-Encrypted: i=1; AFNElJ/BpnmdAe+n8Pa3bE5H5cxjxWLvkQtBn/tQkj8wIq82lR/VbMA5FxZ4wzTpeXmVR6R4CkzmQyY1F6E+ADA=@vger.kernel.org X-Gm-Message-State: AOJu0YyNi4wzyN/jsrubJQE1jz5K+BrMv7zcgc9J+xIMK4W++MZdtaGX zR8iaDZHWSk6lA2VLFC2HxZTRKArt9Wyf5wAoqw0YZh0KaxUdvVcLlTMKtwb3Eo+F1rs9FiNO2H Ic9lDi+/57dDMrsstHHbvor8OCZF9Ns8tNwNy2sKFiIfrhrr/qTr9rVFh191gPo0aEA== X-Gm-Gg: AeBDieu2kfPR37VAdXOa2Eg2YU3mfKIQf1bHqdcq1E1YbkPKCB6FV0bzz/u4fiX0AUU KZ1AsTUSfRFqbfmM4wLBPvtxgfxfr4Rw89ZtGsNfvNYYNQNzi2k0yFMv6PX7vSn53cF7KplCamG /+sgGTVIhNqILA3adRmww+mKtnKrm37Vc/cZdMilPOkMMoliPl6t2rnLUZoyX8eleihQ30jPql1 E5hR8XcNaWhLloyAfoaZC+jBUPziptkoaRYXihpb1e6UeCo4i3CzjHp+uGhBQl9Jm0Hcq86KBnb WlZTrPoqZtk+DkmCJVnqASNXR/OEM7A1itzPFMENUW9FwfJ8fndxaMcP/sp9fPAT7QmNbsI1uwr Wx9bynDcTWWRraf58Tf7hCVQQzhR+Y0wa4ELAK0ZtXlbiACtJ+QZxgCqublk/FG6Bs+NT+uvU3m RDOBKJ7P9Z6RjqHTXqg1LHvgo= X-Received: by 2002:ad4:4ee9:0:b0:89e:df5c:19f6 with SMTP id 6a1803df08f44-8b3feefa60fmr58693466d6.42.1777574362277; Thu, 30 Apr 2026 11:39:22 -0700 (PDT) X-Received: by 2002:ad4:4ee9:0:b0:89e:df5c:19f6 with SMTP id 6a1803df08f44-8b3feefa60fmr58692596d6.42.1777574361605; Thu, 30 Apr 2026 11:39:21 -0700 (PDT) Received: from [192.168.2.110] (bras-base-aylmpq0104w-grc-22-70-53-202-134.dsl.bell.ca. [70.53.202.134]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8b3ff471941sm24955596d6.42.2026.04.30.11.39.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Apr 2026 11:39:21 -0700 (PDT) Message-ID: <616e4945-0622-422a-ad6a-6f8749a840af@redhat.com> Date: Thu, 30 Apr 2026 14:39:19 -0400 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 39/54] selftests/mm: hugetlb-mmap: add setup of HugeTLB pages To: Mike Rapoport , Andrew Morton , David Hildenbrand Cc: Baolin Wang , Barry Song , Dev Jain , Donet Tom , Jason Gunthorpe , John Hubbard , "Liam R. Howlett" , Lance Yang , Leon Romanovsky , Lorenzo Stoakes , Mark Brown , Michal Hocko , Nico Pache , Peter Xu , Ryan Roberts , Sarthak Sharma , Shuah Khan , Suren Baghdasaryan , Vlastimil Babka , Zi Yan , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org References: <20260428204240.1924129-1-rppt@kernel.org> <20260428204240.1924129-40-rppt@kernel.org> Content-Language: en-US, en-CA From: Luiz Capitulino In-Reply-To: <20260428204240.1924129-40-rppt@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2026-04-28 16:42, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > hugetlb-mmap test fails if there are no free huge pages prepared by a > wrapper script. > > Add setup of HugeTLB pages to the test and make sure that the original > settings are restored on the test exit. > > Signed-off-by: Mike Rapoport (Microsoft) Reviewed-by: Luiz Capitulino > --- > tools/testing/selftests/mm/hugetlb-mmap.c | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/tools/testing/selftests/mm/hugetlb-mmap.c b/tools/testing/selftests/mm/hugetlb-mmap.c > index 031085cb7d17..f12fc288ef4f 100644 > --- a/tools/testing/selftests/mm/hugetlb-mmap.c > +++ b/tools/testing/selftests/mm/hugetlb-mmap.c > @@ -109,16 +109,16 @@ int main(int argc, char **argv) > { > size_t hugepage_size; > size_t length = LENGTH; > - int shift = 0; > + int shift = 0, nr; > > ksft_print_header(); > - ksft_set_plan(2); > > if (argc > 1) > length = atol(argv[1]) << 20; > if (argc > 2) > shift = atoi(argv[2]); > > + hugetlb_save_settings(); > if (shift) { > hugepage_size = (1 << shift); > ksft_print_msg("%u kB hugepages\n", 1 << (shift - 10)); > @@ -128,9 +128,14 @@ int main(int argc, char **argv) > } > > /* munmap with fail if the length is not page aligned */ > - if (hugepage_size > length) > - length = hugepage_size; > + length = (length + hugepage_size - 1) & ~(hugepage_size - 1); > + nr = length / hugepage_size; > + > + hugetlb_set_nr_pages(hugepage_size, nr); > + if (hugetlb_free_pages(hugepage_size) < nr) > + ksft_exit_skip("Not enough %lu Kb pages\n", hugepage_size >> 10); > > + ksft_set_plan(2); > ksft_print_msg("Mapping %lu Mbytes\n", (unsigned long)length >> 20); > > test_anon_mmap(length, shift);