From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Abhishek Chauhan <quic_abchauha@quicinc.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Andrew Halaney <ahalaney@redhat.com>
Cc: <kernel@quicinc.com>
Subject: Re: [PATCH net-next v1] net: Add skb user timestamp flag to distinguish between timestamps
Date: Thu, 15 Feb 2024 15:14:46 -0800 [thread overview]
Message-ID: <6172a734-3bbd-4aa9-a20b-b7b95bb166aa@quicinc.com> (raw)
In-Reply-To: <20240215215632.2899370-1-quic_abchauha@quicinc.com>
On 2/15/2024 1:56 PM, Abhishek Chauhan wrote:
> Bridge driver today has no support to forward the userspace timestamp
> packets and ends up resetting the timestamp. ETF qdisc checks the
> packet coming from userspace and encounters to be 0 thereby dropping
> time sensitive packets. These changes will allow userspace timestamps
> packets to be forwarded from the bridge to NIC drivers.
>
> Signed-off-by: Abhishek Chauhan <quic_abchauha@quicinc.com>
> ---
> Note:- I am a little skeptical of using bool inside the skbuff
> structure as no one today has used bool so far in the struct.
> (Expecting some comments from upstream for sure)
there are a large number of u8 <flag>:1 bitfields -- suggest you do the same
next prev parent reply other threads:[~2024-02-15 23:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 21:56 Abhishek Chauhan
2024-02-15 23:14 ` Jeff Johnson [this message]
2024-02-16 18:11 ` Willem de Bruijn
2024-02-16 18:36 ` Abhishek Chauhan (ABC)
2024-02-19 16:26 ` Willem de Bruijn
2024-02-20 21:38 ` Abhishek Chauhan (ABC)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6172a734-3bbd-4aa9-a20b-b7b95bb166aa@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=ahalaney@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel@quicinc.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_abchauha@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®