From: Jason Wang <jasowang@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>, linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org, Wei Wang <wei.w.wang@intel.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio_balloon: disable VIOMMU support
Date: Thu, 15 Jun 2017 17:15:50 +0800 [thread overview]
Message-ID: <61792a09-4052-8596-fabf-f2a850dc5b18@redhat.com> (raw)
In-Reply-To: <1497376825-15502-1-git-send-email-mst@redhat.com>
On 2017年06月14日 02:00, Michael S. Tsirkin wrote:
> virtio balloon bypasses the DMA API entirely so does not support the
> VIOMMU right now. It's not clear we need that support, for now let's
> just make sure we don't pretend to support it.
>
> Cc: stable@vger.kernel.org
> Cc: Wei Wang <wei.w.wang@intel.com>
> Fixes: 1a937693993f ("virtio: new feature to detect IOMMU device quirk")
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/virtio/virtio_balloon.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
> index 408c174..22caf80 100644
> --- a/drivers/virtio/virtio_balloon.c
> +++ b/drivers/virtio/virtio_balloon.c
> @@ -663,6 +663,12 @@ static int virtballoon_restore(struct virtio_device *vdev)
> }
> #endif
>
> +static int virtballoon_validate(struct virtio_device *vdev)
> +{
> + __virtio_clear_bit(vdev, VIRTIO_F_IOMMU_PLATFORM);
> + return 0;
> +}
> +
> static unsigned int features[] = {
> VIRTIO_BALLOON_F_MUST_TELL_HOST,
> VIRTIO_BALLOON_F_STATS_VQ,
> @@ -675,6 +681,7 @@ static struct virtio_driver virtio_balloon_driver = {
> .driver.name = KBUILD_MODNAME,
> .driver.owner = THIS_MODULE,
> .id_table = id_table,
> + .validate = virtballoon_validate,
> .probe = virtballoon_probe,
> .remove = virtballoon_remove,
> .config_changed = virtballoon_changed,
Acked-by: Jason Wang <jasowang@redhat.com>
prev parent reply other threads:[~2017-06-15 9:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-13 18:00 Michael S. Tsirkin
2017-06-15 9:15 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61792a09-4052-8596-fabf-f2a850dc5b18@redhat.com \
--to=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=stable@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wei.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®