mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mieczyslaw Nalewaj <namiltd@yahoo.com>
To: "Luiz Angelo Daros de Luca" <luizluca@gmail.com>,
	"Andrew Lunn" <andrew@lunn.ch>,
	"Vladimir Oltean" <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Simon Horman" <horms@kernel.org>,
	"Linus Walleij" <linusw@kernel.org>,
	"Alvin Šipraga" <alsi@bang-olufsen.dk>,
	"Yury Norov" <yury.norov@gmail.com>,
	"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
	"Russell King" <linux@armlinux.org.uk>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net-next PATCH v13 2/9] net: dsa: realtek: rtl8365mb: reject unsupported topologies
Date: Sun, 7 Jun 2026 14:55:07 +0200	[thread overview]
Message-ID: <617aa489-4f0c-4fe0-8cf3-55c98f4d4d9e@yahoo.com> (raw)
In-Reply-To: <20260606-realtek_forward-v13-2-b9e409687cbe@gmail.com>

On 6/6/2026 10:29 AM, Luiz Angelo Daros de Luca wrote:
> Explicitly enforce the presence of a CPU port (-EINVAL) and reject DSA
> cascade links (-EOPNOTSUPP) during setup to prevent silent failures.
> 
> These topologies were already non-functional. Without a CPU port, the
> driver does not activate CPU tagging. Additionally, the switch hardware
> was not designed to be cascaded, and DSA links never worked because
> CPU tagging is not enabled for them.
> 
> Reviewed-by: Mieczyslaw Nalewaj <namiltd@yahoo.com>
> Reviewed-by: Linus Walleij <linusw@kernel.org>
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
> ---
[...]
>drivers/net/dsa/realtek/rtl8365mb.c:rtl8365mb_get_stats64() {
>    ...
>	mb = priv->chip_data;
>	p = &mb->ports[port];
>	spin_lock(&p->stats_lock);
>	memcpy(s, &p->stats, sizeof(*s));
>	spin_unlock(&p->stats_lock);
>}

Sashiko reports a potential deadlock around stats_lock, however I couldn't find a call chain reaching rtl8365mb_get_stats64() from softirq context. Can anyone point to such a path?


  reply	other threads:[~2026-06-07 13:50 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-06  8:29 [net-next PATCH v13 0/9] net: dsa: realtek: rtl8365mb: bridge offloading and VLAN support Luiz Angelo Daros de Luca
2026-06-06  8:29 ` [net-next PATCH v13 1/9] net: dsa: realtek: rtl8365mb: use ERR_PTR Luiz Angelo Daros de Luca
2026-06-06  8:29 ` [net-next PATCH v13 2/9] net: dsa: realtek: rtl8365mb: reject unsupported topologies Luiz Angelo Daros de Luca
2026-06-07 12:55   ` Mieczyslaw Nalewaj [this message]
2026-06-07 17:28     ` Andrew Lunn
2026-06-08  2:41     ` Luiz Angelo Daros de Luca
2026-06-10  2:35     ` Jakub Kicinski
2026-06-06  8:29 ` [net-next PATCH v13 3/9] net: dsa: realtek: rtl8365mb: use dsa helpers for port iteration Luiz Angelo Daros de Luca
2026-06-06  8:29 ` [net-next PATCH v13 4/9] net: dsa: realtek: rtl8365mb: prepare for multiple source files Luiz Angelo Daros de Luca
2026-06-06  8:29 ` [net-next PATCH v13 5/9] net: dsa: realtek: rtl8365mb: add table lookup interface Luiz Angelo Daros de Luca
2026-06-06  8:29 ` [net-next PATCH v13 6/9] net: dsa: realtek: rtl8365mb: add VLAN support Luiz Angelo Daros de Luca
2026-06-06  8:29 ` [net-next PATCH v13 7/9] net: dsa: realtek: rtl8365mb: add FDB support Luiz Angelo Daros de Luca
2026-06-06  8:29 ` [net-next PATCH v13 8/9] net: dsa: realtek: rtl8365mb: add port_bridge_{join,leave} Luiz Angelo Daros de Luca
2026-06-06  8:29 ` [net-next PATCH v13 9/9] net: dsa: realtek: rtl8365mb: add bridge port flags Luiz Angelo Daros de Luca
2026-06-08  3:43 ` [net-next PATCH v13 0/9] net: dsa: realtek: rtl8365mb: bridge offloading and VLAN support Luiz Angelo Daros de Luca
2026-06-08  7:41   ` Linus Walleij
2026-06-10  2:40 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=617aa489-4f0c-4fe0-8cf3-55c98f4d4d9e@yahoo.com \
    --to=namiltd@yahoo.com \
    --cc=alsi@bang-olufsen.dk \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=linux@rasmusvillemoes.dk \
    --cc=luizluca@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=yury.norov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®