From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Rahul Pon <theflyingrahul@gmail.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc: qcom: pmic_glink_altmode: acknowledge notifications on undescribed ports
Date: Tue, 13 Oct 2026 12:38:54 +0200 [thread overview]
Message-ID: <61840bbe-8167-44a4-a127-469697e4525e@oss.qualcomm.com> (raw)
In-Reply-To: <20260930111657.1147-1-theflyingrahul@gmail.com>
On 9/30/26 1:16 PM, Rahul Pon wrote:
> The driver enables port notifications from the firmware (ALTMODE_PAN_EN)
> for every port, but only acknowledges them (ALTMODE_PAN_ACK) from the
> worker of a port that has a connector node. A notification for any other
> port is logged at debug level and dropped without an acknowledgment.
>
> On an HP OmniBook 5 (Snapdragon X2, Mahua) whose device tree does not
> yet describe the USB-C connectors, the firmware kept charging on the
> connector that was plugged in, but once a notification had gone
> unacknowledged (on unplug), its UCSI connector status reported no
> connection on either port through repeated replugs, and no charging
> session started again. The firmware also reports more UCSI connectors
> than a board may describe to this driver (here a third, USB Standard-A,
> port).
Please fix your DT instead, all you need is to copy-paste some
boilerplate.
Konrad
prev parent reply other threads:[~2026-10-13 10:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 11:16 Rahul Pon
2026-10-13 10:38 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61840bbe-8167-44a4-a127-469697e4525e@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=theflyingrahul@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®