From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932331AbdJJPsu (ORCPT ); Tue, 10 Oct 2017 11:48:50 -0400 Received: from mail-eopbgr00098.outbound.protection.outlook.com ([40.107.0.98]:36420 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932089AbdJJPst (ORCPT ); Tue, 10 Oct 2017 11:48:49 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=aryabinin@virtuozzo.com; Subject: Re: [PATCH v3 2/3] Makefile: support flag -fsanitizer-coverage=trace-cmp To: Alexander Potapenko , akpm@linux-foundation.org, mark.rutland@arm.com, alex.popov@linux.com, quentin.casasnovas@oracle.com, dvyukov@google.com, andreyknvl@google.com, keescook@chromium.org, vegard.nossum@oracle.com Cc: syzkaller@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20171010152731.26031-1-glider@google.com> <20171010152731.26031-2-glider@google.com> From: Andrey Ryabinin Message-ID: <6184cd73-6d78-b490-3fdd-2d577ef033a6@virtuozzo.com> Date: Tue, 10 Oct 2017 18:51:46 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171010152731.26031-2-glider@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.6] X-ClientProxiedBy: VI1PR08CA0209.eurprd08.prod.outlook.com (2603:10a6:802:15::18) To AM4PR08MB2819.eurprd08.prod.outlook.com (2603:10a6:205:d::25) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 87c195f5-78b3-4195-2c31-08d50ff66422 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:AM4PR08MB2819; X-Microsoft-Exchange-Diagnostics: 1;AM4PR08MB2819;3:PTIwdri7nkArj0EQu069DPxiS+JEfoMlTRkLW5vpDGBMezpBKJ2zSWfawjtUrQjQ8HmpTfJwnG/HoE6Ip/iakFUrh+dnBFcLoPnXOebMxpMbf2+1+6igjgf7nHDYALTKOMtRqUtY7uc9L3pmwTRIR0n+V9MIib6fDZG8LFEdsCaBZOU0HO30FTpqNEb4v5rDAxmMo6C5F2nOY9ptjA4Lj3QWoDup3z0iOV22Y/7Z9dkLEFxKlw1th3arm9/Gs/OE;25:9aa2D4iArSEzGdGm527SBuYKBlEOAx4465JZWQW9bDm3/W3WT1nwLJf5TAY+uFbO73cXwTDLK5TCrTlZEL1g5HX6JXtHuH/+MM5/DIRxGBAx+qu+C/Wm8EDKCjPXy0GOni8zFeaf9b3TYUDofw47EzGX/GiYwK2F2UAO13P9i2tECbM8xNviJd0rwbVsZmtOu0R2crHkAdJ1JSfORVNdkUdOIbN2ZxpJcgaG6AfwQhKbJJC6FQbT1Iq6Cwx/HYcaL3ZDUeieCpEsMXG2x0aLpkJifQglpvrKXIGORzphue2SGXu4gmIBYOVE65iFLCjzNKygSH/2QOpEu4+IMuUJvg==;31:fhscOU/rxuB1pxSGzukfTTYFI3Yrx5NlJfbtKlN5GU4y8A+5swAgTUKuMxIXU+M5G7nP1rtYwJ3VNRSco1L+3O3QIVjufNRKNzTEwS79tPlVSq3HnAUjsAG9EPngr8kk1n4ej5PkkFj+VHSVc+6ziahCtQbkSx3FYZ6Bh9doEnkmMOHD6ycibhQq+TBr4Mj47yoJBTdVXVsd+k4jkUjKPNQnaEpsB1j83YJX+d23yeI= X-MS-TrafficTypeDiagnostic: AM4PR08MB2819: X-Microsoft-Exchange-Diagnostics: 1;AM4PR08MB2819;20:SAKlCmBMSGv/1GWTnkyCqHUaNcsjKh6qoHzccgl5+4t3f1I3I9dgOSE+ND5ETqD5Z4Q7u2SWLwEig22OgTNg7dHNyC2GugEpaqaaERMyNMkP6+6SsBAsufovAlsqRs/pzdCCN8anHKZdaZS8/xt6YEYbbkkjzY2wRx0zJFD6rEi5rIUwvC8QeiAORZ1fV3x1GbqVKARfBWiih2NlVQEudPPLg6Cmk1TJjFE2rYOI7jVGkUFjPzOXCrBK0/ypOdSjU2eOkVeTrak5icd8b43Rl+JzA4oDTPso2ONsQqBCP3tu94NkA+/xRXv/y6nAOUbXgYVcmaMHxYYtFfanWqroJhmgOzBGP46JD0lxfw5QaAdkZksaLaKTac2WUrYq+uYtafvfmFSbf86Knjx9/flU9OqwmygFbF1FLOykvKlUUJ0=;4:9oJIS90MUU/RLJ/tx35wE68np8vx1dBbn3tz2rGSbE8jRYZUtqc34NdiBdsMZpL4Had1zLS98wXE+5Qz261tFGKbYCoW8JjAVqYKh3quBP2uQq7WuQkJGrPFgsxCnpiwLf+bh7YnBO6JRVfPj9H+kn6qLev3U0C8BVXz8GwEQQecErJ9u0xk/uBCbmAIJ6mTLaoa3CDi9EP+WCyl89DgUd87iwRX/h6oFHymv0uqgpsydr0heF/oeKOVGz34Ltuz X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(100000703101)(100105400095)(3002001)(93006095)(93001095)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123560025)(20161123562025)(20161123555025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:AM4PR08MB2819;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:AM4PR08MB2819; X-Forefront-PRVS: 04569283F9 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6049001)(6009001)(346002)(376002)(377454003)(189002)(199003)(24454002)(229853002)(230700001)(53936002)(6116002)(65826007)(5660300001)(25786009)(77096006)(6486002)(53546010)(106356001)(2906002)(189998001)(64126003)(97736004)(16526018)(23676002)(316002)(50466002)(6246003)(83506001)(58126008)(2950100002)(33646002)(3846002)(65806001)(101416001)(105586002)(4326008)(36756003)(305945005)(16576012)(76176999)(68736007)(50986999)(47776003)(54356999)(81156014)(8676002)(65956001)(66066001)(81166006)(8936002)(478600001)(86362001)(31686004)(7736002)(575784001)(31696002)(7416002);DIR:OUT;SFP:1102;SCL:1;SRVR:AM4PR08MB2819;H:[172.16.25.12];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTTRQUjA4TUIyODE5OzIzOnowbCtEbDNPQjF6WVhmd2VkWkJQYlgyZFpM?= =?utf-8?B?RWlMbzh5a3BGYW0veW55eVpmRS94WGt3ODlaNEhNWEl5YlRoak01ZHFKKzNK?= =?utf-8?B?YWZEbDIxdGlCMXk4T0QyZVlkY2dFUDQzWUtJMWZXNmpHNmVXWDFWeTRQRVVn?= =?utf-8?B?ZmlrVWhpMXdRZ2JtVjZtTlVKWnkrVjJCenpsaHUzUXlEU1NobzhES0VCRXFp?= =?utf-8?B?R0dOL3hCTEovMTNCeVJ6RmJnbUU2OEhmRVIxVWFmSG9nTTYybFU1dDI0SWht?= =?utf-8?B?RXhxUWlaUVBxV3Z0dnRaY2FqdEpZZDdiVGpRTHZidjJCUk5GbzJhU0tMYjJE?= =?utf-8?B?YVdqMHhpdTlBZGdNVk9PLzJQaEM3dVRuSDFocFhhYTVSMmlHM3liL25JRmMv?= =?utf-8?B?dTNWUnZnYlJMMTlWOHFJREI3cjR4RUJsMTRtTlZYYmtqSlZvL1hPZllqWVkz?= =?utf-8?B?UXBxdStDTC9qUEVuZkQvR3VJTWdNd01xT3lkeWVGVzFQZkpWY0l3NEdsSEtl?= =?utf-8?B?WXhXbWZ5b1JXamRoaFQ2OWtJY1Y4bzdCeGdiL1FrQ2RCYU83M2lXMUMydU9T?= =?utf-8?B?dHFyd1kxMnRGbFRJSFhzelpRYXNIS2NzRE12TVVWUzgrNExleXZnMVFjVHFK?= =?utf-8?B?SVlCYlZmRGxNWUpwb1R6VU5Wbzc3OWkwdFpZaFlpU2QwYkZmM3EyZTVXclVF?= =?utf-8?B?MVltZDhUWmVNelQzUEtLVmpvaXR0elFsVE1FaUlGNnc4UUd4ZG1vam02aVp3?= =?utf-8?B?SHNnWEMwRVE3TTNrcGJuc3NwYnZXZ1RBTzBVL0NnT1FJVmJKWm1VK01MTUg4?= =?utf-8?B?RzRCVUtNVnFhbUIzVFVNRWM1bWNPZEoyWk91VC9PdEdtY0tlRE1yZVFYZGg2?= =?utf-8?B?YzQyZFFEc3lQTHFERm1JWGhaRWdydndYcU8yaDlsc08xbFF2aGpOY0g3Zkc4?= =?utf-8?B?bUJHRHQrdE95b0lWdDhVdW5uTEszaGhhSHEzNEpYVjhVQWxXa1hCK0pQdU5N?= =?utf-8?B?NE9ZdjEwYkhIcW4xRVRBV1o4Y2Q3dEVrK3ZpZEJybG1wT21mRDJNdXFpUVhB?= =?utf-8?B?RTZDWEx4R2lQVUV4SE9XTVNLRnhGVkpIU1l2VlFVTEhHUitabVJ5T3pKYmV6?= =?utf-8?B?RWRWbFVaWGs3OCtTVk1yeWNDQ0d0UmdMbTl2MklVdS9STzZ2N012UWQ2Y1lE?= =?utf-8?B?Z3JPYVhwWXA5SGJnNnJpNWFyMTUrK0cveWVLQUlWTlg2UkVuNG9OTWUvT0lH?= =?utf-8?B?bGJia2txZGx6UlNnWktLZmtRWFdIYUFNRFhucFd0YjUwZUtQNVBDWllvWDQ1?= =?utf-8?B?enVqbWF5bUFHVS92TFdNT2hUL3RaaTU0NkdYMUpTb3FsZGNtR0hqTmtmaGVn?= =?utf-8?B?RGdUaEIxcDRxZUE0cUphakQrU1BrWFJyaVA4SmJoTTd6eGg4WEZ5K3VtcDlT?= =?utf-8?B?RUdPS3RkdnVwdDI3QjdLRXNIL1BNbHNWKzlqZTJtQkVmY3pPa2pKUlJlRHJG?= =?utf-8?B?WDdCY0Voa3paQ3VnT2phVG5iTUZYeWdCOWJ1eDNpcG8yN2FlV2JuRFNvcWFM?= =?utf-8?B?QkM1S0dTTi8xQmROYlR0NnljdHh3RjJIUm5tTzlWSjBnTk14ZDBka2VybXB6?= =?utf-8?B?NWxLckR1Z2tlTUFQcHhPYlduUU5PQ1A0UlpFYzZ2Lyt0bGhWS3pmM1pZckx2?= =?utf-8?B?U2tveVlyUnJJcXVIRklxS0FlWUw2NUNwaGlTelVtZjc3Q3NtUjBDSGw3OXcz?= =?utf-8?B?UkZyRVZMbkJVM1BRb0U5b3NUeGcyOGdObmJRSmlHeGVKNUtwYldiL3E4bkJ6?= =?utf-8?Q?UNk96prCjagCF?= X-Microsoft-Exchange-Diagnostics: 1;AM4PR08MB2819;6:PqQuHmCwpV7i9kbdLuWCWgUwZSUmANqw5YhVT2QQ+EgA5AaQlfzOCE0lR7jp8KNCMmNMqjzlCdJKyWOPY8FNvG2mI/uioSjMAi/jdGCFC5IoxoDSrahb3nQ7hkBhFeeSith/DU1FAkmhZZHwpmZaOqA0qUywFJ3r35ri+RXmOIOZx9qQfsdRbDjdhbSFseJ15depkDk1NwHSlq4bQhvZ94TdegcmAV5QvnVPDRJE8XJm8dTTpnJFWZj4Abu1bYR2QePWl8SdImiVwPpiNnFyA/Zs/E48ca+eppTbnmieSJQJYZTjbUIMfZ39TnXC3/9c6HiOkoDUUHkXMq323oKuiw==;5:A0aWBwUh0Y6HOqBafwKKMb1eZISlvvaWhDKyIRg1i6icLNdme4lHCNe9sthbKT25pwAI+Wy1v142sSNS59tm5Q/+y42cBy8ElL/yhXdnRPAU4KGv5E3D3qvx1ajE3nau3PPbxzzj3gyjBYry54c2Ug==;24:mI7+1QPbAoNun8KMs3ppXeUMm+y5j1BDysBKpiCCPnsrZg9dEHKPaDavgQpdap+sjJMXe0386EMeRQq2yvM+nD5F3UhtSleqajiZ4ZJEzsk=;7:fc7Q1CD5Bb/MmjUlvfhTor2ra3SXmZdt5r0FBI6+YcKOikrMi//3U3IDB+xmz7KrZo8E4A/roXgesuaur5d1lOPHpx6tAep5m/PWVb5RRgI8GtNqWd1oXQ1Nzvxf+cDbY59KMyZQgRKERkWCn3RlbiY4dFU6stYSWun3aP+VhnELXV3X0aQSMR/u0IkMNr/zB3scdN8nBlQ/Vr4NiK2xHibGh7IWW94S48qLyNPaOJQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;AM4PR08MB2819;20:8hoDQtzWUn5LqJtvBdIO1bASwZH6otS23DamxtKPZiHlK3dtVEoEeSYbjQSLPvlvaJZ/4t0LsHoQ/Wt6gqCQCzpBnKqSMz+xCx/kyxIWFjmM1bPEOv5ys+MnRv8czUbaly6WDZOLPVeiPg9K1xIfqSiN2UqcFF/dydUykEyeA2U= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2017 15:48:44.1000 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB2819 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/10/2017 06:27 PM, Alexander Potapenko wrote: > > v3: - Andrey Ryabinin's comments: reinstated scripts/Makefile.kcov > and moved CFLAGS_KCOV there, dropped CFLAGS_KCOV_COMPS Huh? Try again. > diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib > index 5e975fee0f5b..7ddd5932c832 100644 > --- a/scripts/Makefile.lib > +++ b/scripts/Makefile.lib > @@ -142,6 +142,12 @@ _c_flags += $(if $(patsubst n%,, \ > $(CFLAGS_KCOV)) > endif > > +ifeq ($(CONFIG_KCOV_ENABLE_COMPARISONS),y) > +_c_flags += $(if $(patsubst n%,, \ > + $(KCOV_INSTRUMENT_$(basetarget).o)$(KCOV_INSTRUMENT)$(CONFIG_KCOV_INSTRUMENT_ALL)), \ > + $(CFLAGS_KCOV_COMPS)) > +endif > + > # If building the kernel in a separate objtree expand all occurrences > # of -Idir to -I$(srctree)/dir except for absolute paths (starting with '/'). > >