From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, TRACKER_ID autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA354C10DCE for ; Thu, 12 Mar 2020 12:22:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7D41A206FA for ; Thu, 12 Mar 2020 12:22:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=pascalroeleven.nl header.i=@pascalroeleven.nl header.b="bkeEHHZB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726952AbgCLMW1 (ORCPT ); Thu, 12 Mar 2020 08:22:27 -0400 Received: from web0081.zxcs.nl ([185.104.29.10]:34190 "EHLO web0081.zxcs.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726254AbgCLMW0 (ORCPT ); Thu, 12 Mar 2020 08:22:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=pascalroeleven.nl; s=x; h=Message-ID:Subject:Cc:To:From:Date: Content-Transfer-Encoding:Content-Type:MIME-Version:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Lfs0z/+L0TSule7hHn2nDAOGMSOIAkxM0mBa2N+gqjI=; b=bkeEHHZBvkZiglRESydGIwO20 weVZ3patJWJi0cvR5/syyzc+uHlgg6uan/zJcW6zVRFFRPJ6Q8bDLdr7ESeNW3hTfkxtN00/EIS+g l87uXsSridQ3jVJnEnD5YmkJjxlT4teuILe6lthyYHv6rnzPaeRA5nNPAXJspn7IQTlMXWYNMGj3Y PCtR+EF5IFvC7wu8JqK77gTwj2q5bRId7EtMRyitcz4KmX60KHs7IkC30dLI3YLdQy8n/6AGFWRdF eRLdCZk41tk0ZT/z4EdptxiDvMdlmDzUrlJ4zSP5B6DYkl3GvewdR/8fkpyNfeYa4qUHBRqyz1dQW 4vUIiqu6A==; Received: from spamrelay.zxcs.nl ([185.104.28.12]:33708 helo=mail-slave01.zxcs.nl) by web0081.zxcs.nl with esmtp (Exim 4.92.3) (envelope-from ) id 1jCMqr-002bnY-GC; Thu, 12 Mar 2020 13:22:13 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 12 Mar 2020 13:22:13 +0100 From: Pascal Roeleven To: Thierry Reding , =?UTF-8?Q?Uwe_Kleine-K?= =?UTF-8?Q?=C3=B6nig?= , Maxime Ripard , Chen-Yu Tsai , Philipp Zabel , linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: linux-sunxi@googlegroups.com Subject: pwm: sun4i: pwm-backlight not working since 5.6-rc1 User-Agent: Roundcube Webmail/1.4.2 Message-ID: <6185b5540ca082d887d7d13330c9d938@pascalroeleven.nl> X-Sender: dev@pascalroeleven.nl Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, I am working on adding an old A10 device to mainline and noticed an issue when testing on 5.5.8 vs master. Since 5.6-rc1, I can't control the brightness of my LCD backlight anymore. The backlight stays on full brightness instead. I am controlling the brightness value via sysfs for testing. I am not sure if this is a general pwm-sun4i issue or if it is related to the backlight. However I narrowed it down to one commit for pwm-sun4i: fa4d81784681a26bcf7d2a43c6ac5cf991ef28f5 If I use pwm-sun4i.c from 5b090b430d750961305030232314b6acdb0102aa on master, the backlight works fine. Unfortunately, due to my lack of kernel experience, I can't see how the commit above broke it. Not sure if it helps, but the binding for the backlight is as follows: backlight: backlight { compatible = "pwm-backlight"; pwms = <&pwm 0 100000 PWM_POLARITY_INVERTED>; power-supply = <®_vbat>; enable-gpios = <&pio 7 7 GPIO_ACTIVE_HIGH>; /* PH7 */ brightness-levels = <0 30 40 50 60 70 80 90 100>; default-brightness-level = <8>; }; Please let me know if there is anything else which might be helpful to know or anything I can test. Regards, Pascal