From: Kees Cook <kees@kernel.org>
To: Stas Sergeev <stsp2@yandex.ru>, linux-kernel@vger.kernel.org
Cc: Eric Biederman <ebiederm@xmission.com>,
Andy Lutomirski <luto@kernel.org>,
Aleksa Sarai <cyphar@cyphar.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Thomas Gleixner <tglx@linutronix.de>,
Jeff Layton <jlayton@kernel.org>,
John Johansen <john.johansen@canonical.com>,
Chengming Zhou <chengming.zhou@linux.dev>,
Casey Schaufler <casey@schaufler-ca.com>,
Adrian Ratiu <adrian.ratiu@collabora.com>,
Felix Moessbauer <felix.moessbauer@siemens.com>,
Jens Axboe <axboe@kernel.dk>, Oleg Nesterov <oleg@redhat.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
linux-fsdevel@vger.kernel.org,
"Peter Zijlstra (Intel)" <peterz@infradead.org>
Subject: Re: [PATCH v2 1/2] procfs: avoid some usages of seq_file private data
Date: Fri, 08 Nov 2024 07:32:04 -0800 [thread overview]
Message-ID: <618F0D80-F2E1-49C1-AA25-B2C0CC46F519@kernel.org> (raw)
In-Reply-To: <20241108101339.1560116-2-stsp2@yandex.ru>
On November 8, 2024 2:13:38 AM PST, Stas Sergeev <stsp2@yandex.ru> wrote:
>seq_file private data carries the inode pointer here.
>Replace
>`struct inode *inode = m->private;`
>with:
>`struct inode *inode = file_inode(m->file);`
>to avoid the reliance on private data.
Conceptually this seems good, though I'd expect to see the removal of _setting_ m->private too in this patch.
>This is needed so that `proc_single_show()` can be used by
>custom fops that utilize seq_file private data for other things.
>This is used in the next patch.
Now that next patch is pretty wild. I think using proc is totally wrong for managing uid/gid. If that's going to happen at all, I think it should be tied to pidfd which will already do the correct process lifetime management, etc.
-Kees
--
Kees Cook
next prev parent reply other threads:[~2024-11-08 15:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 10:13 [PATCH v2 0/2] implement PROCFS_SET_GROUPS ioctl Stas Sergeev
2024-11-08 10:13 ` [PATCH v2 1/2] procfs: avoid some usages of seq_file private data Stas Sergeev
2024-11-08 15:32 ` Kees Cook [this message]
2024-11-08 16:03 ` stsp
2024-11-08 21:06 ` stsp
2024-11-08 10:13 ` [PATCH v2 2/2] procfs: implement PROCFS_SET_GROUPS ioctl Stas Sergeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=618F0D80-F2E1-49C1-AA25-B2C0CC46F519@kernel.org \
--to=kees@kernel.org \
--cc=adrian.ratiu@collabora.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=casey@schaufler-ca.com \
--cc=chengming.zhou@linux.dev \
--cc=cyphar@cyphar.com \
--cc=ebiederm@xmission.com \
--cc=felix.moessbauer@siemens.com \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=john.johansen@canonical.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=serge@hallyn.com \
--cc=stsp2@yandex.ru \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®