From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE07DC4743E for ; Sat, 5 Jun 2021 07:07:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9FEBB613E3 for ; Sat, 5 Jun 2021 07:07:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229964AbhFEHJN (ORCPT ); Sat, 5 Jun 2021 03:09:13 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:3067 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229850AbhFEHJL (ORCPT ); Sat, 5 Jun 2021 03:09:11 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4FxrDW4hBJzWnxB; Sat, 5 Jun 2021 15:02:35 +0800 (CST) Received: from dggpeml500017.china.huawei.com (7.185.36.243) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Sat, 5 Jun 2021 15:07:22 +0800 Received: from [10.174.178.174] (10.174.178.174) by dggpeml500017.china.huawei.com (7.185.36.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Sat, 5 Jun 2021 15:07:21 +0800 Subject: Re: [PATCH -next] leds: wm831x-status: use devm_led_classdev_register() From: Yang Yingliang To: , CC: References: <20210605032212.698200-1-yangyingliang@huawei.com> Message-ID: <618a6c19-196f-79e7-cfc0-48551942bf53@huawei.com> Date: Sat, 5 Jun 2021 15:07:21 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20210605032212.698200-1-yangyingliang@huawei.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.174.178.174] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpeml500017.china.huawei.com (7.185.36.243) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch is wrong, ignore it. On 2021/6/5 11:22, Yang Yingliang wrote: > Use devm_led_classdev_register() for led device registration and > get rid of .remove callback to remove led device. This is done by > managed device framework. > > Signed-off-by: Yang Yingliang > --- > drivers/leds/leds-wm831x-status.c | 12 +----------- > 1 file changed, 1 insertion(+), 11 deletions(-) > > diff --git a/drivers/leds/leds-wm831x-status.c b/drivers/leds/leds-wm831x-status.c > index c48b80574f02..8ccd8b472572 100644 > --- a/drivers/leds/leds-wm831x-status.c > +++ b/drivers/leds/leds-wm831x-status.c > @@ -269,7 +269,7 @@ static int wm831x_status_probe(struct platform_device *pdev) > drvdata->cdev.blink_set = wm831x_status_blink_set; > drvdata->cdev.groups = wm831x_status_groups; > > - ret = led_classdev_register(wm831x->dev, &drvdata->cdev); > + ret = devm_led_classdev_register(wm831x->dev, &drvdata->cdev); > if (ret < 0) { > dev_err(&pdev->dev, "Failed to register LED: %d\n", ret); > return ret; > @@ -280,21 +280,11 @@ static int wm831x_status_probe(struct platform_device *pdev) > return 0; > } > > -static int wm831x_status_remove(struct platform_device *pdev) > -{ > - struct wm831x_status *drvdata = platform_get_drvdata(pdev); > - > - led_classdev_unregister(&drvdata->cdev); > - > - return 0; > -} > - > static struct platform_driver wm831x_status_driver = { > .driver = { > .name = "wm831x-status", > }, > .probe = wm831x_status_probe, > - .remove = wm831x_status_remove, > }; > > module_platform_driver(wm831x_status_driver);