mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitry Kasatkin <d.kasatkin@samsung.com>
To: cw00.choi@samsung.com
Cc: linux-kernel@vger.kernel.org, Jonghwa Lee <jonghwa3.lee@samsung.com>
Subject: [PATCH 1/3] extcon: max77693: Fix bug related to MAX77693 irq when set ADC debounce time
Date: Fri, 04 Jul 2014 15:51:24 +0300	[thread overview]
Message-ID: <618ae4634565cbafffbf5d7fde5ee80686e7aac6.1404478227.git.d.kasatkin@samsung.com> (raw)
In-Reply-To: <cover.1404478227.git.d.kasatkin@samsung.com>
In-Reply-To: <cover.1404478227.git.d.kasatkin@samsung.com>

From: Jonghwa Lee <jonghwa3.lee@samsung.com>

Signed-off-by: Jonghwa Lee <jonghwa3.lee@samsung.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
 drivers/extcon/extcon-max77693.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/drivers/extcon/extcon-max77693.c b/drivers/extcon/extcon-max77693.c
index 2c7c3e1..0e9f734 100644
--- a/drivers/extcon/extcon-max77693.c
+++ b/drivers/extcon/extcon-max77693.c
@@ -288,6 +288,14 @@ static int max77693_muic_set_path(struct max77693_muic_info *info,
 	int ret = 0;
 	u8 ctrl1, ctrl2 = 0;
 
+	/* Set open state to path before changing hw path */
+	ret = max77693_update_reg(info->max77693->regmap_muic,
+		MAX77693_MUIC_REG_CTRL1, CONTROL1_SW_OPEN, COMP_SW_MASK);
+	if (ret < 0) {
+		dev_err(info->dev, "failed to update MUIC register\n");
+		return ret;
+	}
+
 	if (attached)
 		ctrl1 = val;
 	else
@@ -1259,7 +1267,7 @@ static int max77693_muic_probe(struct platform_device *pdev)
 	}
 
 	/* Set initial path for UART */
-	 max77693_muic_set_path(info, info->path_uart, true);
+	max77693_muic_set_path(info, info->path_uart, true);
 
 	/* Check revision number of MUIC device*/
 	ret = max77693_read_reg(info->max77693->regmap_muic,
-- 
1.9.1


  reply	other threads:[~2014-07-04 12:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-04 12:51 [PATCH 0/3] extcon: max77693: fixes Dmitry Kasatkin
2014-07-04 12:51 ` Dmitry Kasatkin [this message]
2014-07-04 12:51 ` [PATCH 2/3] extcon: max77693: Differentiate info message for easier debugging Dmitry Kasatkin
2014-07-04 12:51 ` [PATCH 3/3] extcon: max77693: Force using UART path for jig Dmitry Kasatkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=618ae4634565cbafffbf5d7fde5ee80686e7aac6.1404478227.git.d.kasatkin@samsung.com \
    --to=d.kasatkin@samsung.com \
    --cc=cw00.choi@samsung.com \
    --cc=jonghwa3.lee@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®