From: Chun-Jie Chen <chun-jie.chen@mediatek.com>
To: Matthias Brugger <matthias.bgg@gmail.com>, Rob Herring <robh@kernel.org>
Cc: Enric Balletbo Serra <eballetbo@gmail.com>,
Nicolas Boichat <drinkcat@chromium.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<srv_heupstream@mediatek.com>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [v1 1/2] dt-bindings: power: Add MT8186 power domains
Date: Mon, 7 Feb 2022 16:53:42 +0800 [thread overview]
Message-ID: <618ca2903de8fe3b1f68c450273af7a170de2675.camel@mediatek.com> (raw)
In-Reply-To: <ae307028-979b-7e58-dd6f-f1d52520859b@gmail.com>
On Fri, 2022-01-14 at 13:49 +0100, Matthias Brugger wrote:
>
> On 12/01/2022 03:05, Rob Herring wrote:
> > On Sat, Jan 08, 2022 at 09:19:52PM +0800, Chun-Jie Chen wrote:
> > > Add power domains dt-bindings for MT8186.
> > >
> > > Signed-off-by: Chun-Jie Chen <chun-jie.chen@mediatek.com>
> > > ---
> > > .../power/mediatek,power-controller.yaml | 1 +
> > > include/dt-bindings/power/mt8186-power.h | 32
> > > +++++++++++++++++++
> > > 2 files changed, 33 insertions(+)
> > > create mode 100644 include/dt-bindings/power/mt8186-power.h
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/power/mediatek,power-
> > > controller.yaml
> > > b/Documentation/devicetree/bindings/power/mediatek,power-
> > > controller.yaml
> > > index d6ebd77d28a7..135c6f722091 100644
> > > --- a/Documentation/devicetree/bindings/power/mediatek,power-
> > > controller.yaml
> > > +++ b/Documentation/devicetree/bindings/power/mediatek,power-
> > > controller.yaml
> > > @@ -26,6 +26,7 @@ properties:
> > > - mediatek,mt8167-power-controller
> > > - mediatek,mt8173-power-controller
> > > - mediatek,mt8183-power-controller
> > > + - mediatek,mt8186-power-controller
> > > - mediatek,mt8192-power-controller
> > > - mediatek,mt8195-power-controller
> > >
> > > diff --git a/include/dt-bindings/power/mt8186-power.h
> > > b/include/dt-bindings/power/mt8186-power.h
> > > new file mode 100644
> > > index 000000000000..ca8ea2d24801
> > > --- /dev/null
> > > +++ b/include/dt-bindings/power/mt8186-power.h
> > > @@ -0,0 +1,32 @@
> > > +/* SPDX-License-Identifier: GPL-2.0-only */
> >
> > Dual license please.
> >
>
> Other then that series looks good.
>
> Regards,
> Matthias
>
Ok, I will update license in next patch.
Thanks!
Best Regards,
Chun-Jie
> > > +/*
> > > + * Copyright (c) 2022 MediaTek Inc.
> > > + * Author: Chun-Jie Chen <chun-jie.chen@mediatek.com>
> > > + */
> > > +
> > > +#ifndef _DT_BINDINGS_POWER_MT8186_POWER_H
> > > +#define _DT_BINDINGS_POWER_MT8186_POWER_H
> > > +
> > > +#define MT8186_POWER_DOMAIN_MFG0 0
> > > +#define MT8186_POWER_DOMAIN_MFG1 1
> > > +#define MT8186_POWER_DOMAIN_MFG2 2
> > > +#define MT8186_POWER_DOMAIN_MFG3 3
> > > +#define MT8186_POWER_DOMAIN_SSUSB 4
> > > +#define MT8186_POWER_DOMAIN_SSUSB_P1 5
> > > +#define MT8186_POWER_DOMAIN_DIS 6
> > > +#define MT8186_POWER_DOMAIN_IMG 7
> > > +#define MT8186_POWER_DOMAIN_IMG2 8
> > > +#define MT8186_POWER_DOMAIN_IPE 9
> > > +#define MT8186_POWER_DOMAIN_CAM 10
> > > +#define MT8186_POWER_DOMAIN_CAM_RAWA 11
> > > +#define MT8186_POWER_DOMAIN_CAM_RAWB 12
> > > +#define MT8186_POWER_DOMAIN_VENC 13
> > > +#define MT8186_POWER_DOMAIN_VDEC 14
> > > +#define MT8186_POWER_DOMAIN_WPE 15
> > > +#define MT8186_POWER_DOMAIN_CONN_ON 16
> > > +#define MT8186_POWER_DOMAIN_CSIRX_TOP 17
> > > +#define MT8186_POWER_DOMAIN_ADSP_AO 18
> > > +#define MT8186_POWER_DOMAIN_ADSP_INFRA 19
> > > +#define MT8186_POWER_DOMAIN_ADSP_TOP 20
> > > +
> > > +#endif /* _DT_BINDINGS_POWER_MT8186_POWER_H */
> > > --
> > > 2.18.0
> > >
> > >
next prev parent reply other threads:[~2022-02-07 9:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220108131953.16744-1-chun-jie.chen@mediatek.com>
2022-01-08 13:19 ` Chun-Jie Chen
2022-01-12 2:05 ` Rob Herring
2022-01-14 12:49 ` Matthias Brugger
2022-02-07 8:53 ` Chun-Jie Chen [this message]
2022-01-08 13:19 ` [v1 2/2] soc: mediatek: pm-domains: Add support for mt8186 Chun-Jie Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=618ca2903de8fe3b1f68c450273af7a170de2675.camel@mediatek.com \
--to=chun-jie.chen@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@chromium.org \
--cc=eballetbo@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®