From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39CC12FE060 for ; Fri, 15 May 2026 13:28:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778851729; cv=none; b=Q0gfcI/x87gIksKtmh6F+fk2oxKcclSykD8h7VlzT5S2a4y1PGGxw1CLB4lBiOHo3RcU/iIefTIUIKujDMfl5OPAHhB/DvFOVWsWRCxtsH9mrRlSmuFhyXFZtvJYrJCP35lLYXflmx6mF0DqmHRsMMyMdmORtqF6twDoPvmxFXE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778851729; c=relaxed/simple; bh=sfzk+vnuN9B16NJkhYUSczDv0dLA6XgoGpimuZHBo0E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FK75TxO+TNeTQ0OSiYTn0eyYE+xZ88TztbRTGi07cJnH+FogK552gMed26A9X6rlIc+Nsal2jee4maAUT5+RKOjCyE6FctwHje2NjOShTEXmk+IkiSaUGz5HWmYRkKLGfhQpJ1oFo1ks8YpNTCAPXpkr5cPj70+OXqEqDo9XAvs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=HRsCA9vO; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="HRsCA9vO" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=Wc/Jm5zhxzBVLmMo50nHUkwtD6JqHs64dPz97L5NBWU=; b=HRsCA9vOaoQWYIHd2QQhTbSlwI JyBs4GS4OWAjEmJ5z59QUr4VFl3fbSssHl2CH9Is7AbWXPvduaQ2Qj5xO9UEuhVxkjS/lyZrec7ts q3MHY7TtrwqBJAvMCwM3UloTSUDJ5BJ+c1TGCTpz9u70rAjefF5DhHZ0wR9avyJFFHck=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1wNsap-0034Gn-EA; Fri, 15 May 2026 15:28:43 +0200 Date: Fri, 15 May 2026 15:28:43 +0200 From: Andrew Lunn To: Petr Wozniak Cc: linux-netdev@vger.kernel.org, bjorn@mork.no, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: phy: sfp: probe for RollBall I2C-to-MDIO bridge before assuming MDIO_I2C_ROLLBALL Message-ID: <618d5fd2-0f2b-4ea1-b580-345a6f13bcd2@lunn.ch> References: <20260515115527.17241-1-petr.wozniak@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260515115527.17241-1-petr.wozniak@gmail.com> > -static void sfp_fixup_rollball_cc(struct sfp *sfp) > +/* Local mirrors of RollBall protocol constants from mdio-i2c.c */ > +#define SFP_ROLLBALL_PHY_ADDR 0x51 > +#define SFP_ROLLBALL_MDIO_PAGE 3 > +#define SFP_ROLLBALL_CMD_ADDR 0x80 > +#define SFP_ROLLBALL_CMD_READ 0x02 > +#define SFP_ROLLBALL_CMD_DONE 0x04 Please don't replicate code like this. Could the probing be moved into i2c_mii_init_rollball() ? Return -ENODEV if the probe fail? mdio_i2c_alloc() can then set sfp->mdio_protocol to MDIO_I2C_NONE? That would keep all the MDIO protocol stuff together. Andrew --- pw-bot: cr