From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 432FCC33CA1 for ; Tue, 21 Jan 2020 01:53:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 18E7F2073A for ; Tue, 21 Jan 2020 01:53:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728988AbgAUBxU (ORCPT ); Mon, 20 Jan 2020 20:53:20 -0500 Received: from smtprelay0248.hostedemail.com ([216.40.44.248]:60798 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726890AbgAUBxS (ORCPT ); Mon, 20 Jan 2020 20:53:18 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay04.hostedemail.com (Postfix) with ESMTP id 68169180A68AC; Tue, 21 Jan 2020 01:53:17 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: shake46_56b5e3c028834 X-Filterd-Recvd-Size: 1824 Received: from XPS-9350.home (unknown [47.151.135.224]) (Authenticated sender: joe@perches.com) by omf19.hostedemail.com (Postfix) with ESMTPA; Tue, 21 Jan 2020 01:53:15 +0000 (UTC) Message-ID: <618f58cd46f0e4fd619cb2ee3c76665a28e30f4e.camel@perches.com> Subject: Re: [PATCH -next] powerpc/maple: fix comparing pointer to 0 From: Joe Perches To: Chen Zhou , benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au Cc: gregkh@linuxfoundation.org, nivedita@alum.mit.edu, tglx@linutronix.de, allison@lohutok.net, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Date: Mon, 20 Jan 2020 17:52:15 -0800 In-Reply-To: <20200121013153.9937-1-chenzhou10@huawei.com> References: <20200121013153.9937-1-chenzhou10@huawei.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2020-01-21 at 09:31 +0800, Chen Zhou wrote: > Fixes coccicheck warning: > ./arch/powerpc/platforms/maple/setup.c:232:15-16: > WARNING comparing pointer to 0 Does anyone have or use these powerpc maple boards anymore? Maybe the whole codebase should just be deleted instead. If not, setup.c has an unused DBG macro that could be removed too. --- arch/powerpc/platforms/maple/setup.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/arch/powerpc/platforms/maple/setup.c b/arch/powerpc/platforms/maple/setup.c index 47f7310..d6a083c 100644 --- a/arch/powerpc/platforms/maple/setup.c +++ b/arch/powerpc/platforms/maple/setup.c @@ -57,12 +57,6 @@ #include "maple.h" -#ifdef DEBUG -#define DBG(fmt...) udbg_printf(fmt) -#else -#define DBG(fmt...) -#endif - static unsigned long maple_find_nvram_base(void) { struct device_node *rtcs;