From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DD3E38A726 for ; Mon, 16 Mar 2026 09:44:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773654279; cv=none; b=rmxWK2hFLSWGIwLnz3wYTAUzwS4TnfDsNaP7NMTGmqsyZBLFvMrD+A1FhOflxISB+u2351sb3n5VEI1gZ5gd6JxDTneTNJAYFOqvj3+UEObHfKeX2CiGet9rbonqp56ZdkjYLgfqjvVdYRBfPzjA3zlxarXDAXe04Cosdz3aXfw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773654279; c=relaxed/simple; bh=TG2aJSvJZ/wcZSsKs7YKB7Qcw/hVMLmolL8FopI8V60=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=ilB/AgPgwLPipqS/gBmDMggfmGdodiAa6mjZ7Hn3TxFqLWVoBg4Y5ygot3BCC6m9rveGYm/jgqTp2mc0kvEMSRjEqappKjIsXgBRwgbBWTnE3eKsezqa3zwrD5GVMRTcMKsJ2L9LKrUp39htmTEONR6AaBSlbXItGzX7J8uPVJ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w24UX-0007e2-Tc; Mon, 16 Mar 2026 10:44:05 +0100 Received: from lupine.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::4e] helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w24UW-000Y09-0o; Mon, 16 Mar 2026 10:44:04 +0100 Received: from pza by lupine with local (Exim 4.98.2) (envelope-from ) id 1w24UW-00000000hnW-0gS2; Mon, 16 Mar 2026 10:44:04 +0100 Message-ID: <618f82e69dab57f9ba335e2fc4bb62d2d601f7cc.camel@pengutronix.de> Subject: Re: [PATCH 2/2] mmc: sdhci-of-aspeed: Add ast2700 support From: Philipp Zabel To: Ryan Chen , Andrew Jeffery , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley , Ryan Chen , Adrian Hunter Cc: Andrew Jeffery , "linux-aspeed@lists.ozlabs.org" , "openbmc@lists.ozlabs.org" , "linux-mmc@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Date: Mon, 16 Mar 2026 10:44:04 +0100 In-Reply-To: References: <20260313-sdhci-v1-0-91cea19c8a67@aspeedtech.com> <20260313-sdhci-v1-2-91cea19c8a67@aspeedtech.com> <352a522b5325e9db80c880dd7a3a052516f3b673.camel@pengutronix.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-0+deb13u1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org On Sa, 2026-03-14 at 01:21 +0000, Ryan Chen wrote: [...] > >=20 > > Thanks the guidance. > > I will update use > > sdc->rst =3D devm_reset_control_get_optional_exclusive(&pdev->dev, NULL= ); > > if (IS_ERR(sdc->rst)) > > return dev_err_probe(&pdev->dev, PTR_ERR(sdc->rst), > > "unable to acquire reset\n"); > >=20 > Sorry, I review the devm_reset_control_get_optional_exclusive_deasserted > I will modify with following in probe. >=20 > sdc->rst =3D devm_reset_control_get_optional_exclusive_deasserted(&pdev-= >dev, > NULL); > if (IS_ERR(sdc->rst)) > return dev_err_probe(&pdev->dev, PTR_ERR(sdc->rst), > "unable to acquire reset\n"); >=20 > And add reset_control_assert(sdc->rst); in remove. Only do one of those two changes. The devm_..._deasserted() function will call reset_control_assert() automatically. See: https://docs.kernel.org/driver-api/reset.html#c.devm_reset_control_get_opti= onal_exclusive_deasserted regards Philipp