Re: [PATCH] regulator: core: do not ignore repeated requests on stepped regulators

[Romain Gantois <romain.gantois@bootlin.com>]

[-- Attachment #1: Type: text/plain, Size: 1133 bytes --]

On Wednesday, 21 May 2025 12:07:05 CEST Mark Brown wrote:
> On Wed, May 21, 2025 at 10:47:24AM +0200, Romain Gantois wrote:
> > Currently, the regulator_set_voltage() function will assume a noop if a
> > consumer requests the same voltage range twice in a row.
> > 
> > This can lead to unexpected behavior if the target regulator has a maximum
> > voltage step constraint. With such constraints, the regulator core may
> > clamp the requested voltage to a lesser value, to ensure that the voltage
> > delta stays under the specified limit.
> 
> No, if there's an issue here we should handle it the first time we set
> the voltage by doing multiple steps in one set_voltage() call.  Having
> individual client drivers all having to repeatedly call set_voltage() is
> obviously not a good API.

Understood, would it make sense to handle this directly in 
regulator_set_voltage_unlocked()?  For example by checking for a max_uV_step 
condition and repeating calls to regulator_do_balance_voltage() until the 
resulting voltage stabilizes?

Thanks,

-- 
Romain Gantois, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]