From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from codeconstruct.com.au (pi.codeconstruct.com.au [203.29.241.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCD4227603F; Thu, 19 Feb 2026 04:29:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.29.241.158 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771475383; cv=none; b=q0SGkLSJS/Bn1VUDAfNnTVXPJBW9QPXObU/GX1mSSHevISfzsEPzne54tdtJCD6CvQo0pnSKv5+1ELbS1YiHYd+ExhIw9fJuXjQz1xr9xyZJAUR0lqKAF87wbEG9zIloj1CBzXyje/EZVsE4kFbv7l1BzG3aZDrBKpru2ja8kqo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771475383; c=relaxed/simple; bh=IW9SER9RIitJsBDF56Xv2ooeDZNlYWYueCy861NkBAI=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=ESIUNnc0+34mxiTCroocUO1vn0iWuuJkjrHn66kkHvrSGPB/B7prXLzl6KNjFS4HQgqpxcnmAFpMsF1ACylgWQQqNsUdUb/6JmUzhZg59V24a6ZCpM216PZgk/A4E2sbmNEltYFFolvTvi2HEYb7oxEQSa04diIHpftiewN4b1U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au; spf=pass smtp.mailfrom=codeconstruct.com.au; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b=Bwojwkgh; arc=none smtp.client-ip=203.29.241.158 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b="Bwojwkgh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1771474857; bh=hXrvUZQrcqQlGaHQ11Cid7iVmcJJZTJxmPs9kL1e/rs=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=Bwojwkghc4xDICaeOQpHCSeB8PghyUnrrJCRmCC47tvOKYdQauZ9ySpiEMgRFHQje W7XQ9bOGmCwzJzAxSgb2kQWMHDnx/ck8uhmj78B3mgYQd5yosqtJWjc/aDRaobYMyG 1ievMsTD9NDe9y/4hZJpDuMYcEeSZ3CCfADJ8yASmQo+o5gwgvR8A12pyU8vI6HtjI 0IkXNFnda2+4MMi1XQliOtPXfvhNz1fd72yaFBtJxUdN58Lcmj0y9qqNtfYGLK2fin ml2MnBIN3YNT9i2P2sMskWwrRTHdNUV04FscunCJESHRjbT4iScD7f1Zj110Q19EG7 2ajMkwQcxDSQw== Received: from [192.168.68.114] (unknown [180.150.112.60]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 1839760033; Thu, 19 Feb 2026 12:20:55 +0800 (AWST) Message-ID: <6192440acc150d216de5e074299e579e891fc845.camel@codeconstruct.com.au> Subject: Re: [PATCH v2] ARM: dts: aspeed: anacapa: Add retimer EEPROMs From: Andrew Jeffery To: dirkchen@amd.com, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Date: Thu, 19 Feb 2026 14:50:54 +1030 In-Reply-To: <20260209-b4-anacapa-dts-fix-v2-1-fe446a7038bf@amd.com> References: <20260209-b4-anacapa-dts-fix-v2-1-fe446a7038bf@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-0+deb13u1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Dirk, On Mon, 2026-02-09 at 15:58 +0800, Dirk Chen via B4 Relay wrote: > From: Dirk Chen >=20 > The Anacapa board features Atmel 24C2048 EEPROMs on i2c0 and i2c1, which > are used to store retimer configurations. Add the corresponding device > tree nodes to support these components. >=20 > Signed-off-by: Dirk Chen > --- > Changes in v2: > - Improved commit description to clarify that the change reflects > =C2=A0 actual hardware as requested by the reviewer. > - Removed mentions of other platforms to avoid confusion. > - Link to v1: https://lore.kernel.org/r/20260202-b4-anacapa-dts-fix-v1-1-= 20d4b0114854@amd.com > --- > =C2=A0arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts | 12 +++++= +++++++ > =C2=A01 file changed, 12 insertions(+) >=20 > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts b/a= rch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts > index 221af858cb6b..b8d248d99d7c 100644 > --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts > @@ -328,6 +328,12 @@ i2c0mux0ch3: i2c@3 { > =C2=A0 #size-cells =3D <0>; > =C2=A0 }; > =C2=A0 }; > + > + eeprom@50 { Please order these nodes by ascending address. The node currently above this one is i2c-mux@70 - eeprom@50 should go before it. https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-= nodes > + compatible =3D "atmel,24c2048"; > + reg =3D <0x50>; > + pagesize =3D <128>; > + }; > =C2=A0}; > =C2=A0 > =C2=A0// R Bridge Board > @@ -362,6 +368,12 @@ i2c1mux0ch3: i2c@3 { > =C2=A0 #size-cells =3D <0>; > =C2=A0 }; > =C2=A0 }; > + > + eeprom@50 { Same for this one. > + compatible =3D "atmel,24c2048"; > + reg =3D <0x50>; > + pagesize =3D <128>; > + }; > =C2=A0}; > =C2=A0 > =C2=A0// MB - E1.S >=20 > --- > base-commit: 4c87cdd0328495759f6e9f9f4e1e53ef8032a76f > change-id: 20260202-b4-anacapa-dts-fix-207ffe9a3b0c >=20 > Best regards,