mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kathiravan T <quic_kathirav@quicinc.com>
To: Manikanta Mylavarapu <quic_mmanikan@quicinc.com>,
	<agross@kernel.org>, <andersson@kernel.org>,
	<konrad.dybcio@linaro.org>, <robh+dt@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <jassisinghbrar@gmail.com>,
	<mathieu.poirier@linaro.org>, <mturquette@baylibre.com>,
	<sboyd@kernel.org>, <quic_gurus@quicinc.com>,
	<loic.poulain@linaro.org>, <quic_eberman@quicinc.com>,
	<robimarko@gmail.com>, <linux-arm-msm@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-remoteproc@vger.kernel.org>, <linux-clk@vger.kernel.org>
Cc: <quic_srichara@quicinc.com>, <quic_gokulsri@quicinc.com>,
	<quic_sjaganat@quicinc.com>, <quic_arajkuma@quicinc.com>,
	<quic_anusha@quicinc.com>, <quic_poovendh@quicinc.com>
Subject: Re: [PATCH 11/11] arm64: dtsi: qcom: ipq9574: Add nodes to bring up multipd
Date: Tue, 7 Mar 2023 19:57:20 +0530	[thread overview]
Message-ID: <619878c3-25a8-3875-efc3-3cf1c6bc262e@quicinc.com> (raw)
In-Reply-To: <1678164097-13247-12-git-send-email-quic_mmanikan@quicinc.com>


On 3/7/2023 10:11 AM, Manikanta Mylavarapu wrote:
> Enable nodes required for multipd remoteproc bring up.
>
> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com>
> ---
>   arch/arm64/boot/dts/qcom/ipq9574.dtsi | 145 ++++++++++++++++++++++++++
>   1 file changed, 145 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> index 2bb4053641da..e0645bc39db4 100644
> --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> @@ -201,6 +201,11 @@ tz_region: tz@4a600000 {
>   			no-map;
>   		};
>   
> +		q6_region: wcnss@4ab00000 {
> +			reg = <0x0 0x4ab00000 0x0 0x02b00000>;


No need to pad the size


> +			no-map;
> +		};
> +
>   		smem@4aa00000 {
>   			compatible = "qcom,smem";
>   			reg = <0x0 0x4aa00000 0x0 0x00100000>;
> @@ -209,6 +214,30 @@ smem@4aa00000 {
>   		};
>   	};
>   
> +	wcss: wcss-smp2p {
> +		compatible = "qcom,smp2p";
> +		qcom,smem = <435>, <428>;
> +
> +		interrupt-parent = <&intc>;
> +		interrupts = <GIC_SPI 322 IRQ_TYPE_EDGE_RISING>;
> +
> +		mboxes = <&apcs_glb 9>;
> +
> +		qcom,local-pid = <0>;
> +		qcom,remote-pid = <1>;
> +
> +		wcss_smp2p_out: master-kernel {
> +			qcom,entry-name = "master-kernel";
> +			#qcom,smem-state-cells = <1>;
> +		};
> +
> +		wcss_smp2p_in: slave-kernel {
> +			qcom,entry-name = "slave-kernel";
> +			interrupt-controller;
> +			#interrupt-cells = <2>;
> +		};
> +	};
> +
>   	soc: soc@0 {
>   		compatible = "simple-bus";
>   		#address-cells = <1>;
> @@ -829,6 +858,122 @@ IRQ_TYPE_LEVEL_HIGH>, /* int_c */
>   			msi-parent = <&v2m0>;
>   			status = "disabled";
>   		};
> +
> +		q6v5_wcss: remoteproc@cd00000 {
> +			compatible = "qcom,ipq9574-q6-mpd";
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			ranges;
> +			reg = <0x0cd00000 0x4040>;


reg should go after compatible


> +			interrupts-extended = <&intc GIC_SPI 325 IRQ_TYPE_EDGE_RISING>,
> +					      <&wcss_smp2p_in 0 0>,
> +					      <&wcss_smp2p_in 1 0>,
> +					      <&wcss_smp2p_in 2 0>,
> +					      <&wcss_smp2p_in 3 0>;
> +			interrupt-names = "wdog",
> +					  "fatal",
> +					  "ready",
> +					  "handover",
> +					  "stop-ack";
> +
> +			clocks = <&gcc GCC_ANOC_WCSS_AXI_M_CLK>,
> +				 <&gcc GCC_WCSS_AHB_S_CLK>,
> +				 <&gcc GCC_WCSS_ECAHB_CLK>,
> +				 <&gcc GCC_WCSS_ACMT_CLK>,
> +				 <&gcc GCC_WCSS_AXI_M_CLK>,
> +				 <&gcc GCC_Q6_AXIM_CLK>,
> +				 <&gcc GCC_Q6_AXIM2_CLK>,
> +				 <&gcc GCC_Q6_AHB_CLK>,
> +				 <&gcc GCC_Q6_AHB_S_CLK>,
> +				 <&gcc GCC_Q6SS_BOOT_CLK>,
> +				 <&gcc GCC_WCSS_DBG_IFC_APB_BDG_CLK>,
> +				 <&gcc GCC_WCSS_DBG_IFC_ATB_BDG_CLK>,
> +				 <&gcc GCC_WCSS_DBG_IFC_DAPBUS_BDG_CLK>,
> +				 <&gcc GCC_WCSS_DBG_IFC_NTS_BDG_CLK>,
> +				 <&gcc GCC_WCSS_DBG_IFC_APB_CLK>,
> +				 <&gcc GCC_WCSS_DBG_IFC_ATB_CLK>,
> +				 <&gcc GCC_WCSS_DBG_IFC_DAPBUS_CLK>,
> +				 <&gcc GCC_WCSS_DBG_IFC_NTS_CLK>,
> +				 <&gcc GCC_Q6_TSCTR_1TO2_CLK>,
> +				 <&gcc GCC_Q6SS_ATBM_CLK>,
> +				 <&gcc GCC_Q6SS_PCLKDBG_CLK>,
> +				 <&gcc GCC_Q6SS_TRIG_CLK>,
> +				 <&gcc GCC_MEM_NOC_Q6_AXI_CLK>,
> +				 <&gcc GCC_WCSS_Q6_TBU_CLK>,
> +				 <&gcc GCC_SYS_NOC_WCSS_AHB_CLK>;
> +
> +			clock-names = "anoc_wcss_axi_m",
> +				      "wcss_ahb_s",
> +				      "wcss_ecahb",
> +				      "wcss_acmt",
> +				      "wcss_axi_m",
> +				      "q6_axim",
> +				      "q6_axim2",
> +				      "q6_ahb",
> +				      "q6_ahb_s",
> +				      "q6ss_boot",
> +				      "dbg-apb-bdg",
> +				      "dbg-atb-bdg",
> +				      "dbg-dapbus-bdg",
> +				      "dbg-nts-bdg",
> +				      "dbg-apb",
> +				      "dbg-atb",
> +				      "dbg-dapbus",
> +				      "dbg-nts",
> +				      "q6_tsctr_1to2_clk",
> +				      "q6ss_atbm_clk",
> +				      "q6ss_pclkdbg_clk",
> +				      "q6ss_trig_clk",
> +				      "mem_noc_q6_axi",
> +				      "wcss_q6_tbu",
> +				      "sys_noc_wcss_ahb";
> +
> +			assigned-clocks = <&gcc GCC_ANOC_WCSS_AXI_M_CLK>,
> +				 <&gcc GCC_WCSS_AHB_S_CLK>,


please take care of the alignment


> +				 <&gcc GCC_WCSS_ECAHB_CLK>,
> +				 <&gcc GCC_WCSS_ACMT_CLK>,
> +				 <&gcc GCC_WCSS_AXI_M_CLK>,
> +				 <&gcc GCC_Q6_AXIM_CLK>,
> +				 <&gcc GCC_Q6_AXIM2_CLK>,
> +				 <&gcc GCC_Q6_AHB_CLK>,
> +				 <&gcc GCC_Q6_AHB_S_CLK>,
> +				 <&gcc GCC_Q6SS_BOOT_CLK>,
> +				 <&gcc GCC_MEM_NOC_Q6_AXI_CLK>,
> +				 <&gcc GCC_WCSS_Q6_TBU_CLK>,
> +				 <&gcc GCC_SYS_NOC_WCSS_AHB_CLK>;
> +
> +			assigned-clock-rates = <266666667>,
> +						<133333333>,


same here


> +						<133333333>,
> +						<133333333>,
> +						<266666667>,
> +						<533000000>,
> +						<342857143>,
> +						<133333333>,
> +						<133333333>,
> +						<342857143>,
> +						<533000000>,
> +						<533000000>,
> +						<133333333>;
> +
> +			qcom,smem-states = <&wcss_smp2p_out 0>,
> +					   <&wcss_smp2p_out 1>;
> +			qcom,smem-state-names = "shutdown",
> +						"stop";
> +
> +			memory-region = <&q6_region>;
> +
> +			glink-edge {
> +				interrupts = <GIC_SPI 321 IRQ_TYPE_EDGE_RISING>;
> +				label = "rtr";
> +				qcom,remote-pid = <1>;
> +				mboxes = <&apcs_glb 8>;
> +			};
> +
> +			q6_wcss_pd1: remoteproc_pd1 {
> +				compatible = "qcom,ipq9574-wcss-ahb-mpd";
> +			};
> +		};
>   	};
>   
>   	rpm-glink {

  reply	other threads:[~2023-03-07 14:32 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-07  4:41 [PATCH 00/11] Add multipd remoteproc support Manikanta Mylavarapu
2023-03-07  4:41 ` [PATCH 01/11] dt-bindings: remoteproc: qcom: Add support for multipd model Manikanta Mylavarapu
2023-03-07 13:23   ` Rob Herring
2023-05-03 10:59     ` Manikanta Mylavarapu
2023-05-03 16:27       ` Krzysztof Kozlowski
2023-05-21 17:44         ` Manikanta Mylavarapu
2023-03-07 14:26   ` Rob Herring
2023-05-08 14:04     ` Manikanta Mylavarapu
2023-05-09 16:17     ` Manikanta Mylavarapu
2023-05-19  8:46     ` Manikanta Mylavarapu
2023-03-07 15:17   ` Krzysztof Kozlowski
2023-05-08 13:45     ` Manikanta Mylavarapu
2023-05-09  7:08       ` Krzysztof Kozlowski
2023-05-09 10:34         ` Manikanta Mylavarapu
2023-05-09 13:01           ` Krzysztof Kozlowski
2023-05-09 13:23             ` Manikanta Mylavarapu
2023-05-18 17:22       ` Manikanta Mylavarapu
2023-05-30 10:45         ` Krzysztof Kozlowski
2023-05-09 16:46     ` Manikanta Mylavarapu
2023-03-07  4:41 ` [PATCH 02/11] dt-bindings: mailbox: qcom: Add IPQ5018 APCS compatible Manikanta Mylavarapu
2023-03-07  6:05   ` Kathiravan T
2023-05-08 14:13     ` Manikanta Mylavarapu
2023-03-07 15:21   ` Krzysztof Kozlowski
2023-05-08 14:15     ` Manikanta Mylavarapu
2023-03-07  4:41 ` [PATCH 03/11] dt-bindings: scm: Add compatible for IPQ5018 Manikanta Mylavarapu
2023-03-07 15:18   ` Krzysztof Kozlowski
2023-03-07  4:41 ` [PATCH 04/11] dt-bindings: arm: qcom: Add ipq5018-mp03.5-c1 Manikanta Mylavarapu
2023-03-07  4:41 ` [PATCH 05/11] dt-bindings: clock: qcom: gcc-ipq9574: Add Q6 gcc clock control Manikanta Mylavarapu
2023-03-07  6:42   ` Sricharan Ramabadhran
2023-05-04  6:06     ` Manikanta Mylavarapu
2023-03-07 15:19   ` Krzysztof Kozlowski
2023-05-08 14:29     ` Manikanta Mylavarapu
2023-05-21 15:51       ` Manikanta Mylavarapu
2023-03-07  4:41 ` [PATCH 06/11] clk: qcom: IPQ9574: Add q6/wcss clocks Manikanta Mylavarapu
2023-03-07  7:28   ` Sricharan Ramabadhran
2023-05-09 17:02     ` Manikanta Mylavarapu
2023-03-07  4:41 ` [PATCH 07/11] mailbox: qcom-apcs-ipc: Add IPQ5018 APCS IPC support Manikanta Mylavarapu
2023-03-07  6:07   ` Kathiravan T
2023-05-18 17:44     ` Manikanta Mylavarapu
2023-03-07 15:20   ` Krzysztof Kozlowski
2023-05-18 17:46     ` Manikanta Mylavarapu
2023-03-07  4:41 ` [PATCH 08/11] remoteproc: qcom: Add Hexagon based multipd rproc driver Manikanta Mylavarapu
2023-03-07  6:16   ` Varadarajan Narayanan
2023-03-07 13:17   ` Sricharan Ramabadhran
2023-05-21 15:48     ` Manikanta Mylavarapu
2023-05-21 18:10       ` Dmitry Baryshkov
2023-05-21 22:07         ` Manikanta Mylavarapu
2023-03-07 15:39   ` Krzysztof Kozlowski
2023-03-22 10:18     ` Manikanta Mylavarapu
2023-03-22 10:21       ` Robert Marko
2023-03-22 10:51         ` Manikanta Mylavarapu
2023-03-22 10:53           ` Robert Marko
2023-05-21 17:05     ` Manikanta Mylavarapu
2023-03-07  4:41 ` [PATCH 09/11] arm64: dtsi: qcom: ipq5018: enable nodes required for multipd Manikanta Mylavarapu
2023-03-07 14:22   ` Kathiravan T
2023-05-19  5:34     ` Manikanta Mylavarapu
2023-03-07 15:41   ` Krzysztof Kozlowski
2023-05-19  5:49     ` Manikanta Mylavarapu
2023-03-07  4:41 ` [PATCH 10/11] arm64: dts: qcom: ipq5018: Add MP03.5-c1 board support Manikanta Mylavarapu
2023-03-07  6:25   ` Varadarajan Narayanan
2023-05-21 16:05     ` Manikanta Mylavarapu
2023-03-07 14:15   ` Kathiravan T
2023-05-21 16:09     ` Manikanta Mylavarapu
2023-03-07 15:42   ` Krzysztof Kozlowski
2023-05-21 16:12     ` Manikanta Mylavarapu
2023-03-07  4:41 ` [PATCH 11/11] arm64: dtsi: qcom: ipq9574: Add nodes to bring up multipd Manikanta Mylavarapu
2023-03-07 14:27   ` Kathiravan T [this message]
2023-05-21 16:17     ` Manikanta Mylavarapu
2023-03-07 15:44   ` Krzysztof Kozlowski
2023-05-21 16:23     ` Manikanta Mylavarapu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=619878c3-25a8-3875-efc3-3cf1c6bc262e@quicinc.com \
    --to=quic_kathirav@quicinc.com \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jassisinghbrar@gmail.com \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=loic.poulain@linaro.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=mturquette@baylibre.com \
    --cc=quic_anusha@quicinc.com \
    --cc=quic_arajkuma@quicinc.com \
    --cc=quic_eberman@quicinc.com \
    --cc=quic_gokulsri@quicinc.com \
    --cc=quic_gurus@quicinc.com \
    --cc=quic_mmanikan@quicinc.com \
    --cc=quic_poovendh@quicinc.com \
    --cc=quic_sjaganat@quicinc.com \
    --cc=quic_srichara@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=robimarko@gmail.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®