From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 735A6C0044D for ; Thu, 12 Mar 2020 02:41:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9009520734 for ; Thu, 12 Mar 2020 02:41:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="Lq9bjLEB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387690AbgCLClh (ORCPT ); Wed, 11 Mar 2020 22:41:37 -0400 Received: from linux.microsoft.com ([13.77.154.182]:43120 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387501AbgCLClh (ORCPT ); Wed, 11 Mar 2020 22:41:37 -0400 Received: from [10.137.112.111] (unknown [131.107.147.111]) by linux.microsoft.com (Postfix) with ESMTPSA id 8167120B9C02; Wed, 11 Mar 2020 19:41:36 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 8167120B9C02 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1583980896; bh=FPn0J0a+i5WpPQn+wWi5l3mA8piuchfQOex4GqLMil0=; h=Subject:To:References:From:Date:In-Reply-To:From; b=Lq9bjLEBp7SL0Z6FdOGkbsBEfiXIiOB12effq3ESopNg/WxdNEjjthlzf7xMDmeAr ksJOTlMvOTT49LGJ9z22mYxrAW2tGwOg59w69Vo8YhWOaOeJYfGmbJfkDVDbnqwmi4 EyWcjHr0Sf3O2tCS609q9IHQZFhVi2bv+KVqVI9E= Subject: Re: [Outreachy kernel] [PATCH] Staging: rtl8723bs: rtw_mlme: Remove unnecessary conditions To: Shreeya Patel , gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com, sbrivio@redhat.com, daniel.baluta@gmail.com, hverkuil@xs4all.nl, Larry.Finger@lwfinger.net References: <20200311135859.5626-1-shreeya.patel23498@gmail.com> From: Lakshmi Ramasubramanian Message-ID: <61a6c3d7-6592-b57b-6466-995309302cc2@linux.microsoft.com> Date: Wed, 11 Mar 2020 19:42:06 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200311135859.5626-1-shreeya.patel23498@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/11/2020 6:58 AM, Shreeya Patel wrote: > Remove unnecessary if and else conditions since both are leading to the > initialization of "phtpriv->ampdu_enable" with the same value. > > Signed-off-by: Shreeya Patel Stating this based on the patch descriptions I have seen. Others, please advise\correct me if I am wrong. Patch description should state the problem first[1] and then describe how that is fixed in the given patch. For example: In the function rtw_update_ht_cap(), phtpriv->ampdu_enable is set to the same value in both if and else statements. This patch removes this unnecessary if-else statement. [1] Documentation\process\submitting-patches.rst 2) Describe your changes Thanks, -lakshmi