mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
To: "Rafael J. Wysocki" <rjw@sisk.pl>, Pavel Machek <pavel@suse.cz>,
	linux-acpi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [BISECTED] HP G7000 battery disappears after suspend
Date: Wed, 8 Jul 2009 20:16:59 +0100	[thread overview]
Message-ID: <61b223ba0907081216q3813c8f0n677bcce8b24ae52c@mail.gmail.com> (raw)

Hi,

I've borrowed this laptop for a few days.  Linux works pretty well,
but I found a problem on newer kernels.  After suspend it claims the
battery has been removed.  E.g. /proc/acpi/battery/BAT0/state claims
the battery is not present (but it is).

I've attached acpidump and dmidecode output at
<http://bugzilla.kernel.org/show_bug.cgi?id=13745>.  I still have
access to the laptop for further tests, but only until Friday.

I bisected it to the commit below.  Manually reverting the patch fixes
the problem (in both 2.6.30 and 2.6.31-rc2).

commit d0c71fe7ebc180f1b7bc7da1d39a07fc19eec768
Author: Rafael J. Wysocki <rjw@sisk.pl>
Date:   Sat Oct 4 00:05:05 2008 +0200

    ACPI Suspend: Enable ACPI during resume if SCI_EN is not set

    On some machines, like for example MSI Wind U100, the BIOS doesn't
    enable ACPI before returning control to the OS, which sometimes
    causes resume to fail.  This is against the ACPI specification,
    which clearly states that "When the platform is waking from an S1, S2
    or S3 state, OSPM assumes the hardware is already in the ACPI mode
    and will not issue an ACPI_ENABLE", but it won't hurt to check the
    SCI_EN bit and enable ACPI during resume from S3 if this bit is not
    set.

    Fortunately, we already have acpi_enable() for that, so use it in the
    resume code path, before executing _BFS, in analogy with the
    resume-from-hibernation code path.

    NOTE: We aren't supposed to set SCI_EN directly, because it's owned
    by the hardware.

    Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
    Pavel Machek <pavel@suse.cz>
    Signed-off-by: Len Brown <len.brown@intel.com>


Many thanks
Alan

-- 
A: Because it messes up the order in which people normally read text.
> Q: Why is top-posting such a bad thing?
>> A: Top-posting.
>>> Q: What is the most annoying thing in e-mail?

             reply	other threads:[~2009-07-08 19:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-08 19:16 Alan Jenkins [this message]
2009-07-08 19:41 ` Rafael J. Wysocki
2009-07-08 21:45   ` Bartlomiej Zolnierkiewicz
2009-07-09 13:19     ` Alan Jenkins
2009-07-09 20:11       ` Rafael J. Wysocki
2009-07-10  8:44         ` Alan Jenkins
2009-07-10 16:46           ` Bartlomiej Zolnierkiewicz
2009-07-11  9:42             ` Alan Jenkins
2009-07-11 11:47               ` Alan Jenkins
2009-07-11 11:22             ` Rafael J. Wysocki
2009-07-10 16:37         ` Bartlomiej Zolnierkiewicz
2009-07-25 20:52           ` Rafael J. Wysocki
2009-07-08 22:24   ` [BISECTED] (REGRESSION) " Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61b223ba0907081216q3813c8f0n677bcce8b24ae52c@mail.gmail.com \
    --to=alan-jenkins@tuffmail.co.uk \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@suse.cz \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®