Re: [PATCH v1 1/1] hwmon: (isl28022) Fix current reading calculation

[Guenter Roeck <linux@roeck-us.net>]

On 5/18/25 23:16, Yikai Tsai wrote:
> According to the ISL28022 datasheet, bit15 of the current register is
> representing -32768. Fix the calculation to properly handle this bit,
> ensuring correct measurements for negative values.
> 
> Signed-off-by: Yikai Tsai <yikai.tsai.wiwynn@gmail.com>
> ---
>   drivers/hwmon/isl28022.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwmon/isl28022.c b/drivers/hwmon/isl28022.c
> index 1fb9864635db..6d8cdf80c9ea 100644
> --- a/drivers/hwmon/isl28022.c
> +++ b/drivers/hwmon/isl28022.c
> @@ -161,8 +161,9 @@ static int isl28022_read_current(struct device *dev, u32 attr, long *val)
>   				  ISL28022_REG_CURRENT, &regval);
>   		if (err < 0)
>   			return err;
> -		*val = ((long)regval * 1250L * (long)data->gain) /
> -			(long)data->shunt;
> +		sign_bit = (regval >> 15) & 0x01;

Just use (s16)(regval) or sign_extend() [granted, the rest of the code should
have done the same]. At the very least make sure that the code compiles.

Guenter

> +		*val = (((long)(((u16)regval) & 0x7FFF) - (sign_bit * 32768)) *
> +			1250L * (long)data->gain) / (long)data->shunt;
>   		break;
>   	default:
>   		return -EOPNOTSUPP;