From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 680B1469D for ; Mon, 6 Jan 2025 02:07:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.165.32 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736129265; cv=fail; b=NQwDmr/9ty1FOlPeL++Y7rARxJsa7Jzlr94P3pb2ODJ70MDI6crMpctbLdTvqVh/WPDNLPNTmbG8NEiqYNOTMBvNogJZdGcUuXbpGv2sngjtpz7rYSZErGtyzGRZuR97s9TppXJMFkAMSWki3q58RFiG9wBykSf725dPGlhL1ac= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736129265; c=relaxed/simple; bh=7BvvIhXw27imE+hqSEsaJOMEV0nHE11LAHImRQk41Qg=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=QXBWDonoosKKEtrjfsQPt8PVLJ2JgKPDEkiFKegyWiurjFgQ4MMzKuaMq9Rk0BYRJIsL9HDlXMTSAP1RAxNrKEGFWz5zfU2NtyWypSVIFehRwvW5225iSvLP7DAdwE/cjzlsVuwRCyPjdjgZkZyP5pS3U5rRXJhnzmLB5/EpTig= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=Qg6Pe71a; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=Ju+3fUHC; arc=fail smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="Qg6Pe71a"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="Ju+3fUHC" Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 505NLlxP005278; Mon, 6 Jan 2025 02:07:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2023-11-20; bh=UBmrt7mWLdWr3yyz4Skj0/vDjuoDAAkrGaxqeieeFbg=; b= Qg6Pe71azhco3X7jSRMKYLZWC3dDhPuqsfNtnkRubVTSqm1RvaKsQ/To4v+BIvbb bbfIXHb5n/wGMURZfZE3qBlK5TOu9AO6hwgTnDlPExpGGst4ehMUV6wgS7dIZj2k qUEQ+k/UGyzAj1M4wCPiTh7TspDvrMl43QCcCN0M0gzfWtV7W2ElAB2616vieq5v 26VAc+6e/WeSRaWQmPWHgbDCSgC0L9X7YK/D37Qy85Hg1mpsI4D4rNnH9kz7kDFr qSprePCFa8OGojxQUCm+cuiDxglMG7gzy0iQNkuzlvOPdpP62Sw7FCX1mMFW4sza yj7oA0GTYbofyeOo4nwT3g== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 43xuk0228u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 06 Jan 2025 02:07:38 +0000 (GMT) Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 5061TKZ8019971; Mon, 6 Jan 2025 02:07:37 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2177.outbound.protection.outlook.com [104.47.58.177]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 43xued16mw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 06 Jan 2025 02:07:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=X48xoNs24BWghJQTLkNv6lsBWvZNYBAG7sipSMaWr+eg8ssTUUZti12q8EPYkBS97GTuTw0dR+T7aXb5pIZYV6OX+B+p0P9/EsPVWw2OEDodLsPVgDIFfzLfq1V2LonIxK6LcpzcXTU+IxVLyMuAL5+V/AppIYRpcY9CHds1yBvWJNaeyaiEUY83F0MQRJBkH8/YEGvwBC/3GX2y/mYLJxlMRpKgsOVat3BO7yxsAP3VrhVMMlh3l0LHooqawMRLGeDgM1YhVaAGhoylBJPZF2yZaKmBCOSJceBs182INs3E2kWfXZZbFbleZFE4TcA2U0kVK9VITgNba7p25nDRiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UBmrt7mWLdWr3yyz4Skj0/vDjuoDAAkrGaxqeieeFbg=; b=ndkvMUE63XjauWzTgVPraatbmpmZXEgetivpwKjVLFZI7i2B4EGnEFw0mk0WuUt48DXgBeHRDxXifNxftC9pfWLgYD9VNIp3htTpuzAaJJZ5BfquqHrZWT/o9ZNKXLy6WjM541WTCgqbeWHM7aLc1newKn5Dw6qqpyg3JcIcbmAIRhR0hXRDbrSr3ZaZHNXxyT/qPMI6iDYif4GHbhSyFIsdDCeqdoC93pr+OSZA5y+Vq+GPFLAPUE3s8DWUTLtOt35i6Ld8+GQLT7CsRRt50FxiD9ghDf/U1SL0Hh1so6eli/t3YWMoufpKYlK3CzUQ966gAdJZcAjMchUpKZawDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UBmrt7mWLdWr3yyz4Skj0/vDjuoDAAkrGaxqeieeFbg=; b=Ju+3fUHCYFkiFvl1KqjtF4lEy52llfGHOjmfYad0WQJOoIbwthiR8KrpdLwrOB/4OUihp/xWktP8jzo58eOnSXarXmWqRd728SiiSOOn4jTM15i5+/mRumB+KT9PyQie/HWAndVPjBaUK48UWnWaGYE7mATfItgySerXS2tVE3k= Received: from CO1PR10MB4468.namprd10.prod.outlook.com (2603:10b6:303:6c::24) by BN0PR10MB4998.namprd10.prod.outlook.com (2603:10b6:408:120::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8314.17; Mon, 6 Jan 2025 02:07:31 +0000 Received: from CO1PR10MB4468.namprd10.prod.outlook.com ([fe80::485e:729e:c0a4:e562]) by CO1PR10MB4468.namprd10.prod.outlook.com ([fe80::485e:729e:c0a4:e562%5]) with mapi id 15.20.8314.015; Mon, 6 Jan 2025 02:07:30 +0000 Message-ID: <61b68035-4f8d-431b-9561-96716ef9ac79@oracle.com> Date: Mon, 6 Jan 2025 13:07:25 +1100 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] workqueue: introduce WORK_STRUCT_TIMER_PENDING_BIT. To: Tejun Heo Cc: jiangshanlai@gmail.com, linux-kernel@vger.kernel.org References: <20241230064500.1404206-1-imran.f.khan@oracle.com> Content-Language: en-US From: imran.f.khan@oracle.com In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SY4P282CA0007.AUSP282.PROD.OUTLOOK.COM (2603:10c6:10:a0::17) To CO1PR10MB4468.namprd10.prod.outlook.com (2603:10b6:303:6c::24) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PR10MB4468:EE_|BN0PR10MB4998:EE_ X-MS-Office365-Filtering-Correlation-Id: 456272a1-b065-44cf-987e-08dd2df6e053 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?c0lqWWczK08xZ1hVZ294clhRS1VqZWtnRFJtSzBvbExBSjNsTEQ4cXAwcU5T?= =?utf-8?B?ZUh1cWFLUkVGQkVBMTJtUGlNWGxDaWxpOEE0VVNPblFYM3dGWXlCK2x5aElN?= =?utf-8?B?S3NUTDNwUWg1d0k5ZElITU9sS0JzSlpWNGNJZmdKVW15T3A1dHRqYXYxZERX?= =?utf-8?B?SnhNdE1qUk54amdXY0VIczdTKzBTR2E4VldpOFhnQVduaTNldXNIZWthdnBQ?= =?utf-8?B?MGVVZEFNeDhLSlYxWWFPMElhRDdKWHpKSFdEZXlVMHBNK3hzWk1kRnNBV00v?= =?utf-8?B?Rm41cCthSDl4RmQ4RGtKU01HbHA4K1lFZU1QSXR4WC9FZVAxWDhabGRPdUUr?= =?utf-8?B?N2I2R3lKOG1FK0ZiQVk0VExtNk9sTHEwblZ6RXFSSTRZUSt0K0lDRC9oODh5?= =?utf-8?B?dG5tOWFLcklKYjQxZ1dtQjFkNDErYmJ5ZnJhKzdQV3pIVEl2TEd6Y2h1MGZY?= =?utf-8?B?cGZRUXdPTkVtM1NrREJlMW5TOXVoelYzbm45UHd5SksyZnM0WTV0YW5jRk1z?= =?utf-8?B?NWJwbzN6R0M3b0tUaC9EOVdPNkZHTWtSQm1yQkhUZWhFY3pQeUV6dlBYODdD?= =?utf-8?B?a2Nrbk8zOUlXazdJVG5pOFRaZWZMNWFjZ1NETWxWZ2pMMnFQanN5Z3gwazg1?= =?utf-8?B?TE9kWHlXd2pET3IvcWNTaWd4ZWJOcVBIUWxNNUd0Szc1YzFhOUZxQXV6Yll6?= =?utf-8?B?ZzVSNmRXVW5Id0tCYktKOUg3eFlXQXNQREcxMUNWSk9kQktvb2R1YW1Sc25z?= =?utf-8?B?NzlWWGxNcjVVcytmVWlxdGRHSVg4UWVOMjRJKzNXQjdMZGkvRVdlb2JYMVh5?= =?utf-8?B?YXFmSzBOdVBQMnpUVWtEV25hWERqT2xVQ1JZVFJWRElnSFE0QXVRMDRFcUFs?= =?utf-8?B?djZXbDk2YU4rZWZPcHhtNW9HZkNHNnJrYTBZYjJ3N3hHbnpMUG1WV3QxT1ZJ?= =?utf-8?B?Q2FhREV5Uld0RGlINldNUk1YSDgrRHRPSWF6QWRYcjRjQVdhakdWTlljYnJi?= =?utf-8?B?RWhNOGc4R3ZWeklvT2djeHIwTEFTb0l4cVU0czFDckkxdHVHWGE0MUp5cU5r?= =?utf-8?B?dWp2am9IVzdMaWdvWjNWL0dudWpNM1NGbm5KVUtEYmloNFVXRGF6cDBuem15?= =?utf-8?B?SmdrRDVINGpTN0tJZWNJS05pb0M2TzlkVDNsTS9QSnNIT2wvT0NUcmhtdjNS?= =?utf-8?B?VVlyY2FsUHhXcGZYeFk4U3dTZUU1L2V5Q2RWT3JJYzMxR3hYZ0ZvRmpWTTA2?= =?utf-8?B?T2s2QXJ1TWpSd2ozRTluekw5MWFZZy80clhlUDUvMDBNanhKSVp5dFZTYjJl?= =?utf-8?B?eTlVZzhLNk1XL2lRTlZrRUQ3N2hsNnVNYXpuUmJmeDE0dDdyZTlzdWxkQTRW?= =?utf-8?B?eklVYjA3Q1dldDVjMFloWUZxT0ZONFdkQVRKNHpDWnBjSjIrdDh3TUsyempy?= =?utf-8?B?anR5dHJWbXZST0dwVldaakhrampPVXI2MGNqZUFLMVdNQ2JvSWlCQUpxbGQz?= =?utf-8?B?OWV3WU5Hd2FsZzdDcUl3K2lJbDI0RklxZHZQMnRDNVJMWTl5L0VTOEJBVWZK?= =?utf-8?B?WkNCTmdOVTZ6TGhFdjI1RjZkeS9za3h1SmVwOEhtZVgrbFdlaHJiazJ0Q1Bk?= =?utf-8?B?WG91MnRSSzYvamJJaVNnbmczT3RicmFIM3hGOVYzekJOaCtJWE04cUZiOUw2?= =?utf-8?B?VngvQ05yRjJoSmRqcE10UkdIbDBGdHphRENnZk5BSHJmVEFZYXhGUmVHa0RW?= =?utf-8?B?Wk1yV0oyR0NHUHhHT21MejE2ZzBESFY3NU84Y1h4S0dqNWxVV3BPcmpqbVVV?= =?utf-8?B?UDZNbGY5V3FPalRyQTFUdmJSZ1BrRWQxZzhjcHl2YXpFdmsyd0o5K0lXYmdI?= =?utf-8?Q?e1b7j6OJhdIE/?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR10MB4468.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aUlQaDgrRlJVNlNSdWZBMVRaR2EyMERuaUU1TzNUSlczaDEwVWN4UnpVVVR0?= =?utf-8?B?TXBiUVFUaGJwSW0xQ21YZXpaL2pTTkRHeXZiaFpERHg2YktCWmlicWFQUDZk?= =?utf-8?B?NWRET1I1RkMwc0FFUml4NzR1YjB2NFp6Q1plaXpmM2hFV2JkUzRTb1JHcUV4?= =?utf-8?B?c0E1TFV6bW1rd2x6QUpKWXhmc1g2cWNkZ3c0MDNlREE0NlJkV3VTNDRLbXpy?= =?utf-8?B?TEFtd1E5UTd0RUdQM1RRazc0K1d1Yll4S0RRNElVcVV1bkVnTnMycmRmYUd5?= =?utf-8?B?cy9LYklpYitZS2FsUlhqREVSMEUySlVQTnk5NkJPTUlSZ2hsaWhFZkZJS1BM?= =?utf-8?B?ZEZpYWZWNWd3QlBwd3ZFVUdqWDFsMWo5ZVROWDJnWEFrNUMrazdCSE8vSXRD?= =?utf-8?B?Sm1vYUIwenhkbzdOc0FXNzdMVE8raXB2RnhqVDl1N0RhUnRTZTNWZzZMUHNU?= =?utf-8?B?eFgwcllzckRHWEd6dmRYc2prQk5KNTA1eXdzcTV0c05BTVcySzFWMTZKMk5h?= =?utf-8?B?MzRzdVR4dm9uWWRoaFI5T3hiMUhGQUJYeHJrbnVvUit3clg3ZUxkeVQyQTdm?= =?utf-8?B?MmFGQjh2d3ZwTzBDbUYvcytQeUZqeWlIWVE1ZXlMZXdubkZYdHJjQkhEdEox?= =?utf-8?B?VTUxeHZtTHl0WktIb28xR1NBUDJtajRTOW9MMG9VTEd5bTNEOUU5VUtoazVS?= =?utf-8?B?Tk9RMXljZlFSS3ZKTU8zdS9QYlpBNVhRNGVqbjVWTlFuWElLZDVBREgvaExu?= =?utf-8?B?eFVOYnU1cmpXUGRNRU1NWmxvM1RENmZCbkxkQ3RtTnMwTnQ0N01wSytIbE1I?= =?utf-8?B?SnZqS1VQVEprTURpWkl2aVVreCt6WEV3aytWbThPNmRuTDN1a2dYa2dwYmdL?= =?utf-8?B?d0hjQnRLRC9tdUxWL3pvMXpJN1NzelIrM24zM2p3N3pPZld1a1NFM0JXdk52?= =?utf-8?B?T29QMWwyUWlzYXlqQkM0Yy9PWlc0S3lwWko3V0hNbG1lSUVYMjhNcnAyaDBQ?= =?utf-8?B?dHlyVitYTWdJSkplQytxU1lCSC9wR29yckhTbzlLRVZxYzZ1YnBoTGpYU0wv?= =?utf-8?B?czNObDd3RVFzQXkyeVc1L0xKdlVIakwzV2RmTzlJZEZUcHBxM3B2bmVRSFBL?= =?utf-8?B?OUcrRFIzeDhEb0xYVitQODZaL3BiNGV0QmJtaHExdGFXTzZ1eW45elVSMVJ6?= =?utf-8?B?UitkS1hJNm5PSlRUazRFdnVETzRaQ1RoTUd2ZHU2cTIzUFRGTzE4Rm4ySkh6?= =?utf-8?B?eGIydjl1L04zaTZHOHBtTE1FanRqYjRjdHJHY3NIODJRcWJEYmZqNTFJd0lU?= =?utf-8?B?NFZkNUs4MWpYdVA4aUY1eko1WUpwVS8yZU5EVjlXbUxKRHhOcXk0VUpEU1JQ?= =?utf-8?B?dnFhK3NObTYvWGVnemdQQkV0cnM0RjM5b1ptbVlBZDRDM3czMTNic0wzY3lR?= =?utf-8?B?dXJrUEk0ZjNtbC83WlUrZXJldzlWdVR6RnM5c1FFRTN3SFpxSjJvbW5GUWtj?= =?utf-8?B?MHZpUlJjRm5pbkt6d3FLY1VrT3AvOTczZWYybThUM3UzRThBSFRCRi81V3hz?= =?utf-8?B?ZTJFQjBkNnY0ekF5YzljbzhUTHBpQmFRdGlScERydUZRTkpEK1hqWVZKOW14?= =?utf-8?B?eUViTEQ5RDVSK1lGSzBNVzlyR0FlQitFZmZlRUt3L3RrUldDazRkWDF6QVlO?= =?utf-8?B?S2M4MDJYTFdxR3hMSTQ1WWNDWk02UjFVcVM3VDVkMmlrR0dUanRzMzkvZ3Za?= =?utf-8?B?U0FuVnB3LzhocVpuL2h6NG1QRjNmRXpaZE1TaUIwN0RRUjhpY2tDOGFZbk9K?= =?utf-8?B?LzVZbmhEbEdDOXd0SEtjMUVqaXJKUEtKbkRucnRJV3NDTUpna1RhSWNqNXZz?= =?utf-8?B?V1E1Sk4vYWY3SmZpZzZxVmRWWEhURjBNTVlqV0tmUjdPRXJIM1FrWkl5VjZa?= =?utf-8?B?SkdQME16M3R3YXlPbXZ4Zi9xaTJMN09lL0ROblRRQ0RaZzB2UnZZR3c3MW5Y?= =?utf-8?B?RWsrWWR4b1VBM1FZdHJDdythTDlBSWVjYU1MaEdDTVR4WGV1a1c2VG9qWHFH?= =?utf-8?B?a2tqVlM0WERLUlVhMGNjWHViNE9tUDdrWHJ4ZERic01WTTFMQXdESEdhLzBP?= =?utf-8?B?aERNTG5yNysySlBOQllEanJ0dmxIeiticlVxMitjSEU4RWc3Umo1aVRhYm1D?= =?utf-8?B?bFE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 68/h6qYO4twuCHzKIrZ/cQ3YLewMxGN0zUNphdWlsV/aX2Gj23vpVR8CDizMQybIOoeD7iHfy0UpsNLd93AX1frboCQn3w2gXSW7CJez1Yhn3KvbiRmDT0zdQILAZYAW4LpskmRPWbWLcr26I24XLO6/BnIFtttYZyd9LdDgmkMuAfammYdoToW8vftr9CT2WPdF3YkIWbPFZ1J1QKIlSbsJ976qDErEavV8lyNaVTaDLyYfJNcJ6mxMIinuCcDJdJZygboSjqDhAE3eS5T8CtNtX+qcFI6e/j2egZFhQTujS1OkIp2mzd+5nYK54+ULPRBRHTokngfYqPtSXIIIdjubPbxTxqcFsU3JMYHcpv462BZes+yc2Rx79CmrHh7wb+CBdtP+RB7U2y0h217TPljLwJB63DHDFfVnf8Z7Cz1sZ3iVk3uA5RTMPM9ftkHcjJnNa3LMCDAPmirVtptsAt4vROYXbURcO98eF38yMMcVhjYyHwcOv7ZeRJ+MmPRFGcW1q8F/As+xD29AlxQS1ZXTpjKUuOR09oU50FQqNm1G0Ewt41E3vuPh4X+tvOtOfXhUFWbd1Jen3bHqS0h6Rj7jWF6rIfFS/AX3cSNwy1g= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 456272a1-b065-44cf-987e-08dd2df6e053 X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4468.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2025 02:07:30.8020 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aNTjQ4tJQGQf5tYAR1UPYgP5Aq41pbL6pAbl4AG74t1+jqEKd6yQsM7omfy2NxBZgWhqM5K3dQ8C8cuf3sUPBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB4998 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-02_03,2025-01-02_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 spamscore=0 mlxlogscore=999 bulkscore=0 phishscore=0 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2411120000 definitions=main-2501060016 X-Proofpoint-ORIG-GUID: p2R_QOWFa3JnDR6P2ZkQzuBkL_UuCOPo X-Proofpoint-GUID: p2R_QOWFa3JnDR6P2ZkQzuBkL_UuCOPo Hello Tejun, Thanks a lot for looking into this. On 4/1/2025 9:18 am, Tejun Heo wrote: > Hello, > > On Mon, Dec 30, 2024 at 05:45:00PM +1100, Imran Khan wrote: >> Currently WORK_STRUCT_PENDING_BIT can indicate a work_struct that is >> already made it to work list of a worker_pool or a work_struct that has >> not yet made it there because it comes from a delayed_work whose timer >> has not expired yet. >> >> Use WORK_STRUCT_TIMER_PENDING_BIT to distinguish between these two >> states of work_struct. >> >> Signed-off-by: Imran Khan >> --- >> I have kept the patch as RFC, because this change is not fixing a bug. >> It makes WORK_STRUCT_PENDING_BIT less ambiguous and helps in debugging, >> by indicating where one should look for this pending work. > > But can't you already tell this by looking at the work struct? Yes this can also be inferred by looking at pwq information set by insert_work. If there is some other way, could you please let me know. But this path (__queue_work->insert_work)is taken for normal works as well and I thought that having a dedicated bit in the work_struct to indicate that this work comes from a dwork, whose timer has not yet expired, would make debugging easier. Further in cases where dwork is part of another object and there is a possibilty that some data corruption issue might be messing up the dwork or dwork.work, we would have an extra piece of information to check against. I'm not sure > about adding more atomic ops for redundant information. > I understand your concern if this extra piece of information is not worth the overhead. Thanks, Imran > Thanks. >