From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2C6DC433F5 for ; Thu, 6 Sep 2018 12:09:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7BD802075B for ; Thu, 6 Sep 2018 12:09:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7BD802075B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727760AbeIFQov (ORCPT ); Thu, 6 Sep 2018 12:44:51 -0400 Received: from mga05.intel.com ([192.55.52.43]:15985 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726436AbeIFQov (ORCPT ); Thu, 6 Sep 2018 12:44:51 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Sep 2018 05:09:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,338,1531810800"; d="scan'208";a="255001076" Received: from linux.intel.com ([10.54.29.200]) by orsmga005.jf.intel.com with ESMTP; 06 Sep 2018 05:09:22 -0700 Received: from [10.125.252.28] (abudanko-mobl.ccr.corp.intel.com [10.125.252.28]) by linux.intel.com (Postfix) with ESMTP id C85885803D7; Thu, 6 Sep 2018 05:09:20 -0700 (PDT) Subject: Re: [PATCH v7 2/2]: perf record: enable asynchronous trace writing To: Jiri Olsa Cc: Ingo Molnar , Peter Zijlstra , Arnaldo Carvalho de Melo , Alexander Shishkin , Namhyung Kim , Andi Kleen , linux-kernel References: <1fc1fc5b-a8cc-2b05-d43c-692e58855c81@linux.intel.com> <20180906110423.GH8248@krava> From: Alexey Budankov Organization: Intel Corp. Message-ID: <61b828af-dd68-a45a-2a90-af8b29cc4c94@linux.intel.com> Date: Thu, 6 Sep 2018 15:09:19 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180906110423.GH8248@krava> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06.09.2018 14:04, Jiri Olsa wrote: > On Wed, Sep 05, 2018 at 10:39:25AM +0300, Alexey Budankov wrote: > > SNIP > >> + } else if (errno != EAGAIN) { >> + cblock->aio_fildes = -1; >> + pr_err("failed to queue perf data, error: %m\n"); >> + break; >> + } >> + } while (1); >> + >> + return rc; >> +} >> + >> +static int record__aio_sync(struct perf_mmap *md) >> +{ > > this is almost identical to record__aio_sync function, > it looks like we should be able to do the sync with > single function.. for both the in-between syncs and > the final one There is some code duplication here. for()'s loop body at record__aio_complete() could probably be separated to a function and then reused by record__aio_sync(). The rest is not obvious at the moment. > > jirka >