From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0BF9B1B87FB for ; Fri, 28 Feb 2025 19:56:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740772562; cv=none; b=rBbZ/uOrTBULGRMVWfKbS75Djsyt8HuWhS3zxEO6ONZ714qyFwri1gpHy1FJZ8YP7xbJczuk7Bz+/RG/3mvMEulkPqamfgJ8ue1EpFWiKO67x4N1gy8QMkJ/pkUiH7uPxDJwrKDWyvJjE0xeBZst9NvpYn11KSN7vYIG7pUPP5k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740772562; c=relaxed/simple; bh=tXkBg/wxFeO9pOJt/0nYGoKZFgxLdb9iUHb2+LPganA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sgvXzogk+3HA517mA1uJBAwcggx37N2wGSBUPR1N6uHo6PN1591ZQC7rJC5qEFkLaBKEvIi1r8CX9bGai6EAre+8Cnh93kGpHRvpVg0LMF8k3AZfOxb1OXhZvwoewFnRCCrQa8vMFNuqTuAwly4BSKrRWIQ5fQpkAOaFwwiqYzY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5595E1515; Fri, 28 Feb 2025 11:56:15 -0800 (PST) Received: from [10.1.197.49] (eglon.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1C33B3F5A1; Fri, 28 Feb 2025 11:55:53 -0800 (PST) Message-ID: <61bb1e8c-c886-4f05-a148-380481530565@arm.com> Date: Fri, 28 Feb 2025 19:55:52 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 28/42] x86/resctrl: Handle throttle_mode for SMBA resources To: Reinette Chatre , x86@kernel.org, linux-kernel@vger.kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , H Peter Anvin , Babu Moger , shameerali.kolothum.thodi@huawei.com, D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , peternewman@google.com, dfustini@baylibre.com, amitsinght@marvell.com, David Hildenbrand , Rex Nie , Dave Martin , Koba Ko , Shanker Donthineni References: <20250207181823.6378-1-james.morse@arm.com> <20250207181823.6378-29-james.morse@arm.com> Content-Language: en-GB From: James Morse In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Reinette, On 20/02/2025 01:20, Reinette Chatre wrote: > On 2/7/25 10:18 AM, James Morse wrote: >> Now that the visibility of throttle_mode is being managed by resctrl, it >> should consider resources other than MBA that may have a throttle_mode. >> SMBA is one such resource. >> >> Extend resctrl_file_fflags_init() to check SMBA for a throttle_mode. >> > > "Extend resctrl_file_fflags_init()" -> "Extend thread_throttle_mode_init()"? Gah, more rebase noise. >> Adding support for multiple resources means it is possible for a platform >> with both MBA and SMBA, but an undefined throttle_mode on one of them >> to make the file visible. >> >> Add the 'undefined' case to rdt_thread_throttle_mode_show(). > | Reviewed-by: Reinette Chatre Thanks! James