From: Jorge Ramirez <jorge.ramirez-ortiz@linaro.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: gregkh@linuxfoundation.org, mark.rutland@arm.com, kishon@ti.com,
jackp@codeaurora.org, andy.gross@linaro.org, swboyd@chromium.org,
shawn.guo@linaro.org, vkoul@kernel.org,
khasim.mohammed@linaro.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] phy: qualcomm: usb: Add Super-Speed PHY driver
Date: Wed, 30 Jan 2019 13:27:59 +0100 [thread overview]
Message-ID: <61bdca18-cef9-3f02-45ef-5df4f96b4f2b@linaro.org> (raw)
In-Reply-To: <fbd70494-e2f1-ae04-8b14-2cc97cead8b9@linaro.org>
On 1/30/19 10:53, Jorge Ramirez wrote:
>> + priv->vbus = devm_regulator_get_optional(priv->dev, "vbus");
> get_optional means that if vbus-supply is not found, rather than
> returning a dummy regulator object this will fail with -ENODEV.
on this subject, is it intentional that devm_reset_control_get_optional
behaves differently (ie, it returns a NULL if it cant be found)
IMO all *_get_optional should be semantically as well as functionally
equivalent to avoid confusions like the one I had.
next prev parent reply other threads:[~2019-01-30 12:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 11:35 [PATCH v2 0/2] USB SS PHY for Qualcomm's QCS404 Jorge Ramirez-Ortiz
2019-01-29 11:35 ` [PATCH v2 1/2] dt-bindings: Add Qualcomm USB Super-Speed PHY bindings Jorge Ramirez-Ortiz
2019-01-29 20:38 ` Bjorn Andersson
2019-01-30 20:02 ` Rob Herring
2019-02-05 11:02 ` Jorge Ramirez
2019-02-06 14:11 ` Jorge Ramirez
2019-02-12 20:47 ` Rob Herring
2019-01-29 11:35 ` [PATCH v2 2/2] phy: qualcomm: usb: Add Super-Speed PHY driver Jorge Ramirez-Ortiz
2019-01-29 20:27 ` Bjorn Andersson
2019-01-30 9:53 ` Jorge Ramirez
2019-01-30 11:38 ` Jorge Ramirez
2019-01-30 12:27 ` Jorge Ramirez [this message]
2019-01-30 19:58 ` [PATCH v2 0/2] USB SS PHY for Qualcomm's QCS404 Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61bdca18-cef9-3f02-45ef-5df4f96b4f2b@linaro.org \
--to=jorge.ramirez-ortiz@linaro.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jackp@codeaurora.org \
--cc=khasim.mohammed@linaro.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=shawn.guo@linaro.org \
--cc=swboyd@chromium.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®