From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793366259; b=ODEGCIpWlsCgwYX8RvrVay1KSqtHLsWiyiCS+mtB70VnuoR/JlutAw3ABsvJCwE8NIS8 jFXvhgLaVGIdA5Q5t7ZBVwHgD/KQRrp+k+DnGoZaabIH3Ic7Xz6vUGzXInOWyyr9VDoIP koRyZItSoOe1mPWzFveXO18NhS93Ir6BxDsH6aj5wHHc8Sy/dZTgcQdjT8XKvBISa5YaJ KJ1d8C/2/utQkwDV3rEAaPOXQpROZmY02DP85egPF0XGrGc7oCOMbzWnhxqI13QGtKsFg F8E17jL/dNsfxOz1XTJ1I5psAmhpDm09cyTC0JAW7Ic4zk8I1G8nH7IehaJg9DbKsug== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793366259; h=Received:DKIM-Signature:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:From:Content-Language:Autocrypt:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=bhseTYkSHUica+S5LVec+4or3W7ZXkrIkBeRpANvA8g=; b=CvQHM3tKnYK54IbVejZ8S/bbzIlWeAV7xu7hGD3/Trg4NgS5BToCqtWlDabOdi5DsWpP 7q7AMKvcLvZR05mLZD4BgyHWacuNlu+tC+3rLHa5X3sW1Vzs7XfLcbEtj/KxbUL4vpOQQ v4MKm2xrGI8/p24IdwmA5CnKIjE+yl4dHVLXbceyy9jIIIBaK06eeuqMh6lVSvBQ182e0 H9JTLzPXW8Casahyy6wEkrQsRu8aaI504EO1wYByZ7u0S2Wcg4HKjbSeQmiAq1dYKAm/t PmJGVPZ6OizwCVgwdBOA8htbubWTkKe2bMaYEOGRJg8/fh3EcTZ6kOuuowHyo0mXZ8A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=EN4CDrWN; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 760BE606A31C for ; Fri, 30 Oct 2026 13:17:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=EN4CDrWN Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7537B1F000C1; Fri, 30 Oct 2026 13:17:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793366259; bh=bhseTYkSHUica+S5LVec+4or3W7ZXkrIkBeRpANvA8g=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=EN4CDrWNAbXKxJQyXan2diA+mvpaEwAj5+X3esCbgv8QIkTpoClmEpgnyyJIaGFXL XrktCygbjCf4B+bi9rvP5MibGHSoXq9dspISeOQeYC236l/FAec/74BV15g5JppjzI RP0oIciCc/d0DclR22lwBF1WklAqUoZ+HBo3MPFKHz15vJ5Q3Oq6NQ9ahFfHyTADwT 77m39KFV1bKbXYU/tcHBcNpI/wa98UrYuHIWE3BbMRF/lQKLqioHbux1M9G62x0pDM K44WJwmo+ZdBKZb5BITAotb50saafyM+w109I7Glf3tjcuI7d2RSLCdDLBQ6NY8lpP SM66LfwdjBlpg== Message-ID: <61beb545-32ba-4c16-9c6e-27948d294ee4@kernel.org> Date: Fri, 30 Oct 2026 14:17:34 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/9] w1: ds2805: use the bus mutex to talk on the bus To: Greg Kroah-Hartman Cc: Josef Bacik , linux-kernel@vger.kernel.org, stable References: <20261027-llm-char-misc-w1-v1-0-d2e6bfafb6a4@linuxfoundation.org> <20261027-llm-char-misc-w1-v1-5-d2e6bfafb6a4@linuxfoundation.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: <20261027-llm-char-misc-w1-v1-5-d2e6bfafb6a4@linuxfoundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 27/10/2026 17:04, Greg Kroah-Hartman wrote: > From: Josef Bacik > > Since commit b02f8bede217 ("W1: split master mutex to avoid deadlocks.") > the slave drivers serialise their accesses to the bus with bus_mutex. > This driver takes the mutex of the master in the callbacks of its eeprom > file instead. > > That mutex is held while a slave which has disappeared from the bus is > removed, which waits for the sysfs callbacks of the slave to return. A > callback which is waiting for the mutex at that moment never does: both > tasks are stuck, and with them the thread of the bus master. > > Besides, it does not keep the other slave drivers off the bus, so that two > transactions can get mixed up on the wire. > > Fixes: f6887531c0c6 ("drivers: w1: Add 1w slave driver for DS28E05 EEPROM") > Cc: stable > Signed-off-by: Josef Bacik > Signed-off-by: Greg Kroah-Hartman > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof