From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A8ECC433EF for ; Wed, 30 Mar 2022 08:21:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244306AbiC3IXI (ORCPT ); Wed, 30 Mar 2022 04:23:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244267AbiC3IWq (ORCPT ); Wed, 30 Mar 2022 04:22:46 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D05793120B; Wed, 30 Mar 2022 01:21:01 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 3C4931F443F6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1648628460; bh=sD9zda1gQkNv3MUA4bkv/V5WHuwzCfeFynE1ba/36bI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=lwqXWCyvUJTMcWkmXB/XryVKNZ3doT0L4in++YJhNLlEumVov1VdrMn6WG2XwP0ks blZ4fiFE4Q0hNhTRpBd0ICap0dAq4rUqv6Nx574wrl2C/2wf9fmlKPNu13ak+i9io3 XuGtTjPq0bybFhxrjyjT8O9tviLy2mV3ijMdf4YmcBenisQ5JUKxTJ1r+sC/KVqf8/ YDrwtXvpxBbOVALzBJ2KhF0A4Xle3gmzF1YumNtOdnjiLJ0IkLwdWn8R9yyHo3t0Pj tVq4OP09GfDsPwVt2n20oWvaZw3i7S6EQpXqzxGxqug2kMu8MrH9mYT6LXort9N/r+ q6o2+0V72XjlA== Message-ID: <61c2609c-18d1-fea9-7b71-0b17fb2beaef@collabora.com> Date: Wed, 30 Mar 2022 10:20:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v12 2/3] dt-bindings: mmc: mtk-sd: increase reg maxItems Content-Language: en-US To: Rob Herring Cc: Tinghan Shen , Chaotian Jing , Ulf Hansson , Krzysztof Kozlowski , Matthias Brugger , Wenbin Mei , linux-mmc , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , linux-arm-kernel , "moderated list:ARM/Mediatek SoC support" , Project_Global_Chrome_Upstream_Group , Ryder Lee , Chen-Yu Tsai , Chunfeng Yun References: <20220329114540.17140-1-tinghan.shen@mediatek.com> <20220329114540.17140-3-tinghan.shen@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 29/03/22 21:10, Rob Herring ha scritto: > On Tue, Mar 29, 2022 at 7:43 AM AngeloGioacchino Del Regno > wrote: >> >> Il 29/03/22 13:45, Tinghan Shen ha scritto: >>> Add optional host top register base for the reg binding description. >>> >>> Signed-off-by: Wenbin Mei >>> Signed-off-by: Tinghan Shen >>> --- >>> Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml >>> index 7032f7adf3ca..6d41bcec900f 100644 >>> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml >>> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml >>> @@ -40,7 +40,8 @@ properties: >>> - const: mediatek,mt8183-mmc >>> >>> reg: >>> - maxItems: 1 >>> + minItems: 1 >>> + maxItems: 2 >> >> it's just maxItems... adding minItems: 1 is not required. > > If 1 entry is still valid, then minItems is required. If not, then > it's an ABI break. > > Rob Right. Sorry for that and thanks for the explaination, Rob. Cheers, Angelo