From: Joe Perches <joe@perches.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
Alexandru Ardelean <ardeleanalex@gmail.com>
Cc: Yang Yingliang <yangyingliang@huawei.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH] iio: buffer: Fix double-free in iio_buffers_alloc_sysfs_and_mask()
Date: Tue, 12 Oct 2021 10:43:23 -0700 [thread overview]
Message-ID: <61c28865036cd40a96f2d1bb4c27fbbb08c2d3a5.camel@perches.com> (raw)
In-Reply-To: <CAHp75Vf+DHNxiP5HzsKzzh5hFmr20P8SzOTnLXAvhC5Vb6hzMA@mail.gmail.com>
On Tue, 2021-10-12 at 23:30 +0300, Andy Shevchenko wrote:
> On Tue, Oct 12, 2021 at 2:37 PM Alexandru Ardelean
> <ardeleanalex@gmail.com> wrote:
> >
> > On Tue, Oct 12, 2021 at 12:18 PM Yang Yingliang
> > <yangyingliang@huawei.com> wrote:
> > >
> > > When __iio_buffer_alloc_sysfs_and_mask() failed, 'unwind_idx' should be
> > > set to 'i - 1' to prevent double-free when cleanup resources.
[]
>
> I prefer to see
>
> - for (; unwind_idx >= 0; unwind_idx--) {
> + while (unwind_idx--)
Not the same code as unwind_idx would be decremented before entering
the code block.
You'd want
do {
...
} while (unwind_idx--);
next prev parent reply other threads:[~2021-10-12 17:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 9:25 Yang Yingliang
2021-10-12 11:36 ` Alexandru Ardelean
2021-10-12 20:30 ` Andy Shevchenko
2021-10-12 17:43 ` Joe Perches [this message]
2021-10-12 20:48 ` Andy Shevchenko
2021-10-12 17:55 ` Joe Perches
2021-10-12 20:58 ` Andy Shevchenko
2021-10-13 9:17 ` Yang Yingliang
2021-10-13 9:28 ` Andy Shevchenko
2021-10-13 9:50 ` Andy Shevchenko
2021-10-13 2:54 ` Yang Yingliang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61c28865036cd40a96f2d1bb4c27fbbb08c2d3a5.camel@perches.com \
--to=joe@perches.com \
--cc=andy.shevchenko@gmail.com \
--cc=ardeleanalex@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®