From: Alexey Budankov <alexey.budankov@linux.intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Andi Kleen <ak@linux.intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 2/3] perf mmap: declare type for cpu mask of arbitrary length
Date: Fri, 22 Nov 2019 19:01:41 +0300 [thread overview]
Message-ID: <61ce5a52-9c34-f936-b09b-f8f59cedcb66@linux.intel.com> (raw)
In-Reply-To: <53af9c5c-a33d-4fc4-88e9-851b1caad3f1@linux.intel.com>
On 22.11.2019 16:58, Alexey Budankov wrote:
> On 22.11.2019 16:20, Jiri Olsa wrote:
>> On Wed, Nov 20, 2019 at 12:37:48PM +0300, Alexey Budankov wrote:
>>>
<SNIP>
>>> +#define mmap_cpu_mask_bytes(m) \
>>
>> we try to have all macros upper case
>
> In v2.
>
>>
>>> + (BITS_TO_LONGS(((struct mmap_cpu_mask *)m)->nbits) * sizeof(unsigned long))
>>
>> we have BITS_TO_BYTES
>
> In v2.
Avoided BITS_TO_BYTES() in this particular case because
the storage is allocated in unsigned long chunks, thus
the possibly unused tail bytes at the last chunk would
be accounted in the returned size, and for compatibility
with cpu_set_t which is also allocated in unsigned longs.
~Alexey
next prev parent reply other threads:[~2019-11-22 16:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 9:33 [PATCH v1 0/3] perf record: adapt NUMA awareness to machines with #CPUs > 1K Alexey Budankov
2019-11-20 9:36 ` [PATCH v1 1/3] tools bitmap: implement bitmap_equal() operation at bitmap API Alexey Budankov
2019-11-20 9:37 ` [PATCH v1 2/3] perf mmap: declare type for cpu mask of arbitrary length Alexey Budankov
2019-11-22 13:20 ` Jiri Olsa
2019-11-22 13:58 ` Alexey Budankov
2019-11-22 16:01 ` Alexey Budankov [this message]
2019-11-20 9:38 ` [PATCH v1 3/3] perf record: adapt affinity to machines with #CPUs > 1K Alexey Budankov
2019-11-22 13:22 ` Jiri Olsa
2019-11-22 13:55 ` Alexey Budankov
2019-11-22 13:26 ` [PATCH v1 0/3] perf record: adapt NUMA awareness " Jiri Olsa
2019-11-22 14:00 ` Alexey Budankov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61ce5a52-9c34-f936-b09b-f8f59cedcb66@linux.intel.com \
--to=alexey.budankov@linux.intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®